Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1118491/?format=api
{ "id": 1118491, "url": "http://patchwork.ozlabs.org/api/patches/1118491/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20190619063928.7855-1-andy.tang@nxp.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190619063928.7855-1-andy.tang@nxp.com>", "list_archive_url": null, "date": "2019-06-19T06:39:28", "name": "[U-Boot,v2] common: qixis: make the qixis compatible with new soc", "commit_ref": "0f6607f9e9d4638f5d7759c95f4c513e57e3b3dc", "pull_url": null, "state": "accepted", "archived": false, "hash": "b192cbc1dee510402926861e7f807195a4969d99", "submitter": { "id": 71141, "url": "http://patchwork.ozlabs.org/api/people/71141/?format=api", "name": "Andy Tang", "email": "andy.tang@nxp.com" }, "delegate": { "id": 2467, "url": "http://patchwork.ozlabs.org/api/users/2467/?format=api", "username": "prabhu_kush", "first_name": "Prabhakar", "last_name": "Kushwaha", "email": "prabhakar@freescale.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20190619063928.7855-1-andy.tang@nxp.com/mbox/", "series": [ { "id": 114731, "url": "http://patchwork.ozlabs.org/api/series/114731/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=114731", "date": "2019-06-19T06:39:28", "name": "[U-Boot,v2] common: qixis: make the qixis compatible with new soc", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/114731/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1118491/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1118491/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=nxp.com" ], "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 45TFs75zLtz9sN6\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 19 Jun 2019 16:48:25 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid 97329C21DA2; Wed, 19 Jun 2019 06:48:19 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id D0C4BC21C38;\n\tWed, 19 Jun 2019 06:48:17 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 4DC11C21C38; Wed, 19 Jun 2019 06:48:16 +0000 (UTC)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n\tby lists.denx.de (Postfix) with ESMTPS id CE566C21BE5\n\tfor <u-boot@lists.denx.de>; Wed, 19 Jun 2019 06:48:15 +0000 (UTC)", "from inva021.nxp.com (localhost [127.0.0.1])\n\tby inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 26C012005AC;\n\tWed, 19 Jun 2019 08:48:15 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n\t[165.114.16.14])\n\tby inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id BCDC92005A7;\n\tWed, 19 Jun 2019 08:48:12 +0200 (CEST)", "from titan.ap.freescale.net (TITAN.ap.freescale.net\n\t[10.192.208.233])\n\tby invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id A48D5402F0;\n\tWed, 19 Jun 2019 14:48:09 +0800 (SGT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0", "From": "Yuantian Tang <andy.tang@nxp.com>", "To": "prabhakar.kushwaha@nxp.com", "Date": "Wed, 19 Jun 2019 14:39:28 +0800", "Message-Id": "<20190619063928.7855-1-andy.tang@nxp.com>", "X-Mailer": "git-send-email 2.14.1", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Cc": "u-boot@lists.denx.de, Yuantian Tang <andy.tang@nxp.com>", "Subject": "[U-Boot] [PATCH v2] common: qixis: make the qixis compatible with\n\tnew soc", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "This driver needs modification to work with new soc,\nlike ls1028, since bitmap of RCFG is changed to\nRESV[7:5] LIVE[4] WDEN[3] RESV[2:1] GO[0]\n 000 1 0 00 0\n\nAlso the RCW location is moved to only dutcfg0.\nRESV[7:4] RCWSRC[3:0]\n 1111 configurable\n\nFollowing commands are functional now\nqixis_reset\nqixis_reset sd\nqixis_reset qspi\nqixis_reset emmc\n\nSigned-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>\nSigned-off-by: Yuantian Tang <andy.tang@nxp.com>\n---\nv2:\n\t- refine the description\n board/freescale/common/qixis.c | 45 +++++++++++++++++++++++++---------\n 1 file changed, 33 insertions(+), 12 deletions(-)", "diff": "diff --git a/board/freescale/common/qixis.c b/board/freescale/common/qixis.c\nindex 2c4c4ae108..716c93b2c2 100644\n--- a/board/freescale/common/qixis.c\n+++ b/board/freescale/common/qixis.c\n@@ -21,6 +21,13 @@\n #define QIXIS_LBMAP_BRDCFG_REG 0x00\n #endif\n \n+#ifndef QIXIS_RCFG_CTL_RECONFIG_IDLE\n+#define QIXIS_RCFG_CTL_RECONFIG_IDLE 0x20\n+#endif\n+#ifndef QIXIS_RCFG_CTL_RECONFIG_START\n+#define QIXIS_RCFG_CTL_RECONFIG_START 0x21\n+#endif\n+\n #ifdef CONFIG_SYS_I2C_FPGA_ADDR\n u8 qixis_read_i2c(unsigned int reg)\n {\n@@ -159,11 +166,13 @@ static void qixis_reset(void)\n \tQIXIS_WRITE(rst_ctl, QIXIS_RST_CTL_RESET);\n }\n \n+#ifdef QIXIS_LBMAP_ALTBANK\n static void qixis_bank_reset(void)\n {\n \tQIXIS_WRITE(rcfg_ctl, QIXIS_RCFG_CTL_RECONFIG_IDLE);\n \tQIXIS_WRITE(rcfg_ctl, QIXIS_RCFG_CTL_RECONFIG_START);\n }\n+#endif\n \n static void __maybe_unused set_lbmap(int lbmap)\n {\n@@ -176,12 +185,16 @@ static void __maybe_unused set_lbmap(int lbmap)\n \n static void __maybe_unused set_rcw_src(int rcw_src)\n {\n+#ifdef CONFIG_NXP_LSCH3_2\n+\tQIXIS_WRITE(dutcfg[0], (rcw_src & 0xff));\n+#else\n \tu8 reg;\n \n \treg = QIXIS_READ(dutcfg[1]);\n \treg = (reg & ~1) | (rcw_src & 1);\n \tQIXIS_WRITE(dutcfg[1], reg);\n \tQIXIS_WRITE(dutcfg[0], (rcw_src >> 1) & 0xff);\n+#endif\n }\n \n static void qixis_dump_regs(void)\n@@ -227,16 +240,20 @@ static int qixis_reset_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const ar\n \t\tset_lbmap(QIXIS_LBMAP_DFLTBANK);\n \t\tqixis_reset();\n \t} else if (strcmp(argv[1], \"altbank\") == 0) {\n+#ifdef QIXIS_LBMAP_ALTBANK\n \t\tset_lbmap(QIXIS_LBMAP_ALTBANK);\n \t\tqixis_bank_reset();\n+#else\n+\t\tprintf(\"No Altbank!\\n\");\n+#endif\n \t} else if (strcmp(argv[1], \"nand\") == 0) {\n #ifdef QIXIS_LBMAP_NAND\n \t\tQIXIS_WRITE(rst_ctl, 0x30);\n \t\tQIXIS_WRITE(rcfg_ctl, 0);\n \t\tset_lbmap(QIXIS_LBMAP_NAND);\n \t\tset_rcw_src(QIXIS_RCW_SRC_NAND);\n-\t\tQIXIS_WRITE(rcfg_ctl, 0x20);\n-\t\tQIXIS_WRITE(rcfg_ctl, 0x21);\n+\t\tQIXIS_WRITE(rcfg_ctl, QIXIS_RCFG_CTL_RECONFIG_IDLE);\n+\t\tQIXIS_WRITE(rcfg_ctl, QIXIS_RCFG_CTL_RECONFIG_START);\n #else\n \t\tprintf(\"Not implemented\\n\");\n #endif\n@@ -250,8 +267,8 @@ static int qixis_reset_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const ar\n \t\tset_lbmap(QIXIS_LBMAP_SD);\n \t\tset_rcw_src(QIXIS_RCW_SRC_SD);\n #endif\n-\t\tQIXIS_WRITE(rcfg_ctl, 0x20);\n-\t\tQIXIS_WRITE(rcfg_ctl, 0x21);\n+\t\tQIXIS_WRITE(rcfg_ctl, QIXIS_RCFG_CTL_RECONFIG_IDLE);\n+\t\tQIXIS_WRITE(rcfg_ctl, QIXIS_RCFG_CTL_RECONFIG_START);\n #else\n \t\tprintf(\"Not implemented\\n\");\n #endif\n@@ -261,8 +278,8 @@ static int qixis_reset_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const ar\n \t\tQIXIS_WRITE(rcfg_ctl, 0);\n \t\tset_lbmap(QIXIS_LBMAP_IFC);\n \t\tset_rcw_src(QIXIS_RCW_SRC_IFC);\n-\t\tQIXIS_WRITE(rcfg_ctl, 0x20);\n-\t\tQIXIS_WRITE(rcfg_ctl, 0x21);\n+\t\tQIXIS_WRITE(rcfg_ctl, QIXIS_RCFG_CTL_RECONFIG_IDLE);\n+\t\tQIXIS_WRITE(rcfg_ctl, QIXIS_RCFG_CTL_RECONFIG_START);\n #else\n \t\tprintf(\"Not implemented\\n\");\n #endif\n@@ -272,8 +289,8 @@ static int qixis_reset_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const ar\n \t\tQIXIS_WRITE(rcfg_ctl, 0);\n \t\tset_lbmap(QIXIS_LBMAP_EMMC);\n \t\tset_rcw_src(QIXIS_RCW_SRC_EMMC);\n-\t\tQIXIS_WRITE(rcfg_ctl, 0x20);\n-\t\tQIXIS_WRITE(rcfg_ctl, 0x21);\n+\t\tQIXIS_WRITE(rcfg_ctl, QIXIS_RCFG_CTL_RECONFIG_IDLE);\n+\t\tQIXIS_WRITE(rcfg_ctl, QIXIS_RCFG_CTL_RECONFIG_START);\n #else\n \t\tprintf(\"Not implemented\\n\");\n #endif\n@@ -283,8 +300,10 @@ static int qixis_reset_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const ar\n \t\tQIXIS_WRITE(rcfg_ctl, 0);\n \t\tset_lbmap(QIXIS_LBMAP_SD_QSPI);\n \t\tset_rcw_src(QIXIS_RCW_SRC_SD);\n-\t\tqixis_write_i2c(offsetof(struct qixis, rcfg_ctl), 0x20);\n-\t\tqixis_write_i2c(offsetof(struct qixis, rcfg_ctl), 0x21);\n+\t\tqixis_write_i2c(offsetof(struct qixis, rcfg_ctl),\n+\t\t\t\tQIXIS_RCFG_CTL_RECONFIG_IDLE);\n+\t\tqixis_write_i2c(offsetof(struct qixis, rcfg_ctl),\n+\t\t\t\tQIXIS_RCFG_CTL_RECONFIG_START);\n #else\n \t\tprintf(\"Not implemented\\n\");\n #endif\n@@ -294,8 +313,10 @@ static int qixis_reset_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const ar\n \t\tQIXIS_WRITE(rcfg_ctl, 0);\n \t\tset_lbmap(QIXIS_LBMAP_QSPI);\n \t\tset_rcw_src(QIXIS_RCW_SRC_QSPI);\n-\t\tqixis_write_i2c(offsetof(struct qixis, rcfg_ctl), 0x20);\n-\t\tqixis_write_i2c(offsetof(struct qixis, rcfg_ctl), 0x21);\n+\t\tqixis_write_i2c(offsetof(struct qixis, rcfg_ctl),\n+\t\t\t\tQIXIS_RCFG_CTL_RECONFIG_IDLE);\n+\t\tqixis_write_i2c(offsetof(struct qixis, rcfg_ctl),\n+\t\t\t\tQIXIS_RCFG_CTL_RECONFIG_START);\n #else\n \t\tprintf(\"Not implemented\\n\");\n #endif\n", "prefixes": [ "U-Boot", "v2" ] }