Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1118204/?format=api
{ "id": 1118204, "url": "http://patchwork.ozlabs.org/api/patches/1118204/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190618115513.99661-2-dedekind1@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190618115513.99661-2-dedekind1@gmail.com>", "list_archive_url": null, "date": "2019-06-18T11:55:13", "name": "[2/2] net: intel: igb: add RR2DCDELAY to ethtool registers dump", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ad1b2232075ac5a4a7037e03855d5a5c998c8a36", "submitter": { "id": 2555, "url": "http://patchwork.ozlabs.org/api/people/2555/?format=api", "name": "Artem Bityutskiy", "email": "dedekind1@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190618115513.99661-2-dedekind1@gmail.com/mbox/", "series": [ { "id": 114610, "url": "http://patchwork.ozlabs.org/api/series/114610/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=114610", "date": "2019-06-18T11:55:13", "name": null, "version": 1, "mbox": "http://patchwork.ozlabs.org/series/114610/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1118204/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1118204/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=gmail.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45SwWD4YY6z9sN6\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 19 Jun 2019 03:46:46 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E7A3584FB2;\n\tTue, 18 Jun 2019 17:46:44 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id EssiuB6vLZq7; Tue, 18 Jun 2019 17:46:43 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id A214985065;\n\tTue, 18 Jun 2019 17:46:43 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id BC7CF1BF869\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 18 Jun 2019 12:02:24 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B8A4686DF0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 18 Jun 2019 12:02:24 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ATSl5lnWOij9 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 18 Jun 2019 12:02:22 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id C72EE83957\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 18 Jun 2019 12:02:22 +0000 (UTC)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Jun 2019 04:55:18 -0700", "from powerlab.fi.intel.com (HELO powerlab.backendnet)\n\t([10.237.71.25])\n\tby orsmga007.jf.intel.com with ESMTP; 18 Jun 2019 04:55:16 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,389,1557212400\"; d=\"scan'208\";a=\"150241715\"", "From": "Artem Bityutskiy <dedekind1@gmail.com>", "To": "\"David S. Miller\" <davem@davemloft.net>", "Date": "Tue, 18 Jun 2019 14:55:13 +0300", "Message-Id": "<20190618115513.99661-2-dedekind1@gmail.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190618115513.99661-1-dedekind1@gmail.com>", "References": "<20190618115513.99661-1-dedekind1@gmail.com>", "MIME-Version": "1.0", "X-Mailman-Approved-At": "Tue, 18 Jun 2019 17:46:42 +0000", "Subject": "[Intel-wired-lan] [PATCH 2/2] net: intel: igb: add RR2DCDELAY to\n\tethtool registers dump", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>\n\nThis patch adds the RR2DCDELAY register to the ethtool registers dump.\nRR2DCDELAY exists on I210 and I211 Intel Gigabit Ethernet chips and it stands\nfor \"Read Request To Data Completion Delay\". Here is how this register is\ndescribed in the I210 datasheet:\n\n\"This field captures the maximum PCIe split time in 16 ns units, which is the\nmaximum delay between the read request to the first data completion. This is\ngiving an estimation of the PCIe round trip time.\"\n\nIn other words, whenever I210 reads from the host memory (e.g., fetches a\ndescriptor from the ring), the chip measures every PCI DMA read transaction and\ncaptures the maximum value. So it ends up containing the longest DMA\ntransaction time.\n\nThis register is very useful for troubleshooting and research purposes. If you\nare dealing with time-sensitive networks, this register can help you get\nan idea of your \"I210-to-ring\" latency. This helps answering questions like\n\"should I have PCIe ASPM enabled?\" or \"should I enable deep C-states?\" on\nmy system.\n\nIt is safe to read this register at any point, reading it has no effect on\nthe I210 chip functionality.\n\nSigned-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>\n---\n drivers/net/ethernet/intel/igb/e1000_regs.h | 2 ++\n drivers/net/ethernet/intel/igb/igb_ethtool.c | 5 ++++-\n 2 files changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/e1000_regs.h b/drivers/net/ethernet/intel/igb/e1000_regs.h\nindex 0ad737d2f289..9cb49980ec2d 100644\n--- a/drivers/net/ethernet/intel/igb/e1000_regs.h\n+++ b/drivers/net/ethernet/intel/igb/e1000_regs.h\n@@ -409,6 +409,8 @@ do { \\\n #define E1000_I210_TQAVCC(_n)\t(0x3004 + ((_n) * 0x40))\n #define E1000_I210_TQAVHC(_n)\t(0x300C + ((_n) * 0x40))\n \n+#define E1000_I210_RR2DCDELAY\t0x5BF4\n+\n #define E1000_INVM_DATA_REG(_n)\t(0x12120 + 4*(_n))\n #define E1000_INVM_SIZE\t\t64 /* Number of INVM Data Registers */\n \ndiff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c\nindex 401bc2bd6b21..3182b059bf55 100644\n--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c\n+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c\n@@ -448,7 +448,7 @@ static void igb_set_msglevel(struct net_device *netdev, u32 data)\n \n static int igb_get_regs_len(struct net_device *netdev)\n {\n-#define IGB_REGS_LEN 739\n+#define IGB_REGS_LEN 740\n \treturn IGB_REGS_LEN * sizeof(u32);\n }\n \n@@ -710,6 +710,9 @@ static void igb_get_regs(struct net_device *netdev,\n \t\tfor (i = 0; i < 12; i++)\n \t\t\tregs_buff[727 + i] = rd32(E1000_TDWBAH(i + 4));\n \t}\n+\n+\tif (hw->mac.type == e1000_i210 || hw->mac.type == e1000_i211)\n+\t\tregs_buff[739] = rd32(E1000_I210_RR2DCDELAY);\n }\n \n static int igb_get_eeprom_len(struct net_device *netdev)\n", "prefixes": [ "2/2" ] }