Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1116315/?format=api
{ "id": 1116315, "url": "http://patchwork.ozlabs.org/api/patches/1116315/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190614232320.9752-1-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190614232320.9752-1-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2019-06-14T23:23:20", "name": "[next,v2] iavf: use struct_size() helper", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "066cfaf2b2e78ac16dba4fdde1c02356004832e0", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190614232320.9752-1-jeffrey.t.kirsher@intel.com/mbox/", "series": [ { "id": 114003, "url": "http://patchwork.ozlabs.org/api/series/114003/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=114003", "date": "2019-06-14T23:23:20", "name": "[next,v2] iavf: use struct_size() helper", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/114003/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1116315/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1116315/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45Qc9J56Ybz9s3Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 15 Jun 2019 09:23:13 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1B4C787D5A;\n\tFri, 14 Jun 2019 23:23:11 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FKNnI5rLeOxo; Fri, 14 Jun 2019 23:23:09 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 21F5487D51;\n\tFri, 14 Jun 2019 23:23:09 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 62DF61BF48B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jun 2019 23:23:08 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 5A8BB868A2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jun 2019 23:23:08 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id buF0GC2JWqN6 for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jun 2019 23:23:07 +0000 (UTC)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 79A828671E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 14 Jun 2019 23:23:07 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Jun 2019 16:23:05 -0700", "from jtkirshe-desk1.jf.intel.com ([134.134.177.96])\n\tby orsmga005.jf.intel.com with ESMTP; 14 Jun 2019 16:23:06 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 14 Jun 2019 16:23:20 -0700", "Message-Id": "<20190614232320.9752-1-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next v2] iavf: use struct_size() helper", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: \"Gustavo A. R. Silva\" <gustavo@embeddedor.com>\n\nMake use of the struct_size() helper instead of an open-coded version\nin order to avoid any potential type mistakes, in particular in the\ncontext in which this code is being used.\n\nSo, replace code of the following form:\n\nsizeof(struct virtchnl_ether_addr_list) + (count * sizeof(struct virtchnl_ether_addr))\n\nwith:\n\nstruct_size(veal, list, count)\n\nand so on...\n\nThis code was detected with the help of Coccinelle.\n\nSigned-off-by: \"Gustavo A. R. Silva\" <gustavo@embeddedor.com>\n---\nv2: Fixed up patch to apply cleanly to the current iavf driver\n\n .../net/ethernet/intel/iavf/iavf_virtchnl.c | 37 ++++++++-----------\n 1 file changed, 16 insertions(+), 21 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c\nindex cb7c56c5afe6..d49d58a6de80 100644\n--- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c\n@@ -242,7 +242,8 @@ void iavf_configure_queues(struct iavf_adapter *adapter)\n \tstruct virtchnl_vsi_queue_config_info *vqci;\n \tstruct virtchnl_queue_pair_info *vqpi;\n \tint pairs = adapter->num_active_queues;\n-\tint i, len, max_frame = IAVF_MAX_RXBUFFER;\n+\tint i, max_frame = IAVF_MAX_RXBUFFER;\n+\tsize_t len;\n \n \tif (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {\n \t\t/* bail because we already have a command pending */\n@@ -251,8 +252,7 @@ void iavf_configure_queues(struct iavf_adapter *adapter)\n \t\treturn;\n \t}\n \tadapter->current_op = VIRTCHNL_OP_CONFIG_VSI_QUEUES;\n-\tlen = sizeof(struct virtchnl_vsi_queue_config_info) +\n-\t\t (sizeof(struct virtchnl_queue_pair_info) * pairs);\n+\tlen = struct_size(vqci, qpair, pairs);\n \tvqci = kzalloc(len, GFP_KERNEL);\n \tif (!vqci)\n \t\treturn;\n@@ -351,8 +351,9 @@ void iavf_map_queues(struct iavf_adapter *adapter)\n {\n \tstruct virtchnl_irq_map_info *vimi;\n \tstruct virtchnl_vector_map *vecmap;\n-\tint v_idx, q_vectors, len;\n \tstruct iavf_q_vector *q_vector;\n+\tint v_idx, q_vectors;\n+\tsize_t len;\n \n \tif (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {\n \t\t/* bail because we already have a command pending */\n@@ -364,9 +365,7 @@ void iavf_map_queues(struct iavf_adapter *adapter)\n \n \tq_vectors = adapter->num_msix_vectors - NONQ_VECS;\n \n-\tlen = sizeof(struct virtchnl_irq_map_info) +\n-\t (adapter->num_msix_vectors *\n-\t\tsizeof(struct virtchnl_vector_map));\n+\tlen = struct_size(vimi, vecmap, adapter->num_msix_vectors);\n \tvimi = kzalloc(len, GFP_KERNEL);\n \tif (!vimi)\n \t\treturn;\n@@ -433,9 +432,10 @@ int iavf_request_queues(struct iavf_adapter *adapter, int num)\n void iavf_add_ether_addrs(struct iavf_adapter *adapter)\n {\n \tstruct virtchnl_ether_addr_list *veal;\n-\tint len, i = 0, count = 0;\n \tstruct iavf_mac_filter *f;\n+\tint i = 0, count = 0;\n \tbool more = false;\n+\tsize_t len;\n \n \tif (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {\n \t\t/* bail because we already have a command pending */\n@@ -457,15 +457,13 @@ void iavf_add_ether_addrs(struct iavf_adapter *adapter)\n \t}\n \tadapter->current_op = VIRTCHNL_OP_ADD_ETH_ADDR;\n \n-\tlen = sizeof(struct virtchnl_ether_addr_list) +\n-\t (count * sizeof(struct virtchnl_ether_addr));\n+\tlen = struct_size(veal, list, count);\n \tif (len > IAVF_MAX_AQ_BUF_SIZE) {\n \t\tdev_warn(&adapter->pdev->dev, \"Too many add MAC changes in one request\\n\");\n \t\tcount = (IAVF_MAX_AQ_BUF_SIZE -\n \t\t\t sizeof(struct virtchnl_ether_addr_list)) /\n \t\t\tsizeof(struct virtchnl_ether_addr);\n-\t\tlen = sizeof(struct virtchnl_ether_addr_list) +\n-\t\t (count * sizeof(struct virtchnl_ether_addr));\n+\t\tlen = struct_size(veal, list, count);\n \t\tmore = true;\n \t}\n \n@@ -505,8 +503,9 @@ void iavf_del_ether_addrs(struct iavf_adapter *adapter)\n {\n \tstruct virtchnl_ether_addr_list *veal;\n \tstruct iavf_mac_filter *f, *ftmp;\n-\tint len, i = 0, count = 0;\n+\tint i = 0, count = 0;\n \tbool more = false;\n+\tsize_t len;\n \n \tif (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {\n \t\t/* bail because we already have a command pending */\n@@ -528,15 +527,13 @@ void iavf_del_ether_addrs(struct iavf_adapter *adapter)\n \t}\n \tadapter->current_op = VIRTCHNL_OP_DEL_ETH_ADDR;\n \n-\tlen = sizeof(struct virtchnl_ether_addr_list) +\n-\t (count * sizeof(struct virtchnl_ether_addr));\n+\tlen = struct_size(veal, list, count);\n \tif (len > IAVF_MAX_AQ_BUF_SIZE) {\n \t\tdev_warn(&adapter->pdev->dev, \"Too many delete MAC changes in one request\\n\");\n \t\tcount = (IAVF_MAX_AQ_BUF_SIZE -\n \t\t\t sizeof(struct virtchnl_ether_addr_list)) /\n \t\t\tsizeof(struct virtchnl_ether_addr);\n-\t\tlen = sizeof(struct virtchnl_ether_addr_list) +\n-\t\t (count * sizeof(struct virtchnl_ether_addr));\n+\t\tlen = struct_size(veal, list, count);\n \t\tmore = true;\n \t}\n \tveal = kzalloc(len, GFP_ATOMIC);\n@@ -973,7 +970,7 @@ static void iavf_print_link_message(struct iavf_adapter *adapter)\n void iavf_enable_channels(struct iavf_adapter *adapter)\n {\n \tstruct virtchnl_tc_info *vti = NULL;\n-\tu16 len;\n+\tsize_t len;\n \tint i;\n \n \tif (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {\n@@ -983,9 +980,7 @@ void iavf_enable_channels(struct iavf_adapter *adapter)\n \t\treturn;\n \t}\n \n-\tlen = ((adapter->num_tc - 1) * sizeof(struct virtchnl_channel_info)) +\n-\t sizeof(struct virtchnl_tc_info);\n-\n+\tlen = struct_size(vti, list, adapter->num_tc - 1);\n \tvti = kzalloc(len, GFP_KERNEL);\n \tif (!vti)\n \t\treturn;\n", "prefixes": [ "next", "v2" ] }