Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1113354/?format=api
{ "id": 1113354, "url": "http://patchwork.ozlabs.org/api/patches/1113354/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190610212750.173711-1-venkateshs@google.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190610212750.173711-1-venkateshs@google.com>", "list_archive_url": null, "date": "2019-06-10T21:27:50", "name": "e1000: Use dma_wmb() instead of wmb() before doorbell writes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1d90fb6003f4e4df90692a43c72c1d80fe3f7605", "submitter": { "id": 67810, "url": "http://patchwork.ozlabs.org/api/people/67810/?format=api", "name": "Venkatesh Srinivas", "email": "venkateshs@google.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190610212750.173711-1-venkateshs@google.com/mbox/", "series": [ { "id": 112977, "url": "http://patchwork.ozlabs.org/api/series/112977/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=112977", "date": "2019-06-10T21:27:50", "name": "e1000: Use dma_wmb() instead of wmb() before doorbell writes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/112977/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1113354/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1113354/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=fail (p=reject dis=none)\n\theader.from=google.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"YVZgVA6R\"; dkim-atps=neutral" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45N6Sc4QBqz9sBp\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 11 Jun 2019 07:57:52 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7BDA4204E7;\n\tMon, 10 Jun 2019 21:57:50 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id SDagRFf-Me9b; Mon, 10 Jun 2019 21:57:49 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 527072045E;\n\tMon, 10 Jun 2019 21:57:49 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id BBD6F1BF57C\n\tfor <intel-wired-lan@osuosl.org>;\n\tMon, 10 Jun 2019 21:57:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B58FC86793\n\tfor <intel-wired-lan@osuosl.org>;\n\tMon, 10 Jun 2019 21:57:47 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Z7EBm0cn+CNE for <intel-wired-lan@osuosl.org>;\n\tMon, 10 Jun 2019 21:57:47 +0000 (UTC)", "from mail-ot1-f73.google.com (mail-ot1-f73.google.com\n\t[209.85.210.73])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 0B1BB86576\n\tfor <intel-wired-lan@osuosl.org>;\n\tMon, 10 Jun 2019 21:57:47 +0000 (UTC)", "by mail-ot1-f73.google.com with SMTP id h12so5460837otn.18\n\tfor <intel-wired-lan@osuosl.org>;\n\tMon, 10 Jun 2019 14:57:46 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:20:37 by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=date:message-id:mime-version:subject:from:to:cc;\n\tbh=kiYuefH1qbNEMBmcxuoH52kO/h83hLfKEn3/GLwyIuI=;\n\tb=YVZgVA6RB1R8D0sH4yu2cKnWBxKEN6wtHQVCSeg+qCHejGLGjaNl+HlHznOiV4iauD\n\t6zpo+xId9KCOmLcWIzbIB0MvJj7dtofKBcZicnhFCr58zg9s7f/TWQ5Bj9i3vzp+gGKF\n\tWrdOjP5qHB1aYJtawUUsIJdysSLCyiXKqiM+Fd89wAXSg4jfQaaEPNveR2ckSPLcGdDH\n\tPZw67AmouKw4C8LBLimUP7q17S75WOFwl19mtk5E7/RVHRCi38Cj+tdDpAKZarSugrJy\n\tWi+ORuMrmv4PxenECR3m/VuIC/vkNPNKD05XImp4nKy6wPdNiuD1OiqSmTD03eeDpMz2\n\tw3vw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; \n\tbh=kiYuefH1qbNEMBmcxuoH52kO/h83hLfKEn3/GLwyIuI=;\n\tb=Hx9mgAGlpR3IbYB1+ueM4Uoq+qOgZGAHMaHHoUZzt7F7BK7gogy3xmKWSBWGEIajJC\n\tC+PnvsSIZySHXucAFQIZbAj6ORWDP8Cpc5F5GKc9BSRovbvXW2WkmKJaJwJOgNd8VNLK\n\tdlAuYVctHRJrGZTxpFlj1HpLdHQaeOaUq0LzSVAdUhe2r3jtTe/hm0DVLusoPXqZO0Fg\n\tsnSG4vi4mETEiyoE33Sbla2HEno6bQSPiLrs2RBVIpMxT0rquFrMf/sHGN+H/cPg6jun\n\tPA3ybpFczp91Tf9O/TjmEQJxiGsj0Ci5yuWlhvZROu4rdganac+Zl3dxR5EMlCTY+2GF\n\tfA+g==", "X-Gm-Message-State": "APjAAAUkd5RLB5BUeAho1MAAY+lF2rDSpBZCCyyBU90rrk2PGilUF8Uc\n\tbctDmgDLsURpC38GmR71EuBLUQ7d/c4wReHX", "X-Google-Smtp-Source": "APXvYqy6u8CYeLGvpBZimyp7uR78v7NoGs/h0blYwybQNp9XRXQ6RPrKYSD6Wyt7Q9Hjps7B1WOdSHQ5f8EPhGUx", "X-Received": "by 2002:a63:480a:: with SMTP id\n\tv10mr14263680pga.60.1560202219620; \n\tMon, 10 Jun 2019 14:30:19 -0700 (PDT)", "Date": "Mon, 10 Jun 2019 14:27:50 -0700", "Message-Id": "<20190610212750.173711-1-venkateshs@google.com>", "Mime-Version": "1.0", "X-Mailer": "git-send-email 2.22.0.rc2.383.gf4fbbf30c2-goog", "From": "Venkatesh Srinivas <venkateshs@google.com>", "To": "jeffrey.t.kirsher@intel.com", "Subject": "[Intel-wired-lan] [PATCH] e1000: Use dma_wmb() instead of wmb()\n\tbefore doorbell writes", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "intel-wired-lan@osuosl.org, vsrinivas@ops101.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "e1000 writes to doorbells to post transmit descriptors and fill the\nreceive ring. After writing descriptors to memory but before\nwriting to doorbells, use dma_wmb() rather than wmb(). wmb() is more\nheavyweight than necessary for a device to see descriptor writes.\n\nOn x86, this avoids SFENCEs before doorbell writes in both the\ntx and rx paths. On ARM, this converts DSB ST -> DMB OSHST.\n\nTested: 82576EB / x86; QEMU (qemu emulates an 8257x)\n\nSigned-off-by: Venkatesh Srinivas <venkateshs@google.com>\n---\n drivers/net/ethernet/intel/e1000/e1000_main.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c\nindex 551de8c2fef2..f703fa58458e 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_main.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c\n@@ -3019,7 +3019,7 @@ static void e1000_tx_queue(struct e1000_adapter *adapter,\n \t * applicable for weak-ordered memory model archs,\n \t * such as IA-64).\n \t */\n-\twmb();\n+\tdma_wmb();\n \n \ttx_ring->next_to_use = i;\n }\n@@ -4540,7 +4540,7 @@ e1000_alloc_jumbo_rx_buffers(struct e1000_adapter *adapter,\n \t\t * applicable for weak-ordered memory model archs,\n \t\t * such as IA-64).\n \t\t */\n-\t\twmb();\n+\t\tdma_wmb();\n \t\twritel(i, adapter->hw.hw_addr + rx_ring->rdt);\n \t}\n }\n@@ -4655,7 +4655,7 @@ static void e1000_alloc_rx_buffers(struct e1000_adapter *adapter,\n \t\t * applicable for weak-ordered memory model archs,\n \t\t * such as IA-64).\n \t\t */\n-\t\twmb();\n+\t\tdma_wmb();\n \t\twritel(i, hw->hw_addr + rx_ring->rdt);\n \t}\n }\n", "prefixes": [] }