Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1113/?format=api
{ "id": 1113, "url": "http://patchwork.ozlabs.org/api/patches/1113/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/200809231704.56449.matthias.fuchs@esd-electronics.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<200809231704.56449.matthias.fuchs@esd-electronics.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/200809231704.56449.matthias.fuchs@esd-electronics.com/", "date": "2008-09-23T15:04:56", "name": "[V2] powerpc: Fix Book-E watchdog timer interval setting", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "44e1cbdb50775917c7e5239964ad9a1d3d7d6820", "submitter": { "id": 79, "url": "http://patchwork.ozlabs.org/api/people/79/?format=api", "name": "Matthias Fuchs", "email": "matthias.fuchs@esd-electronics.com" }, "delegate": { "id": 9, "url": "http://patchwork.ozlabs.org/api/users/9/?format=api", "username": "galak", "first_name": "Kumar", "last_name": "Gala", "email": "galak@kernel.crashing.org" }, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/200809231704.56449.matthias.fuchs@esd-electronics.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/1113/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1113/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@ozlabs.org" ], "Received": [ "from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 5BB18DE744\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 24 Sep 2008 01:06:24 +1000 (EST)", "from moutng.kundenserver.de (moutng.kundenserver.de\n\t[212.227.126.183]) by ozlabs.org (Postfix) with ESMTP id AEBDEDDFCC\n\tfor <linuxppc-dev@ozlabs.org>; Wed, 24 Sep 2008 01:06:05 +1000 (EST)", "from comm-neu.esd (a89-182-151-249.net-htp.de [89.182.151.249])\n\tby mrelayeu.kundenserver.de (node=mrelayeu4) with ESMTP (Nemesis)\n\tid 0ML21M-1Ki9Sj21Rd-0007tH; Tue, 23 Sep 2008 17:06:02 +0200", "from localhost (localhost [127.0.0.1])\n\tby comm-neu.esd (Postfix) with ESMTP\n\tid 12AC6108050; Tue, 23 Sep 2008 17:05:10 +0200 (CEST)", "from comm-neu.esd ([127.0.0.1])\n\tby localhost (comm [127.0.0.1]) (amavisd-new, port 10024) with LMTP\n\tid 02473-02-6; Tue, 23 Sep 2008 17:05:01 +0200 (CEST)", "from debby.esd (debby.esd [10.0.0.190])\n\tby comm-neu.esd (Postfix) with ESMTP\n\tid 1102C10801C; Tue, 23 Sep 2008 17:05:01 +0200 (CEST)" ], "From": "Matthias Fuchs <matthias.fuchs@esd-electronics.com>", "To": "Kumar Gala <galak@kernel.crashing.org>", "Subject": "[PATCH V2] powerpc: Fix Book-E watchdog timer interval setting", "Date": "Tue, 23 Sep 2008 17:04:56 +0200", "User-Agent": "KMail/1.9.5", "References": "<200808071448.06183.matthias.fuchs@esd-electronics.com>\n\t<200809192328.36159.matthias.fuchs@esd-electronics.com>\n\t<7CA29A12-6DC4-4939-9541-6270FE5D910A@kernel.crashing.org>", "In-Reply-To": "<7CA29A12-6DC4-4939-9541-6270FE5D910A@kernel.crashing.org>", "MIME-Version": "1.0", "Content-Disposition": "inline", "Message-Id": "<200809231704.56449.matthias.fuchs@esd-electronics.com>", "X-Virus-Scanned": "by amavisd at esd-GmbH-Hannover", "X-Provags-ID": "V01U2FsdGVkX1/7lqpLWw/vMlBPpFz1DfQNYk5dpwSj9T1Y9qq\n\t+GR91aa4g96AJkuEseEdMt99af3U0AckDpK58bFvh9ceIFDmoG\n\tY+fALlSATKvSjyRC6Trig==", "Cc": "linuxppc-dev@ozlabs.org", "X-BeenThere": "linuxppc-dev@ozlabs.org", "X-Mailman-Version": "2.1.11", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>", "List-Unsubscribe": "<https://ozlabs.org/mailman/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://ozlabs.org/pipermail/linuxppc-dev>", "List-Post": "<mailto:linuxppc-dev@ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@ozlabs.org?subject=help>", "List-Subscribe": "<https://ozlabs.org/mailman/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org" }, "content": "This patch fixes the setting of the Book-E watchdog timer interval setup\non initialization and by ioctl().\n\nOn initialization the period bits have to be masked before setting\na new period.\n\nIn WDIOC_SETTIMEOUT ioctl we have to use the currect mask.\n\nSigned-off-by: Matthias Fuchs <matthias.fuchs@esd-electronics.com>\n---\n drivers/watchdog/booke_wdt.c | 5 ++++-\n 1 files changed, 4 insertions(+), 1 deletions(-)", "diff": "diff --git a/drivers/watchdog/booke_wdt.c b/drivers/watchdog/booke_wdt.c\nindex c3b78a7..41ba9b8 100644\n--- a/drivers/watchdog/booke_wdt.c\n+++ b/drivers/watchdog/booke_wdt.c\n@@ -42,8 +42,10 @@ u32 booke_wdt_period = WDT_PERIOD_DEFAULT;\n \n #ifdef\tCONFIG_FSL_BOOKE\n #define WDTP(x)\t\t((((63-x)&0x3)<<30)|(((63-x)&0x3c)<<15))\n+#define WDTP_MASK\t(WDTP(63))\n #else\n #define WDTP(x)\t\t(TCR_WP(x))\n+#define WDTP_MASK\t(TCR_WP_MASK)\n #endif\n \n static DEFINE_SPINLOCK(booke_wdt_lock);\n@@ -65,6 +67,7 @@ static void __booke_wdt_enable(void *data)\n \t/* clear status before enabling watchdog */\n \t__booke_wdt_ping(NULL);\n \tval = mfspr(SPRN_TCR);\n+\tval &= ~WDTP_MASK;\n \tval |= (TCR_WIE|TCR_WRC(WRC_CHIP)|WDTP(booke_wdt_period));\n \n \tmtspr(SPRN_TCR, val);\n@@ -114,7 +117,7 @@ static long booke_wdt_ioctl(struct file *file,\n \tcase WDIOC_SETTIMEOUT:\n \t\tif (get_user(booke_wdt_period, p))\n \t\t\treturn -EFAULT;\n-\t\tmtspr(SPRN_TCR, (mfspr(SPRN_TCR) & ~WDTP(0)) |\n+\t\tmtspr(SPRN_TCR, (mfspr(SPRN_TCR) & ~WDTP_MASK) |\n \t\t\t\t\t\tWDTP(booke_wdt_period));\n \t\treturn 0;\n \tcase WDIOC_GETTIMEOUT:\n", "prefixes": [ "V2" ] }