Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1107439/?format=api
{ "id": 1107439, "url": "http://patchwork.ozlabs.org/api/patches/1107439/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190529230642.87106-1-lihong.yang@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190529230642.87106-1-lihong.yang@intel.com>", "list_archive_url": null, "date": "2019-05-29T23:06:42", "name": "i40e: Check and set the PF driver state first in i40e_ndo_set_vf_mac", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5574f46facbf6eacdf79a56b3b5df81cf39ddda9", "submitter": { "id": 72053, "url": "http://patchwork.ozlabs.org/api/people/72053/?format=api", "name": "Lihong Yang", "email": "lihong.yang@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190529230642.87106-1-lihong.yang@intel.com/mbox/", "series": [ { "id": 110746, "url": "http://patchwork.ozlabs.org/api/series/110746/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=110746", "date": "2019-05-29T23:06:42", "name": "i40e: Check and set the PF driver state first in i40e_ndo_set_vf_mac", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/110746/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1107439/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1107439/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45DmVh6y2mz9s55\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 30 May 2019 09:04:12 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id BE18F848A0;\n\tWed, 29 May 2019 23:04:09 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Ife6EhUTVxPp; Wed, 29 May 2019 23:04:08 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B84108499A;\n\tWed, 29 May 2019 23:04:08 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 4FF8E1BF286\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 29 May 2019 23:04:08 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4CB3486DBD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 29 May 2019 23:04:08 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tjha-OqesplM for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 29 May 2019 23:04:06 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 119F086DDE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 29 May 2019 23:04:05 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 May 2019 16:04:05 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.154])\n\tby fmsmga001.fm.intel.com with ESMTP; 29 May 2019 16:04:04 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Lihong Yang <lihong.yang@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 29 May 2019 16:06:42 -0700", "Message-Id": "<20190529230642.87106-1-lihong.yang@intel.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] i40e: Check and set the PF driver state\n\tfirst in i40e_ndo_set_vf_mac", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The PF driver state flag __I40E_VIRTCHNL_OP_PENDING needs to be\nchecked and set at the beginning of i40e_ndo_set_vf_mac. Otherwise,\nif there are error conditions before it, the flag will be cleared\nunexpectedly by this function to cause potential race conditions.\nHence move the check to the top of this function.\n\nSigned-off-by: Lihong Yang <lihong.yang@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 38484ed6880d..ac3a130ee7d4 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -3940,6 +3940,11 @@ int i40e_ndo_set_vf_mac(struct net_device *netdev, int vf_id, u8 *mac)\n \tint bkt;\n \tu8 i;\n \n+\tif (test_and_set_bit(__I40E_VIRTCHNL_OP_PENDING, pf->state)) {\n+\t\tdev_warn(&pf->pdev->dev, \"Unable to configure VFs, other operation is pending.\\n\");\n+\t\treturn -EAGAIN;\n+\t}\n+\n \t/* validate the request */\n \tret = i40e_validate_vf(pf, vf_id);\n \tif (ret)\n@@ -3964,11 +3969,6 @@ int i40e_ndo_set_vf_mac(struct net_device *netdev, int vf_id, u8 *mac)\n \t\tgoto error_param;\n \t}\n \n-\tif (test_and_set_bit(__I40E_VIRTCHNL_OP_PENDING, pf->state)) {\n-\t\tdev_warn(&pf->pdev->dev, \"Unable to configure VFs, other operation is pending.\\n\");\n-\t\treturn -EAGAIN;\n-\t}\n-\n \tif (is_multicast_ether_addr(mac)) {\n \t\tdev_err(&pf->pdev->dev,\n \t\t\t\"Invalid Ethernet address %pM for VF %d\\n\", mac, vf_id);\n", "prefixes": [] }