Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1106461/?format=api
{ "id": 1106461, "url": "http://patchwork.ozlabs.org/api/patches/1106461/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190528175921.30534-5-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190528175921.30534-5-alice.michael@intel.com>", "list_archive_url": null, "date": "2019-05-28T17:59:19", "name": "[next,S6,5/7] i40e: missing priorities for any QoS traffic", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "50b71eebceb33401a95c21ce6ef74a212b88f643", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190528175921.30534-5-alice.michael@intel.com/mbox/", "series": [ { "id": 110396, "url": "http://patchwork.ozlabs.org/api/series/110396/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=110396", "date": "2019-05-28T17:59:15", "name": "[next,S6,1/7] i40e: fix 'Unknown bps' in dmesg for 2.5Gb/5Gb speeds", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/110396/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1106461/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1106461/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45D1pF3vwVz9s7h\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 29 May 2019 04:00:05 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2849387BBF;\n\tTue, 28 May 2019 18:00:04 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id GmjGGO+XxHPa; Tue, 28 May 2019 18:00:02 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id AAA3087B97;\n\tTue, 28 May 2019 18:00:02 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 40DC21BF2A1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 28 May 2019 17:59:59 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 34128214F6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 28 May 2019 17:59:59 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Y98J1+Z1-zCO for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 28 May 2019 17:59:57 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby silver.osuosl.org (Postfix) with ESMTPS id BF1CB22219\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 28 May 2019 17:59:57 +0000 (UTC)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 May 2019 10:59:56 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby orsmga008.jf.intel.com with ESMTP; 28 May 2019 10:59:56 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.micheal@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Tue, 28 May 2019 10:59:19 -0700", "Message-Id": "<20190528175921.30534-5-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20190528175921.30534-1-alice.michael@intel.com>", "References": "<20190528175921.30534-1-alice.michael@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S6 5/7] i40e: missing priorities for\n\tany QoS traffic", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n\nThis patch fixes reading f/w lldp agent status at dcb init time.\nIt's done by removing direct nvm reading in i40e_update_dcb_config()\nand checking whether f/w lldp agent is disabled via\nI40E_FLAG_DISABLE_FW_LLDP flag in i40e_init_pf_dcb(). The function\ni40e_update_dcb_config() in i40e_main.c is a temporary solution which\nwill be later renamed to i40e_init_dcb() in the i40e_dcb module. Also\nlogging was extended to make visible if f/w lldp agent is running or not\nand always log a message when dcb was not initialized. Without this\npatch for new f/w versions f/w lldp agent status was always read\nfrom nvm as disabled and dcb initialization failed without\nclear reason in logs.\n\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 57 +++++++++++++++++++--\n 1 file changed, 54 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 7c93f28b7b1d..1dd5fcf256ef 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -6411,6 +6411,50 @@ static int i40e_resume_port_tx(struct i40e_pf *pf)\n \treturn ret;\n }\n \n+/**\n+ * i40e_update_dcb_config\n+ * @hw: pointer to the hw struct\n+ * @enable_mib_change: enable mib change event\n+ *\n+ * Update DCB configuration from the Firmware\n+ **/\n+static enum i40e_status_code\n+i40e_update_dcb_config(struct i40e_hw *hw, bool enable_mib_change)\n+{\n+\tstruct i40e_lldp_variables lldp_cfg;\n+\ti40e_status ret;\n+\n+\tif (!hw->func_caps.dcb)\n+\t\treturn I40E_NOT_SUPPORTED;\n+\n+\t/* Read LLDP NVM area */\n+\tret = i40e_read_lldp_cfg(hw, &lldp_cfg);\n+\tif (ret)\n+\t\treturn I40E_ERR_NOT_READY;\n+\n+\t/* Get DCBX status */\n+\tret = i40e_get_dcbx_status(hw, &hw->dcbx_status);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\t/* Check the DCBX Status */\n+\tif (hw->dcbx_status == I40E_DCBX_STATUS_DONE ||\n+\t hw->dcbx_status == I40E_DCBX_STATUS_IN_PROGRESS) {\n+\t\t/* Get current DCBX configuration */\n+\t\tret = i40e_get_dcb_config(hw);\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\t} else if (hw->dcbx_status == I40E_DCBX_STATUS_DISABLED) {\n+\t\treturn I40E_ERR_NOT_READY;\n+\t}\n+\n+\t/* Configure the LLDP MIB change event */\n+\tif (enable_mib_change)\n+\t\tret = i40e_aq_cfg_lldp_mib_change_event(hw, true, NULL);\n+\n+\treturn ret;\n+}\n+\n /**\n * i40e_init_pf_dcb - Initialize DCB configuration\n * @pf: PF being configured\n@@ -6427,11 +6471,13 @@ static int i40e_init_pf_dcb(struct i40e_pf *pf)\n \t * Also do not enable DCBx if FW LLDP agent is disabled\n \t */\n \tif ((pf->hw_features & I40E_HW_NO_DCB_SUPPORT) ||\n-\t (pf->flags & I40E_FLAG_DISABLE_FW_LLDP))\n+\t (pf->flags & I40E_FLAG_DISABLE_FW_LLDP)) {\n+\t\tdev_info(&pf->pdev->dev, \"DCB is not supported or FW LLDP is disabled\\n\");\n+\t\terr = I40E_NOT_SUPPORTED;\n \t\tgoto out;\n+\t}\n \n-\t/* Get the initial DCB configuration */\n-\terr = i40e_init_dcb(hw, true);\n+\terr = i40e_update_dcb_config(hw, true);\n \tif (!err) {\n \t\t/* Device/Function is not DCBX capable */\n \t\tif ((!hw->func_caps.dcb) ||\n@@ -14881,6 +14927,11 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \tpci_set_drvdata(pdev, pf);\n \tpci_save_state(pdev);\n \n+\tdev_info(&pdev->dev,\n+\t\t (pf->flags & I40E_FLAG_DISABLE_FW_LLDP) ?\n+\t\t\t\"FW LLDP is disabled\\n\" :\n+\t\t\t\"FW LLDP is enabled\\n\");\n+\n \t/* Enable FW to write default DCB config on link-up */\n \ti40e_aq_set_dcb_parameters(hw, true, NULL);\n \n", "prefixes": [ "next", "S6", "5/7" ] }