Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1104543/?format=api
{ "id": 1104543, "url": "http://patchwork.ozlabs.org/api/patches/1104543/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190523234533.48418-1-lihong.yang@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190523234533.48418-1-lihong.yang@intel.com>", "list_archive_url": null, "date": "2019-05-23T23:45:33", "name": "i40e: Do not check VF state in i40e_ndo_get_vf_config", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "46c246a3ed9e0a2966588432cfb3eb333bc574eb", "submitter": { "id": 72053, "url": "http://patchwork.ozlabs.org/api/people/72053/?format=api", "name": "Lihong Yang", "email": "lihong.yang@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190523234533.48418-1-lihong.yang@intel.com/mbox/", "series": [ { "id": 109633, "url": "http://patchwork.ozlabs.org/api/series/109633/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=109633", "date": "2019-05-23T23:45:33", "name": "i40e: Do not check VF state in i40e_ndo_get_vf_config", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/109633/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1104543/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1104543/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4595fR5mVmz9s6w\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 24 May 2019 09:43:11 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id F255087E84;\n\tThu, 23 May 2019 23:43:09 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 63TKdIjO+osC; Thu, 23 May 2019 23:43:07 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 64E4987D87;\n\tThu, 23 May 2019 23:43:07 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 497871BF296\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 May 2019 23:43:06 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 426E487E98\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 May 2019 23:43:06 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id GrOOCCQ+jOqy for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 May 2019 23:43:04 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 1135487E8A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 May 2019 23:43:04 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 May 2019 16:43:02 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.154])\n\tby fmsmga002.fm.intel.com with ESMTP; 23 May 2019 16:43:02 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,505,1549958400\"; d=\"scan'208\";a=\"175948380\"", "From": "Lihong Yang <lihong.yang@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 23 May 2019 16:45:33 -0700", "Message-Id": "<20190523234533.48418-1-lihong.yang@intel.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] i40e: Do not check VF state in\n\ti40e_ndo_get_vf_config", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The VF configuration returned in i40e_ndo_get_vf_config is\nalready stored by the PF. There is no dependency on any\nspecific state of the VF to return the configuration.\nDrop the check against I40E_VF_STATE_INIT since it is not\nneeded.\n\nSigned-off-by: Lihong Yang <lihong.yang@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 4f4521d39725..38484ed6880d 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -4299,10 +4299,8 @@ int i40e_ndo_get_vf_config(struct net_device *netdev,\n \tvf = &pf->vf[vf_id];\n \t/* first vsi is always the LAN vsi */\n \tvsi = pf->vsi[vf->lan_vsi_idx];\n-\tif (!test_bit(I40E_VF_STATE_INIT, &vf->vf_states)) {\n-\t\tdev_err(&pf->pdev->dev, \"VF %d still in reset. Try again.\\n\",\n-\t\t\tvf_id);\n-\t\tret = -EAGAIN;\n+\tif (!vsi) {\n+\t\tret = -ENOENT;\n \t\tgoto error_param;\n \t}\n \n", "prefixes": [] }