Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1104448/?format=api
{ "id": 1104448, "url": "http://patchwork.ozlabs.org/api/patches/1104448/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190522232258.10353-1-dann.frazier@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190522232258.10353-1-dann.frazier@canonical.com>", "list_archive_url": null, "date": "2019-05-22T23:22:58", "name": "ixgbe: Avoid NULL pointer dereference with VF on non-IPsec hw", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "24eeee5a77273ef2aff0ac5ca3fd328b918ffaee", "submitter": { "id": 9337, "url": "http://patchwork.ozlabs.org/api/people/9337/?format=api", "name": "dann frazier", "email": "dann.frazier@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190522232258.10353-1-dann.frazier@canonical.com/mbox/", "series": [ { "id": 109605, "url": "http://patchwork.ozlabs.org/api/series/109605/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=109605", "date": "2019-05-22T23:22:58", "name": "ixgbe: Avoid NULL pointer dereference with VF on non-IPsec hw", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/109605/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1104448/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1104448/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=fail (p=none dis=none)\n\theader.from=canonical.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45927K1qMZz9s5c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 24 May 2019 07:04:28 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 83D7486CF3;\n\tThu, 23 May 2019 21:04:27 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 2EIFySgv1mOx; Thu, 23 May 2019 21:04:26 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id EE98386C47;\n\tThu, 23 May 2019 21:04:25 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 240B01BF34C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 May 2019 23:23:13 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 1FF25228DB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 May 2019 23:23:13 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id qe-8AOftSiuT for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 May 2019 23:23:12 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby silver.osuosl.org (Postfix) with ESMTPS id CFF2C227F7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 May 2019 23:23:11 +0000 (UTC)", "from mail-io1-f72.google.com ([209.85.166.72])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from <dann.frazier@canonical.com>)\n\tid 1hTaZh-0004B4-3u\n\tfor intel-wired-lan@lists.osuosl.org; Wed, 22 May 2019 23:23:09 +0000", "by mail-io1-f72.google.com with SMTP id e129so3084702iof.16\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 May 2019 16:23:09 -0700 (PDT)", "from xps13.canonical.com (c-71-56-235-36.hsd1.co.comcast.net.\n\t[71.56.235.36]) by smtp.gmail.com with ESMTPSA id\n\tc22sm8517424ioa.41.2019.05.22.16.23.06\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 22 May 2019 16:23:06 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=s85uEhKAu1jS0Q+P5fZlz+A7fx6iSmj4/T3oMaYK86c=;\n\tb=gSTvTKXqOlHwv9ibFW5YXCDTleXzymhztw5Hy4ozVC4NBPD9+avPbk4PO2qaA/ylUG\n\tvPgJWJ7DkJL17LI9RG93rFhfS4JqTUEKlQGjomgwF+NhE6HCUFedmGs6ELv4M7sM8eQ8\n\tT9MADNmIgtYMMHvfJenNHMdn0zQpJFXAHN9ztLrTdcB4P2H4NCQ3ZhxA4Hc7vBqUUKGU\n\tGr8JBnOrEYSbDcpcN5HmTZWxCuAcEHoPvkRrREwgA9RDm9nArPfIB/v735V3KcK30hWF\n\tnIUIgFf+VLyKM+gRH8H4sxLtZ3Bi+MJljK0Ei2D12N5KjmVNrKZ46hu929SZs2PSQ9gr\n\tGmhQ==", "X-Gm-Message-State": "APjAAAW6xfRGPPnkqoCyCQOTVE39NKP7yi/EMfWxUpQCb2T8PWmzzyac\n\tU2o2dvUtYcNeHk4FuwX+i40+YiBUVPzkMOgcSIxadJN78LU7hjsZIKE6YyAO7cWO9fGLVi5CNRm\n\tKkIJIUZ8OmcW5XJsVjNtwHIXnrJuQflQKrpNlaureKnsxWJI=", "X-Received": [ "by 2002:a24:1c8f:: with SMTP id\n\tc137mr11721309itc.165.1558567387394; \n\tWed, 22 May 2019 16:23:07 -0700 (PDT)", "by 2002:a24:1c8f:: with SMTP id\n\tc137mr11721292itc.165.1558567387007; \n\tWed, 22 May 2019 16:23:07 -0700 (PDT)" ], "X-Google-Smtp-Source": "APXvYqxdHnME/HIKTNtYrhxUlkHJbYT/xO74MAdU3gQ2zPhx1GksIreKy7VV6aO1robz0W5ehzpp4A==", "From": "dann frazier <dann.frazier@canonical.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tShannon Nelson <shannon.nelson@oracle.com>", "Date": "Wed, 22 May 2019 17:22:58 -0600", "Message-Id": "<20190522232258.10353-1-dann.frazier@canonical.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "X-Mailman-Approved-At": "Thu, 23 May 2019 21:04:24 +0000", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: Avoid NULL pointer dereference\n\twith VF on non-IPsec hw", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tlinux-kernel@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "An ipsec structure will not be allocated if the hardware does not support\noffload. Fixes the following Oops:\n\n[ 191.045452] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000\n[ 191.054232] Mem abort info:\n[ 191.057014] ESR = 0x96000004\n[ 191.060057] Exception class = DABT (current EL), IL = 32 bits\n[ 191.065963] SET = 0, FnV = 0\n[ 191.069004] EA = 0, S1PTW = 0\n[ 191.072132] Data abort info:\n[ 191.074999] ISV = 0, ISS = 0x00000004\n[ 191.078822] CM = 0, WnR = 0\n[ 191.081780] user pgtable: 4k pages, 48-bit VAs, pgdp = 0000000043d9e467\n[ 191.088382] [0000000000000000] pgd=0000000000000000\n[ 191.093252] Internal error: Oops: 96000004 [#1] SMP\n[ 191.098119] Modules linked in: vhost_net vhost tap vfio_pci vfio_virqfd vfio_iommu_type1 vfio xt_CHECKSUM iptable_mangle ipt_MASQUERADE iptable_nat nf_nat_ipv4 nf_nat xt_conntrack nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ipt_REJECT nf_reject_ipv4 xt_tcpudp bridge stp llc ebtable_filter devlink ebtables ip6table_filter ip6_tables iptable_filter bpfilter ipmi_ssif nls_iso8859_1 input_leds joydev ipmi_si hns_roce_hw_v2 ipmi_devintf hns_roce ipmi_msghandler cppc_cpufreq sch_fq_codel ib_iser rdma_cm iw_cm ib_cm ib_core iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi ip_tables x_tables autofs4 ses enclosure btrfs zstd_compress raid10 raid456 async_raid6_recov async_memcpy async_pq async_xor async_tx xor hid_generic usbhid hid raid6_pq libcrc32c raid1 raid0 multipath linear ixgbevf hibmc_drm ttm\n[ 191.168607] drm_kms_helper aes_ce_blk aes_ce_cipher syscopyarea crct10dif_ce sysfillrect ghash_ce qla2xxx sysimgblt sha2_ce sha256_arm64 hisi_sas_v3_hw fb_sys_fops sha1_ce uas nvme_fc mpt3sas ixgbe drm hisi_sas_main nvme_fabrics usb_storage hclge scsi_transport_fc ahci libsas hnae3 raid_class libahci xfrm_algo scsi_transport_sas mdio aes_neon_bs aes_neon_blk crypto_simd cryptd aes_arm64\n[ 191.202952] CPU: 94 PID: 0 Comm: swapper/94 Not tainted 4.19.0-rc1+ #11\n[ 191.209553] Hardware name: Huawei D06 /D06, BIOS Hisilicon D06 UEFI RC0 - V1.20.01 04/26/2019\n[ 191.218064] pstate: 20400089 (nzCv daIf +PAN -UAO)\n[ 191.222873] pc : ixgbe_ipsec_vf_clear+0x60/0xd0 [ixgbe]\n[ 191.228093] lr : ixgbe_msg_task+0x2d0/0x1088 [ixgbe]\n[ 191.233044] sp : ffff000009b3bcd0\n[ 191.236346] x29: ffff000009b3bcd0 x28: 0000000000000000\n[ 191.241647] x27: ffff000009628000 x26: 0000000000000000\n[ 191.246946] x25: ffff803f652d7600 x24: 0000000000000004\n[ 191.252246] x23: ffff803f6a718900 x22: 0000000000000000\n[ 191.257546] x21: 0000000000000000 x20: 0000000000000000\n[ 191.262845] x19: 0000000000000000 x18: 0000000000000000\n[ 191.268144] x17: 0000000000000000 x16: 0000000000000000\n[ 191.273443] x15: 0000000000000000 x14: 0000000100000026\n[ 191.278742] x13: 0000000100000025 x12: ffff8a5f7fbe0df0\n[ 191.284042] x11: 000000010000000b x10: 0000000000000040\n[ 191.289341] x9 : 0000000000001100 x8 : ffff803f6a824fd8\n[ 191.294640] x7 : ffff803f6a825098 x6 : 0000000000000001\n[ 191.299939] x5 : ffff000000f0ffc0 x4 : 0000000000000000\n[ 191.305238] x3 : ffff000028c00000 x2 : ffff803f652d7600\n[ 191.310538] x1 : 0000000000000000 x0 : ffff000000f205f0\n[ 191.315838] Process swapper/94 (pid: 0, stack limit = 0x00000000addfed5a)\n[ 191.322613] Call trace:\n[ 191.325055] ixgbe_ipsec_vf_clear+0x60/0xd0 [ixgbe]\n[ 191.329927] ixgbe_msg_task+0x2d0/0x1088 [ixgbe]\n[ 191.334536] ixgbe_msix_other+0x274/0x330 [ixgbe]\n[ 191.339233] __handle_irq_event_percpu+0x78/0x270\n[ 191.343924] handle_irq_event_percpu+0x40/0x98\n[ 191.348355] handle_irq_event+0x50/0xa8\n[ 191.352180] handle_fasteoi_irq+0xbc/0x148\n[ 191.356263] generic_handle_irq+0x34/0x50\n[ 191.360259] __handle_domain_irq+0x68/0xc0\n[ 191.364343] gic_handle_irq+0x84/0x180\n[ 191.368079] el1_irq+0xe8/0x180\n[ 191.371208] arch_cpu_idle+0x30/0x1a8\n[ 191.374860] do_idle+0x1dc/0x2a0\n[ 191.378077] cpu_startup_entry+0x2c/0x30\n[ 191.381988] secondary_start_kernel+0x150/0x1e0\n[ 191.386506] Code: 6b15003f 54000320 f1404a9f 54000060 (79400260)\n\nFixes: eda0333ac2930 (\"ixgbe: add VF IPsec management\")\nSigned-off-by: dann frazier <dann.frazier@canonical.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\nindex ff85ce5791a36..31629fc7e820f 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c\n@@ -842,6 +842,9 @@ void ixgbe_ipsec_vf_clear(struct ixgbe_adapter *adapter, u32 vf)\n \tstruct ixgbe_ipsec *ipsec = adapter->ipsec;\n \tint i;\n \n+\tif (!ipsec)\n+\t\treturn;\n+\n \t/* search rx sa table */\n \tfor (i = 0; i < IXGBE_IPSEC_MAX_SA_COUNT && ipsec->num_rx_sa; i++) {\n \t\tif (!ipsec->rx_tbl[i].used)\n", "prefixes": [] }