Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1104360/?format=api
{ "id": 1104360, "url": "http://patchwork.ozlabs.org/api/patches/1104360/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190523191112.14572-1-maurosr@linux.vnet.ibm.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190523191112.14572-1-maurosr@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2019-05-23T19:11:12", "name": "ixgbe: Check DDM existence in transceiver before access", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9e9db5f52c36447992e6d507dedd4ac0ae6a0ed5", "submitter": { "id": 71608, "url": "http://patchwork.ozlabs.org/api/people/71608/?format=api", "name": "Mauro S. M. Rodrigues", "email": "maurosr@linux.vnet.ibm.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190523191112.14572-1-maurosr@linux.vnet.ibm.com/mbox/", "series": [ { "id": 109570, "url": "http://patchwork.ozlabs.org/api/series/109570/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=109570", "date": "2019-05-23T19:11:12", "name": "ixgbe: Check DDM existence in transceiver before access", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/109570/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1104360/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1104360/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=linux.vnet.ibm.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 458zdw1f3zz9sMr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 24 May 2019 05:12:19 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 85AA4318B6;\n\tThu, 23 May 2019 19:12:16 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YKj1erhze7h7; Thu, 23 May 2019 19:12:15 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4A5EF30F1B;\n\tThu, 23 May 2019 19:12:15 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id E4B361BF400\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 May 2019 19:12:13 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D9ADB30F1B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 May 2019 19:12:13 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id SghpvkUzZwyi for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 May 2019 19:12:12 +0000 (UTC)", "from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\tby silver.osuosl.org (Postfix) with ESMTPS id D967820794\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 May 2019 19:12:11 +0000 (UTC)", "from pps.filterd (m0098419.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx4NJ74eM138332 for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 May 2019 15:12:10 -0400", "from e36.co.us.ibm.com (e36.co.us.ibm.com [32.97.110.154])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2sp1bwra9w-1\n\t(version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT)\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 May 2019 15:12:10 -0400", "from localhost\n\tby e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <intel-wired-lan@lists.osuosl.org> from\n\t<maurosr@linux.vnet.ibm.com>; Thu, 23 May 2019 20:12:09 +0100", "from b03cxnp07028.gho.boulder.ibm.com (9.17.130.15)\n\tby e36.co.us.ibm.com (192.168.1.136) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\t(version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256)\n\tThu, 23 May 2019 20:12:07 +0100", "from b03ledav006.gho.boulder.ibm.com\n\t(b03ledav006.gho.boulder.ibm.com [9.17.130.237])\n\tby b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id x4NJC6Ug17170546\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 23 May 2019 19:12:07 GMT", "from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id DB584C6057;\n\tThu, 23 May 2019 19:12:06 +0000 (GMT)", "from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id A0352C6055;\n\tThu, 23 May 2019 19:12:06 +0000 (GMT)", "from localhost (unknown [9.18.239.156])\n\tby b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP;\n\tThu, 23 May 2019 19:12:06 +0000 (GMT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "\"Mauro S. M. Rodrigues\" <maurosr@linux.vnet.ibm.com>", "To": "intel-wired-lan@lists.osuosl.org,\n\tJeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Thu, 23 May 2019 16:11:12 -0300", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "X-TM-AS-GCONF": "00", "x-cbid": "19052319-0020-0000-0000-00000EEF5347", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00011150; HX=3.00000242; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000286; SDB=6.01207570; UDB=6.00634196;\n\tIPR=6.00988551; \n\tMB=3.00027021; MTD=3.00000008; XFM=3.00000015; UTC=2019-05-23 19:12:09", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "19052319-0021-0000-0000-000065F1083A", "Message-Id": "<20190523191112.14572-1-maurosr@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-05-23_16:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tpriorityscore=1501\n\tmalwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0\n\tclxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0\n\tmlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx\n\tscancount=1 engine=8.0.1-1810050000 definitions=main-1905230126", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: Check DDM existence in transceiver\n\tbefore access", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "gromero@linux.vnet.ibm.com", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Some transceivers may comply with SFF-8472 but not implement the Digital\nDiagnostic Monitoring (DDM) interface described in it. The existence of\nsuch area is specified by bit 6 of byte 92, set to 1 if implemented.\n\nCurrently, due to not checking this bit ixgbe fails trying to read sfp\nmodule's eeprom with the follow message:\n\nethtool -m enP51p1s0f0\nCannot get Module EEPROM data: Input/output error\n\nBecause it fails to read the additional 256 bytes in which it was assumed\nto exist the DDM data.\n\nThis issue was noticed using a Mellanox Passive DAC PN 01FT738. The eeprom\ndata was confirmed by Mellanox as correct and present in other Passive\nDACs in from other manufacturers.\n\nSigned-off-by: Mauro S. M. Rodrigues <maurosr@linux.vnet.ibm.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 3 ++-\n drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h | 1 +\n 2 files changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\nindex acba067cc15a..7c52ae8ac005 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n@@ -3226,7 +3226,8 @@ static int ixgbe_get_module_info(struct net_device *dev,\n \t\tpage_swap = true;\n \t}\n \n-\tif (sff8472_rev == IXGBE_SFF_SFF_8472_UNSUP || page_swap) {\n+\tif (sff8472_rev == IXGBE_SFF_SFF_8472_UNSUP || page_swap ||\n+\t !(addr_mode & IXGBE_SFF_DDM_IMPLEMENTED)) {\n \t\t/* We have a SFP, but it does not support SFF-8472 */\n \t\tmodinfo->type = ETH_MODULE_SFF_8079;\n \t\tmodinfo->eeprom_len = ETH_MODULE_SFF_8079_LEN;\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h\nindex 214b01085718..693c615017cc 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h\n@@ -45,6 +45,7 @@\n #define IXGBE_SFF_SOFT_RS_SELECT_10G\t\t0x8\n #define IXGBE_SFF_SOFT_RS_SELECT_1G\t\t0x0\n #define IXGBE_SFF_ADDRESSING_MODE\t\t0x4\n+#define IXGBE_SFF_DDM_IMPLEMENTED 0x40\n #define IXGBE_SFF_QSFP_DA_ACTIVE_CABLE\t\t0x1\n #define IXGBE_SFF_QSFP_DA_PASSIVE_CABLE\t\t0x8\n #define IXGBE_SFF_QSFP_CONNECTOR_NOT_SEPARABLE\t0x23\n", "prefixes": [] }