Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/110145/?format=api
{ "id": 110145, "url": "http://patchwork.ozlabs.org/api/patches/110145/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/1313463105-4100-1-git-send-email-agnel.joel@gmail.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1313463105-4100-1-git-send-email-agnel.joel@gmail.com>", "list_archive_url": null, "date": "2011-08-16T02:51:45", "name": "[U-Boot] led: remove camel casing of led identifiers globally", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7d6917a4d3a97f44446ef879af0d788e2cce9248", "submitter": { "id": 8387, "url": "http://patchwork.ozlabs.org/api/people/8387/?format=api", "name": "Joel Fernandes", "email": "agnel.joel@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/1313463105-4100-1-git-send-email-agnel.joel@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/110145/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/110145/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Received": [ "from theia.denx.de (theia.denx.de [85.214.87.163])\n\tby ozlabs.org (Postfix) with ESMTP id 90962B6F77\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 16 Aug 2011 12:52:24 +1000 (EST)", "from localhost (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id DBEAE280A7;\n\tTue, 16 Aug 2011 04:52:22 +0200 (CEST)", "from theia.denx.de ([127.0.0.1])\n\tby localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ckS9EZ5tWzdE; Tue, 16 Aug 2011 04:52:22 +0200 (CEST)", "from theia.denx.de (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id E8F99280FA;\n\tTue, 16 Aug 2011 04:52:20 +0200 (CEST)", "from localhost (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id 8A10D280FA\n\tfor <u-boot@lists.denx.de>; Tue, 16 Aug 2011 04:52:19 +0200 (CEST)", "from theia.denx.de ([127.0.0.1])\n\tby localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id iNg65VOeUJ8A for <u-boot@lists.denx.de>;\n\tTue, 16 Aug 2011 04:52:18 +0200 (CEST)", "from mail-gy0-f172.google.com (mail-gy0-f172.google.com\n\t[209.85.160.172])\n\tby theia.denx.de (Postfix) with ESMTPS id B6E05280A7\n\tfor <u-boot@lists.denx.de>; Tue, 16 Aug 2011 04:52:16 +0200 (CEST)", "by gyf3 with SMTP id 3so3323746gyf.3\n\tfor <u-boot@lists.denx.de>; Mon, 15 Aug 2011 19:52:15 -0700 (PDT)", "by 10.101.175.9 with SMTP id c9mr4499220anp.111.1313463134998;\n\tMon, 15 Aug 2011 19:52:14 -0700 (PDT)", "from localhost.localdomain\n\t(ip65-46-142-190.z142-46-65.customer.algx.net [65.46.142.190])\n\tby mx.google.com with ESMTPS id\n\tl38sm5698363ani.44.2011.08.15.19.52.06\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tMon, 15 Aug 2011 19:52:14 -0700 (PDT)" ], "X-Virus-Scanned": [ "Debian amavisd-new at theia.denx.de", "Debian amavisd-new at theia.denx.de" ], "X-policyd-weight": "NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5\n\tNOT_IN_BL_NJABL=-1.5 (only DNSBL check requested)", "From": "Joel A Fernandes <agnel.joel@gmail.com>", "To": "u-boot@lists.denx.de", "Date": "Mon, 15 Aug 2011 21:51:45 -0500", "Message-Id": "<1313463105-4100-1-git-send-email-agnel.joel@gmail.com>", "X-Mailer": "git-send-email 1.7.1", "Cc": "Syed Mohammed Khasim <khasim@ti.com>, k-kooi@ti.com, jdk@ti.com", "Subject": "[U-Boot] [PATCH] led: remove camel casing of led identifiers\n\tglobally", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.9", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<http://lists.denx.de/mailman/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<http://lists.denx.de/mailman/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "u-boot-bounces@lists.denx.de", "Errors-To": "u-boot-bounces@lists.denx.de" }, "content": "From: Jason Kridner <jkridner@beagleboard.org>\n\nResult of running the following command to address Wolfgang's\ncomment about camel case:\n\nfor file in `find . | grep '\\.[ch]$'`; do perl -i -pe\n's/(green|yellow|red|blue)_LED_(on|off)/$1_led_$2/g' $file; done\n\nDiscussion:\nhttp://patchwork.ozlabs.org/patch/84988/\n\nSigned-off-by: Jason Kridner <jkridner@beagleboard.org>\nSigned-off-by: Joel A Fernandes <agnel.joel@gmail.com>\n---\n arch/arm/cpu/arm920t/ep93xx/led.c | 24 +++++++++---------\n arch/arm/cpu/arm926ejs/at91/led.c | 12 ++++----\n arch/arm/lib/board.c | 32 ++++++++++++------------\n board/atmel/at91rm9200dk/led.c | 12 ++++----\n board/atmel/at91rm9200ek/led.c | 12 ++++----\n board/eukrea/cpu9260/led.c | 48 ++++++++++++++++++------------------\n board/logicpd/zoom2/led.c | 28 ++++++++++----------\n board/ti/beagle/led.c | 4 +-\n common/cmd_led.c | 8 +++---\n include/status_led.h | 32 ++++++++++++------------\n 10 files changed, 106 insertions(+), 106 deletions(-)", "diff": "diff --git a/arch/arm/cpu/arm920t/ep93xx/led.c b/arch/arm/cpu/arm920t/ep93xx/led.c\nindex 7e2c897..0aefa7f 100644\n--- a/arch/arm/cpu/arm920t/ep93xx/led.c\n+++ b/arch/arm/cpu/arm920t/ep93xx/led.c\n@@ -45,22 +45,22 @@ inline void switch_LED_off(uint8_t led)\n \tsaved_state[led] = STATUS_LED_OFF;\n }\n \n-void red_LED_on(void)\n+void red_led_on(void)\n {\n \tswitch_LED_on(STATUS_LED_RED);\n }\n \n-void red_LED_off(void)\n+void red_led_off(void)\n {\n \tswitch_LED_off(STATUS_LED_RED);\n }\n \n-void green_LED_on(void)\n+void green_led_on(void)\n {\n \tswitch_LED_on(STATUS_LED_GREEN);\n }\n \n-void green_LED_off(void)\n+void green_led_off(void)\n {\n \tswitch_LED_off(STATUS_LED_GREEN);\n }\n@@ -74,14 +74,14 @@ void __led_toggle(led_id_t mask)\n {\n \tif (STATUS_LED_RED == mask) {\n \t\tif (STATUS_LED_ON == saved_state[STATUS_LED_RED])\n-\t\t\tred_LED_off();\n+\t\t\tred_led_off();\n \t\telse\n-\t\t\tred_LED_on();\n+\t\t\tred_led_on();\n \t} else if (STATUS_LED_GREEN == mask) {\n \t\tif (STATUS_LED_ON == saved_state[STATUS_LED_GREEN])\n-\t\t\tgreen_LED_off();\n+\t\t\tgreen_led_off();\n \t\telse\n-\t\t\tgreen_LED_on();\n+\t\t\tgreen_led_on();\n \t}\n }\n \n@@ -89,13 +89,13 @@ void __led_set(led_id_t mask, int state)\n {\n \tif (STATUS_LED_RED == mask) {\n \t\tif (STATUS_LED_ON == state)\n-\t\t\tred_LED_on();\n+\t\t\tred_led_on();\n \t\telse\n-\t\t\tred_LED_off();\n+\t\t\tred_led_off();\n \t} else if (STATUS_LED_GREEN == mask) {\n \t\tif (STATUS_LED_ON == state)\n-\t\t\tgreen_LED_on();\n+\t\t\tgreen_led_on();\n \t\telse\n-\t\t\tgreen_LED_off();\n+\t\t\tgreen_led_off();\n \t}\n }\ndiff --git a/arch/arm/cpu/arm926ejs/at91/led.c b/arch/arm/cpu/arm926ejs/at91/led.c\nindex 6bcfa7f..6e59c86 100644\n--- a/arch/arm/cpu/arm926ejs/at91/led.c\n+++ b/arch/arm/cpu/arm926ejs/at91/led.c\n@@ -29,36 +29,36 @@\n #include <asm/arch/gpio.h>\n \n #ifdef CONFIG_RED_LED\n-void red_LED_on(void)\n+void red_led_on(void)\n {\n \tat91_set_gpio_value(CONFIG_RED_LED, 1);\n }\n \n-void red_LED_off(void)\n+void red_led_off(void)\n {\n \tat91_set_gpio_value(CONFIG_RED_LED, 0);\n }\n #endif\n \n #ifdef CONFIG_GREEN_LED\n-void green_LED_on(void)\n+void green_led_on(void)\n {\n \tat91_set_gpio_value(CONFIG_GREEN_LED, 0);\n }\n \n-void green_LED_off(void)\n+void green_led_off(void)\n {\n \tat91_set_gpio_value(CONFIG_GREEN_LED, 1);\n }\n #endif\n \n #ifdef CONFIG_YELLOW_LED\n-void yellow_LED_on(void)\n+void yellow_led_on(void)\n {\n \tat91_set_gpio_value(CONFIG_YELLOW_LED, 0);\n }\n \n-void yellow_LED_off(void)\n+void yellow_led_off(void)\n {\n \tat91_set_gpio_value(CONFIG_YELLOW_LED, 1);\n }\ndiff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c\nindex 169dfeb..9649035 100644\n--- a/arch/arm/lib/board.c\n+++ b/arch/arm/lib/board.c\n@@ -94,22 +94,22 @@ extern void rtl8019_get_enetaddr (uchar * addr);\n */\n void inline __coloured_LED_init (void) {}\n void coloured_LED_init (void) __attribute__((weak, alias(\"__coloured_LED_init\")));\n-void inline __red_LED_on (void) {}\n-void red_LED_on (void) __attribute__((weak, alias(\"__red_LED_on\")));\n-void inline __red_LED_off(void) {}\n-void red_LED_off(void) __attribute__((weak, alias(\"__red_LED_off\")));\n-void inline __green_LED_on(void) {}\n-void green_LED_on(void) __attribute__((weak, alias(\"__green_LED_on\")));\n-void inline __green_LED_off(void) {}\n-void green_LED_off(void) __attribute__((weak, alias(\"__green_LED_off\")));\n-void inline __yellow_LED_on(void) {}\n-void yellow_LED_on(void) __attribute__((weak, alias(\"__yellow_LED_on\")));\n-void inline __yellow_LED_off(void) {}\n-void yellow_LED_off(void) __attribute__((weak, alias(\"__yellow_LED_off\")));\n-void inline __blue_LED_on(void) {}\n-void blue_LED_on(void) __attribute__((weak, alias(\"__blue_LED_on\")));\n-void inline __blue_LED_off(void) {}\n-void blue_LED_off(void) __attribute__((weak, alias(\"__blue_LED_off\")));\n+void inline __red_led_on (void) {}\n+void red_led_on (void) __attribute__((weak, alias(\"__red_led_on\")));\n+void inline __red_led_off(void) {}\n+void red_led_off(void) __attribute__((weak, alias(\"__red_led_off\")));\n+void inline __green_led_on(void) {}\n+void green_led_on(void) __attribute__((weak, alias(\"__green_led_on\")));\n+void inline __green_led_off(void) {}\n+void green_led_off(void) __attribute__((weak, alias(\"__green_led_off\")));\n+void inline __yellow_led_on(void) {}\n+void yellow_led_on(void) __attribute__((weak, alias(\"__yellow_led_on\")));\n+void inline __yellow_led_off(void) {}\n+void yellow_led_off(void) __attribute__((weak, alias(\"__yellow_led_off\")));\n+void inline __blue_led_on(void) {}\n+void blue_led_on(void) __attribute__((weak, alias(\"__blue_led_on\")));\n+void inline __blue_led_off(void) {}\n+void blue_led_off(void) __attribute__((weak, alias(\"__blue_led_off\")));\n \n /************************************************************************\n * Init Utilities\t\t\t\t\t\t\t*\ndiff --git a/board/atmel/at91rm9200dk/led.c b/board/atmel/at91rm9200dk/led.c\nindex 47a3bfc..ee64278 100644\n--- a/board/atmel/at91rm9200dk/led.c\n+++ b/board/atmel/at91rm9200dk/led.c\n@@ -29,37 +29,37 @@\n #define\tYELLOW_LED\tAT91C_PIO_PB1\n #define\tRED_LED\tAT91C_PIO_PB2\n \n-void\tgreen_LED_on(void)\n+void\tgreen_led_on(void)\n {\n \tAT91PS_PIO\tPIOB\t= AT91C_BASE_PIOB;\n \tPIOB->PIO_CODR\t\t= GREEN_LED;\n }\n \n-void\t yellow_LED_on(void)\n+void\t yellow_led_on(void)\n {\n \tAT91PS_PIO\tPIOB\t= AT91C_BASE_PIOB;\n \tPIOB->PIO_CODR\t\t= YELLOW_LED;\n }\n \n-void\t red_LED_on(void)\n+void\t red_led_on(void)\n {\n \tAT91PS_PIO\tPIOB\t= AT91C_BASE_PIOB;\n \tPIOB->PIO_CODR\t\t= RED_LED;\n }\n \n-void\tgreen_LED_off(void)\n+void\tgreen_led_off(void)\n {\n \tAT91PS_PIO\tPIOB\t= AT91C_BASE_PIOB;\n \tPIOB->PIO_SODR\t\t= GREEN_LED;\n }\n \n-void\tyellow_LED_off(void)\n+void\tyellow_led_off(void)\n {\n \tAT91PS_PIO\tPIOB\t= AT91C_BASE_PIOB;\n \tPIOB->PIO_SODR\t\t= YELLOW_LED;\n }\n \n-void\tred_LED_off(void)\n+void\tred_led_off(void)\n {\n \tAT91PS_PIO\tPIOB\t= AT91C_BASE_PIOB;\n \tPIOB->PIO_SODR\t\t= RED_LED;\ndiff --git a/board/atmel/at91rm9200ek/led.c b/board/atmel/at91rm9200ek/led.c\nindex 1766ddf..facba24 100644\n--- a/board/atmel/at91rm9200ek/led.c\n+++ b/board/atmel/at91rm9200ek/led.c\n@@ -36,37 +36,37 @@\n #define\tYELLOW_LED\t(1<<1)\n #define\tRED_LED\t\t(1<<2)\n \n-void\tgreen_LED_on(void)\n+void\tgreen_led_on(void)\n {\n \tat91_pio_t *pio = (at91_pio_t *)ATMEL_BASE_PIO;\n \twritel(GREEN_LED, &pio->piob.codr);\n }\n \n-void\t yellow_LED_on(void)\n+void\t yellow_led_on(void)\n {\n \tat91_pio_t *pio = (at91_pio_t *)ATMEL_BASE_PIO;\n \twritel(YELLOW_LED, &pio->piob.codr);\n }\n \n-void\t red_LED_on(void)\n+void\t red_led_on(void)\n {\n \tat91_pio_t *pio = (at91_pio_t *)ATMEL_BASE_PIO;\n \twritel(RED_LED, &pio->piob.codr);\n }\n \n-void\tgreen_LED_off(void)\n+void\tgreen_led_off(void)\n {\n \tat91_pio_t *pio = (at91_pio_t *)ATMEL_BASE_PIO;\n \twritel(GREEN_LED, &pio->piob.sodr);\n }\n \n-void\tyellow_LED_off(void)\n+void\tyellow_led_off(void)\n {\n \tat91_pio_t *pio = (at91_pio_t *)ATMEL_BASE_PIO;\n \twritel(YELLOW_LED, &pio->piob.sodr);\n }\n \n-void\tred_LED_off(void)\n+void\tred_led_off(void)\n {\n \tat91_pio_t *pio = (at91_pio_t *)ATMEL_BASE_PIO;\n \twritel(RED_LED, &pio->piob.sodr);\ndiff --git a/board/eukrea/cpu9260/led.c b/board/eukrea/cpu9260/led.c\nindex 8d865eb..434cffb 100644\n--- a/board/eukrea/cpu9260/led.c\n+++ b/board/eukrea/cpu9260/led.c\n@@ -51,49 +51,49 @@ void coloured_LED_init(void)\n \tat91_set_pio_value(CONFIG_BLUE_LED, 1);\n }\n \n-void red_LED_off(void)\n+void red_led_off(void)\n {\n \tat91_set_pio_value(CONFIG_RED_LED, 1);\n \tsaved_state[STATUS_LED_RED] = STATUS_LED_OFF;\n }\n \n-void green_LED_off(void)\n+void green_led_off(void)\n {\n \tat91_set_pio_value(CONFIG_GREEN_LED, 1);\n \tsaved_state[STATUS_LED_GREEN] = STATUS_LED_OFF;\n }\n \n-void yellow_LED_off(void)\n+void yellow_led_off(void)\n {\n \tat91_set_pio_value(CONFIG_YELLOW_LED, 1);\n \tsaved_state[STATUS_LED_YELLOW] = STATUS_LED_OFF;\n }\n \n-void blue_LED_off(void)\n+void blue_led_off(void)\n {\n \tat91_set_pio_value(CONFIG_BLUE_LED, 1);\n \tsaved_state[STATUS_LED_BLUE] = STATUS_LED_OFF;\n }\n \n-void red_LED_on(void)\n+void red_led_on(void)\n {\n \tat91_set_pio_value(CONFIG_RED_LED, 0);\n \tsaved_state[STATUS_LED_RED] = STATUS_LED_ON;\n }\n \n-void green_LED_on(void)\n+void green_led_on(void)\n {\n \tat91_set_pio_value(CONFIG_GREEN_LED, 0);\n \tsaved_state[STATUS_LED_GREEN] = STATUS_LED_ON;\n }\n \n-void yellow_LED_on(void)\n+void yellow_led_on(void)\n {\n \tat91_set_pio_value(CONFIG_YELLOW_LED, 0);\n \tsaved_state[STATUS_LED_YELLOW] = STATUS_LED_ON;\n }\n \n-void blue_LED_on(void)\n+void blue_led_on(void)\n {\n \tat91_set_pio_value(CONFIG_BLUE_LED, 0);\n \tsaved_state[STATUS_LED_BLUE] = STATUS_LED_ON;\n@@ -108,24 +108,24 @@ void __led_toggle(led_id_t mask)\n {\n \tif (STATUS_LED_BLUE == mask) {\n \t\tif (STATUS_LED_ON == saved_state[STATUS_LED_BLUE])\n-\t\t\tblue_LED_off();\n+\t\t\tblue_led_off();\n \t\telse\n-\t\t\tblue_LED_on();\n+\t\t\tblue_led_on();\n \t} else if (STATUS_LED_RED == mask) {\n \t\tif (STATUS_LED_ON == saved_state[STATUS_LED_RED])\n-\t\t\tred_LED_off();\n+\t\t\tred_led_off();\n \t\telse\n-\t\t\tred_LED_on();\n+\t\t\tred_led_on();\n \t} else if (STATUS_LED_GREEN == mask) {\n \t\tif (STATUS_LED_ON == saved_state[STATUS_LED_GREEN])\n-\t\t\tgreen_LED_off();\n+\t\t\tgreen_led_off();\n \t\telse\n-\t\t\tgreen_LED_on();\n+\t\t\tgreen_led_on();\n \t} else if (STATUS_LED_YELLOW == mask) {\n \t\tif (STATUS_LED_ON == saved_state[STATUS_LED_YELLOW])\n-\t\t\tyellow_LED_off();\n+\t\t\tyellow_led_off();\n \t\telse\n-\t\t\tyellow_LED_on();\n+\t\t\tyellow_led_on();\n \t}\n }\n \n@@ -133,23 +133,23 @@ void __led_set(led_id_t mask, int state)\n {\n \tif (STATUS_LED_BLUE == mask) {\n \t\tif (STATUS_LED_ON == state)\n-\t\t\tblue_LED_on();\n+\t\t\tblue_led_on();\n \t\telse\n-\t\t\tblue_LED_off();\n+\t\t\tblue_led_off();\n \t} else if (STATUS_LED_RED == mask) {\n \t\tif (STATUS_LED_ON == state)\n-\t\t\tred_LED_on();\n+\t\t\tred_led_on();\n \t\telse\n-\t\t\tred_LED_off();\n+\t\t\tred_led_off();\n \t} else if (STATUS_LED_GREEN == mask) {\n \t\tif (STATUS_LED_ON == state)\n-\t\t\tgreen_LED_on();\n+\t\t\tgreen_led_on();\n \t\telse\n-\t\t\tgreen_LED_off();\n+\t\t\tgreen_led_off();\n \t} else if (STATUS_LED_YELLOW == mask) {\n \t\tif (STATUS_LED_ON == state)\n-\t\t\tyellow_LED_on();\n+\t\t\tyellow_led_on();\n \t\telse\n-\t\t\tyellow_LED_off();\n+\t\t\tyellow_led_off();\n \t}\n }\ndiff --git a/board/logicpd/zoom2/led.c b/board/logicpd/zoom2/led.c\nindex 4e14c58..d4724a8 100644\n--- a/board/logicpd/zoom2/led.c\n+++ b/board/logicpd/zoom2/led.c\n@@ -36,7 +36,7 @@ static unsigned int saved_state[2] = {STATUS_LED_OFF, STATUS_LED_OFF};\n #define ZOOM2_LED_BLUE\t154\n #define ZOOM2_LED_BLUE2\t61\n \n-void red_LED_off (void)\n+void red_led_off (void)\n {\n \t/* red */\n \tif (!omap_request_gpio(ZOOM2_LED_RED)) {\n@@ -46,7 +46,7 @@ void red_LED_off (void)\n \tsaved_state[STATUS_LED_RED] = STATUS_LED_OFF;\n }\n \n-void blue_LED_off (void)\n+void blue_led_off (void)\n {\n \t/* blue */\n \tif (!omap_request_gpio(ZOOM2_LED_BLUE)) {\n@@ -62,9 +62,9 @@ void blue_LED_off (void)\n \tsaved_state[STATUS_LED_BLUE] = STATUS_LED_OFF;\n }\n \n-void red_LED_on (void)\n+void red_led_on (void)\n {\n-\tblue_LED_off ();\n+\tblue_led_off ();\n \n \t/* red */\n \tif (!omap_request_gpio(ZOOM2_LED_RED)) {\n@@ -74,9 +74,9 @@ void red_LED_on (void)\n \tsaved_state[STATUS_LED_RED] = STATUS_LED_ON;\n }\n \n-void blue_LED_on (void)\n+void blue_led_on (void)\n {\n-\tred_LED_off ();\n+\tred_led_off ();\n \n \t/* blue */\n \tif (!omap_request_gpio(ZOOM2_LED_BLUE)) {\n@@ -102,14 +102,14 @@ void __led_toggle (led_id_t mask)\n {\n \tif (STATUS_LED_BLUE == mask) {\n \t\tif (STATUS_LED_ON == saved_state[STATUS_LED_BLUE])\n-\t\t\tblue_LED_off ();\n+\t\t\tblue_led_off ();\n \t\telse\n-\t\t\tblue_LED_on ();\n+\t\t\tblue_led_on ();\n \t} else if (STATUS_LED_RED == mask) {\n \t\tif (STATUS_LED_ON == saved_state[STATUS_LED_RED])\n-\t\t\tred_LED_off ();\n+\t\t\tred_led_off ();\n \t\telse\n-\t\t\tred_LED_on ();\n+\t\t\tred_led_on ();\n \t}\n }\n \n@@ -117,13 +117,13 @@ void __led_set (led_id_t mask, int state)\n {\n \tif (STATUS_LED_BLUE == mask) {\n \t\tif (STATUS_LED_ON == state)\n-\t\t\tblue_LED_on ();\n+\t\t\tblue_led_on ();\n \t\telse\n-\t\t\tblue_LED_off ();\n+\t\t\tblue_led_off ();\n \t} else if (STATUS_LED_RED == mask) {\n \t\tif (STATUS_LED_ON == state)\n-\t\t\tred_LED_on ();\n+\t\t\tred_led_on ();\n \t\telse\n-\t\t\tred_LED_off ();\n+\t\t\tred_led_off ();\n \t}\n }\ndiff --git a/board/ti/beagle/led.c b/board/ti/beagle/led.c\nindex 9e65932..0fb85a1 100644\n--- a/board/ti/beagle/led.c\n+++ b/board/ti/beagle/led.c\n@@ -29,12 +29,12 @@\n #define BEAGLE_LED_USR1\t149\n \n #ifdef STATUS_LED_GREEN\n-void green_LED_off (void)\n+void green_led_off (void)\n {\n \t__led_set (STATUS_LED_GREEN, 0);\n }\n \n-void green_LED_on (void)\n+void green_led_on (void)\n {\n \t__led_set (STATUS_LED_GREEN, 1);\n }\ndiff --git a/common/cmd_led.c b/common/cmd_led.c\nindex b81ae05..8a02319 100644\n--- a/common/cmd_led.c\n+++ b/common/cmd_led.c\n@@ -57,16 +57,16 @@ static const led_tbl_t led_commands[] = {\n #endif\n #endif\n #ifdef STATUS_LED_GREEN\n-\t{ \"green\", STATUS_LED_GREEN, green_LED_off, green_LED_on, NULL },\n+\t{ \"green\", STATUS_LED_GREEN, green_led_off, green_led_on, NULL },\n #endif\n #ifdef STATUS_LED_YELLOW\n-\t{ \"yellow\", STATUS_LED_YELLOW, yellow_LED_off, yellow_LED_on, NULL },\n+\t{ \"yellow\", STATUS_LED_YELLOW, yellow_led_off, yellow_led_on, NULL },\n #endif\n #ifdef STATUS_LED_RED\n-\t{ \"red\", STATUS_LED_RED, red_LED_off, red_LED_on, NULL },\n+\t{ \"red\", STATUS_LED_RED, red_led_off, red_led_on, NULL },\n #endif\n #ifdef STATUS_LED_BLUE\n-\t{ \"blue\", STATUS_LED_BLUE, blue_LED_off, blue_LED_on, NULL },\n+\t{ \"blue\", STATUS_LED_BLUE, blue_led_off, blue_led_on, NULL },\n #endif\n \t{ NULL, 0, NULL, NULL, NULL }\n };\ndiff --git a/include/status_led.h b/include/status_led.h\nindex 360195c..5914329 100644\n--- a/include/status_led.h\n+++ b/include/status_led.h\n@@ -357,24 +357,24 @@ extern void __led_set (led_id_t mask, int state);\n */\n #ifndef\t__ASSEMBLY__\n extern void\tcoloured_LED_init (void);\n-extern void\tred_LED_on(void);\n-extern void\tred_LED_off(void);\n-extern void\tgreen_LED_on(void);\n-extern void\tgreen_LED_off(void);\n-extern void\tyellow_LED_on(void);\n-extern void\tyellow_LED_off(void);\n-extern void\tblue_LED_on(void);\n-extern void\tblue_LED_off(void);\n+extern void\tred_led_on(void);\n+extern void\tred_led_off(void);\n+extern void\tgreen_led_on(void);\n+extern void\tgreen_led_off(void);\n+extern void\tyellow_led_on(void);\n+extern void\tyellow_led_off(void);\n+extern void\tblue_led_on(void);\n+extern void\tblue_led_off(void);\n #else\n \t.extern LED_init\n-\t.extern red_LED_on\n-\t.extern red_LED_off\n-\t.extern yellow_LED_on\n-\t.extern yellow_LED_off\n-\t.extern green_LED_on\n-\t.extern green_LED_off\n-\t.extern blue_LED_on\n-\t.extern blue_LED_off\n+\t.extern red_led_on\n+\t.extern red_led_off\n+\t.extern yellow_led_on\n+\t.extern yellow_led_off\n+\t.extern green_led_on\n+\t.extern green_led_off\n+\t.extern blue_led_on\n+\t.extern blue_led_off\n #endif\n \n #endif\t/* CONFIG_STATUS_LED\t*/\n", "prefixes": [ "U-Boot" ] }