Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1097447/?format=api
{ "id": 1097447, "url": "http://patchwork.ozlabs.org/api/patches/1097447/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190509101051.GB7024@mwanda/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190509101051.GB7024@mwanda>", "list_archive_url": null, "date": "2019-05-09T10:10:51", "name": "i40e/i40evf: cleanup i40e_update_nvm_checksum()", "commit_ref": null, "pull_url": null, "state": "deferred", "archived": false, "hash": "26c722e99d109cd1d3313dbb4914cf0230837eb4", "submitter": { "id": 9327, "url": "http://patchwork.ozlabs.org/api/people/9327/?format=api", "name": "Dan Carpenter", "email": "dan.carpenter@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190509101051.GB7024@mwanda/mbox/", "series": [ { "id": 106951, "url": "http://patchwork.ozlabs.org/api/series/106951/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=106951", "date": "2019-05-09T10:10:51", "name": "i40e/i40evf: cleanup i40e_update_nvm_checksum()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/106951/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1097447/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1097447/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=oracle.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=oracle.com header.i=@oracle.com\n\theader.b=\"cur0yw0x\"; dkim-atps=neutral" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4508J42FRsz9sCJ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 9 May 2019 20:11:11 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E6FE287528;\n\tThu, 9 May 2019 10:11:09 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id xyXxlaE+uQiM; Thu, 9 May 2019 10:11:08 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 91BE187430;\n\tThu, 9 May 2019 10:11:02 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8C56E1BF82B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 May 2019 10:11:01 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8796787528\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 May 2019 10:11:01 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id gmjEpzvqKDIn for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 May 2019 10:11:00 +0000 (UTC)", "from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id AC566873B1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 May 2019 10:11:00 +0000 (UTC)", "from pps.filterd (userp2120.oracle.com [127.0.0.1])\n\tby userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx49A3vVQ169330; Thu, 9 May 2019 10:10:58 GMT", "from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80])\n\tby userp2120.oracle.com with ESMTP id 2s94b11rp4-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 09 May 2019 10:10:58 +0000", "from pps.filterd (userp3030.oracle.com [127.0.0.1])\n\tby userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx49A9w4J185529; Thu, 9 May 2019 10:10:58 GMT", "from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])\n\tby userp3030.oracle.com with ESMTP id 2sagyv5jsn-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 09 May 2019 10:10:58 +0000", "from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12])\n\tby aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tx49AAvGK015241; Thu, 9 May 2019 10:10:57 GMT", "from mwanda (/41.57.98.10) by default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Thu, 09 May 2019 03:10:56 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;\n\th=date : from : to : cc\n\t: subject : message-id : mime-version : content-type;\n\ts=corp-2018-07-02; \n\tbh=qupKCE1+9NLgvlLFD55x9x37iyyxp1hRx7TkBzJRv64=;\n\tb=cur0yw0xXOixscpXpojSdVFeqrb9W3jEx1XMHwlmLc9ySINPEKJs5ZPNZcG9q0jxya0Y\n\trObtgn5HRwEY6vtRMn4zgnyFd91EYlbNcM3V+RzKtADa3o+r/OF7lzGJeIgU2Q5Vhrw6\n\tF3C40aiw/ItXNBnTy1MF8cniUARnGE4Qn9jVgX9VR7+EHl81d1m3LvSXwmz8wXNvA+ed\n\tmNY9dSPjQcOvhyvgLY7LKH810tEz+lEnxWZWYMl7gdm0P8TFF0UQspCk/15+Oz+SxLeQ\n\tJaB9q8IkvkfcA6VbVo9PMMSOVAj6DjCqXNuxUJMf0OpMY8xRL+eJc18Y9AUUv7+NBJz5\n\tbQ== ", "Date": "Thu, 9 May 2019 13:10:51 +0300", "From": "Dan Carpenter <dan.carpenter@oracle.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Message-ID": "<20190509101051.GB7024@mwanda>", "MIME-Version": "1.0", "Content-Disposition": "inline", "X-Mailer": "git-send-email haha only kidding", "User-Agent": "Mutt/1.10.1 (2018-07-13)", "X-Proofpoint-Virus-Version": [ "vendor=nai engine=5900 definitions=9251\n\tsignatures=668686", "vendor=nai engine=5900 definitions=9251\n\tsignatures=668686" ], "X-Proofpoint-Spam-Details": [ "rule=notspam policy=default score=0 suspectscore=0\n\tmalwarescore=0\n\tphishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999\n\tadultscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1810050000 definitions=main-1905090062", "rule=notspam policy=default score=0\n\tpriorityscore=1501 malwarescore=0\n\tsuspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015\n\tlowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999\n\tadultscore=0\n\tclassifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1810050000\n\tdefinitions=main-1905090062" ], "Subject": "[Intel-wired-lan] [PATCH] i40e/i40evf: cleanup\n\ti40e_update_nvm_checksum()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "kernel-janitors@vger.kernel.org, intel-wired-lan@lists.osuosl.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Smatch complains that we use 'checksum' when it's uninitialized.\n\n drivers/net/ethernet/intel/i40e/i40e_nvm.c:581 i40e_update_nvm_checksum()\n error: uninitialized symbol 'checksum'.\n\nThis is true, but it harmless because we don't use it again.\n\nSigned-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_nvm.c | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_nvm.c b/drivers/net/ethernet/intel/i40e/i40e_nvm.c\nindex c508b75c3c09..a60ab9d48065 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_nvm.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_nvm.c\n@@ -578,12 +578,11 @@ i40e_status i40e_update_nvm_checksum(struct i40e_hw *hw)\n \t__le16 le_sum;\n \n \tret_code = i40e_calc_nvm_checksum(hw, &checksum);\n+\tif (ret_code)\n+\t\treturn ret_code;\n \tle_sum = cpu_to_le16(checksum);\n-\tif (!ret_code)\n-\t\tret_code = i40e_write_nvm_aq(hw, 0x00, I40E_SR_SW_CHECKSUM_WORD,\n-\t\t\t\t\t 1, &le_sum, true);\n-\n-\treturn ret_code;\n+\treturn i40e_write_nvm_aq(hw, 0x00, I40E_SR_SW_CHECKSUM_WORD, 1,\n+\t\t\t\t &le_sum, true);\n }\n \n /**\n", "prefixes": [] }