Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1090460/?format=api
{ "id": 1090460, "url": "http://patchwork.ozlabs.org/api/patches/1090460/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190424122055.27896-7-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190424122055.27896-7-alice.michael@intel.com>", "list_archive_url": null, "date": "2019-04-24T12:20:52", "name": "[next,S5,07/10] i40e: Missing response checks in driver when starting/stopping FW LLDP", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f4956bc4bb56971cb772e09f9f43ce0a5db33cd2", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190424122055.27896-7-alice.michael@intel.com/mbox/", "series": [ { "id": 104485, "url": "http://patchwork.ozlabs.org/api/series/104485/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=104485", "date": "2019-04-24T12:20:48", "name": "[next,S5,01/10] i40e: let untrusted VF to create up to 16 VLANs", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/104485/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1090460/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1090460/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 44qBv55Rc3z9s00\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 25 Apr 2019 06:37:05 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id F34B187264;\n\tWed, 24 Apr 2019 20:37:03 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Ck51y3XvaEDR; Wed, 24 Apr 2019 20:36:59 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4A0DB8727F;\n\tWed, 24 Apr 2019 20:36:59 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id BCEA11BF3C0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 24 Apr 2019 20:36:56 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B9D5B8723B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 24 Apr 2019 20:36:56 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mkf3xPQu6tIU for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 24 Apr 2019 20:36:56 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id ABCF387252\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 24 Apr 2019 20:36:55 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t24 Apr 2019 13:36:55 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby fmsmga002.fm.intel.com with ESMTP; 24 Apr 2019 13:36:55 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,390,1549958400\"; d=\"scan'208\";a=\"164544020\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Wed, 24 Apr 2019 05:20:52 -0700", "Message-Id": "<20190424122055.27896-7-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20190424122055.27896-1-alice.michael@intel.com>", "References": "<20190424122055.27896-1-alice.michael@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S5 07/10] i40e: Missing response\n\tchecks in driver when starting/stopping FW LLDP", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Piotr Marczak <piotr.marczak@intel.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Piotr Marczak <piotr.marczak@intel.com>\n\nDriver did not check response on LLDP flag change and always returned\nSUCCESS.\n\nThis patch now checks for an error and returns an error code and has\nadditional information in the log.\n\nSigned-off-by: Piotr Marczak <piotr.marczak@intel.com>\n---\n .../net/ethernet/intel/i40e/i40e_ethtool.c | 27 +++++++++++++++++--\n 1 file changed, 25 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 7f7d04ab1515..0837c6b3e15e 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -4852,9 +4852,11 @@ static u32 i40e_get_priv_flags(struct net_device *dev)\n static int i40e_set_priv_flags(struct net_device *dev, u32 flags)\n {\n \tstruct i40e_netdev_priv *np = netdev_priv(dev);\n+\tu64 orig_flags, new_flags, changed_flags;\n+\tenum i40e_admin_queue_err adq_err;\n \tstruct i40e_vsi *vsi = np->vsi;\n \tstruct i40e_pf *pf = vsi->back;\n-\tu64 orig_flags, new_flags, changed_flags;\n+\ti40e_status status;\n \tu32 i, j;\n \n \torig_flags = READ_ONCE(pf->flags);\n@@ -5013,7 +5015,28 @@ static int i40e_set_priv_flags(struct net_device *dev, u32 flags)\n \t\t\tdcbcfg->pfc.willing = 1;\n \t\t\tdcbcfg->pfc.pfccap = I40E_MAX_TRAFFIC_CLASS;\n \t\t} else {\n-\t\t\ti40e_aq_start_lldp(&pf->hw, false, NULL);\n+\t\t\tstatus = i40e_aq_start_lldp(&pf->hw, false, NULL);\n+\t\t\tif (status) {\n+\t\t\t\tadq_err = pf->hw.aq.asq_last_status;\n+\t\t\t\tswitch (adq_err) {\n+\t\t\t\tcase I40E_AQ_RC_EEXIST:\n+\t\t\t\t\tdev_warn(&pf->pdev->dev,\n+\t\t\t\t\t\t \"FW LLDP agent is already running\\n\");\n+\t\t\t\t\treturn 0;\n+\t\t\t\tcase I40E_AQ_RC_EPERM:\n+\t\t\t\t\tdev_warn(&pf->pdev->dev,\n+\t\t\t\t\t\t \"Device configuration forbids SW from starting the LLDP agent.\\n\");\n+\t\t\t\t\treturn (-EINVAL);\n+\t\t\t\tdefault:\n+\t\t\t\t\tdev_warn(&pf->pdev->dev,\n+\t\t\t\t\t\t \"Starting FW LLDP agent failed: error: %s, %s\\n\",\n+\t\t\t\t\t\t i40e_stat_str(&pf->hw,\n+\t\t\t\t\t\t\t status),\n+\t\t\t\t\t\t i40e_aq_str(&pf->hw,\n+\t\t\t\t\t\t\t adq_err));\n+\t\t\t\t\treturn (-EINVAL);\n+\t\t\t\t}\n+\t\t\t}\n \t\t}\n \t}\n \n", "prefixes": [ "next", "S5", "07/10" ] }