Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1090456/?format=api
{ "id": 1090456, "url": "http://patchwork.ozlabs.org/api/patches/1090456/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190424122055.27896-2-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190424122055.27896-2-alice.michael@intel.com>", "list_archive_url": null, "date": "2019-04-24T12:20:47", "name": "[next,S5,02/10] i40e: add constraints for accessing veb array", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "20e0b29a3e355a6e9ed3639ca1eec9a4255209d2", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190424122055.27896-2-alice.michael@intel.com/mbox/", "series": [ { "id": 104485, "url": "http://patchwork.ozlabs.org/api/series/104485/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=104485", "date": "2019-04-24T12:20:48", "name": "[next,S5,01/10] i40e: let untrusted VF to create up to 16 VLANs", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/104485/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1090456/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1090456/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 44qBv16t5Yz9s4V\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 25 Apr 2019 06:37:01 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 558692E0A0;\n\tWed, 24 Apr 2019 20:37:00 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6i-0PMddzIHv; Wed, 24 Apr 2019 20:36:57 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7E2F42DF55;\n\tWed, 24 Apr 2019 20:36:57 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 4F0521BF3C0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 24 Apr 2019 20:36:56 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4BD318723D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 24 Apr 2019 20:36:56 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id sVe3eegv3hsp for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 24 Apr 2019 20:36:55 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 858C18723B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 24 Apr 2019 20:36:54 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t24 Apr 2019 13:36:54 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby fmsmga002.fm.intel.com with ESMTP; 24 Apr 2019 13:36:53 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,390,1549958400\"; d=\"scan'208\";a=\"164544004\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Wed, 24 Apr 2019 05:20:47 -0700", "Message-Id": "<20190424122055.27896-2-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20190424122055.27896-1-alice.michael@intel.com>", "References": "<20190424122055.27896-1-alice.michael@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S5 02/10] i40e: add constraints for\n\taccessing veb array", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Piotr Kwapulinski <piotr.kwapulinski@intel.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Piotr Kwapulinski <piotr.kwapulinski@intel.com>\n\nAdd veb array access boundary checks.\nEnsure veb array index is smaller than I40E_MAX_VEB.\n\nSigned-off-by: Piotr Kwapulinski <piotr.kwapulinski@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 4e1aacd72b02..5716f8fe06ed 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -9042,7 +9042,7 @@ static void i40e_link_event(struct i40e_pf *pf)\n \t/* Notify the base of the switch tree connected to\n \t * the link. Floating VEBs are not notified.\n \t */\n-\tif (pf->lan_veb != I40E_NO_VEB && pf->veb[pf->lan_veb])\n+\tif (pf->lan_veb < I40E_MAX_VEB && pf->veb[pf->lan_veb])\n \t\ti40e_veb_link_event(pf->veb[pf->lan_veb], new_link);\n \telse\n \t\ti40e_vsi_link_event(vsi, new_link);\n@@ -13001,7 +13001,7 @@ int i40e_is_vsi_uplink_mode_veb(struct i40e_vsi *vsi)\n \tstruct i40e_pf *pf = vsi->back;\n \n \t/* Uplink is not a bridge so default to VEB */\n-\tif (vsi->veb_idx == I40E_NO_VEB)\n+\tif (vsi->veb_idx >= I40E_MAX_VEB)\n \t\treturn 1;\n \n \tveb = pf->veb[vsi->veb_idx];\n@@ -14059,7 +14059,7 @@ static void i40e_setup_pf_switch_element(struct i40e_pf *pf,\n \t\t/* Main VEB? */\n \t\tif (uplink_seid != pf->mac_seid)\n \t\t\tbreak;\n-\t\tif (pf->lan_veb == I40E_NO_VEB) {\n+\t\tif (pf->lan_veb >= I40E_MAX_VEB) {\n \t\t\tint v;\n \n \t\t\t/* find existing or else empty VEB */\n@@ -14069,13 +14069,15 @@ static void i40e_setup_pf_switch_element(struct i40e_pf *pf,\n \t\t\t\t\tbreak;\n \t\t\t\t}\n \t\t\t}\n-\t\t\tif (pf->lan_veb == I40E_NO_VEB) {\n+\t\t\tif (pf->lan_veb >= I40E_MAX_VEB) {\n \t\t\t\tv = i40e_veb_mem_alloc(pf);\n \t\t\t\tif (v < 0)\n \t\t\t\t\tbreak;\n \t\t\t\tpf->lan_veb = v;\n \t\t\t}\n \t\t}\n+\t\tif (pf->lan_veb >= I40E_MAX_VEB)\n+\t\t\tbreak;\n \n \t\tpf->veb[pf->lan_veb]->seid = seid;\n \t\tpf->veb[pf->lan_veb]->uplink_seid = pf->mac_seid;\n@@ -14229,7 +14231,7 @@ static int i40e_setup_pf_switch(struct i40e_pf *pf, bool reinit)\n \t\t/* Set up the PF VSI associated with the PF's main VSI\n \t\t * that is already in the HW switch\n \t\t */\n-\t\tif (pf->lan_veb != I40E_NO_VEB && pf->veb[pf->lan_veb])\n+\t\tif (pf->lan_veb < I40E_MAX_VEB && pf->veb[pf->lan_veb])\n \t\t\tuplink_seid = pf->veb[pf->lan_veb]->seid;\n \t\telse\n \t\t\tuplink_seid = pf->mac_seid;\n", "prefixes": [ "next", "S5", "02/10" ] }