Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1089070/?format=api
{ "id": 1089070, "url": "http://patchwork.ozlabs.org/api/patches/1089070/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20190423055054.16095-1-udit.agarwal@nxp.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190423055054.16095-1-udit.agarwal@nxp.com>", "list_archive_url": null, "date": "2019-04-23T05:52:17", "name": "[U-Boot,v2] armv8: Secure Boot: Modify boot_a_script definition", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b15de4627955d292f906e60df2b76f1b3ca6c477", "submitter": { "id": 70719, "url": "http://patchwork.ozlabs.org/api/people/70719/?format=api", "name": "Udit Agarwal", "email": "udit.agarwal@nxp.com" }, "delegate": { "id": 2467, "url": "http://patchwork.ozlabs.org/api/users/2467/?format=api", "username": "prabhu_kush", "first_name": "Prabhakar", "last_name": "Kushwaha", "email": "prabhakar@freescale.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20190423055054.16095-1-udit.agarwal@nxp.com/mbox/", "series": [ { "id": 104045, "url": "http://patchwork.ozlabs.org/api/series/104045/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=104045", "date": "2019-04-23T05:52:17", "name": "[U-Boot,v2] armv8: Secure Boot: Modify boot_a_script definition", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/104045/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1089070/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1089070/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=nxp.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"iZFloP0G\";\n\tdkim-atps=neutral", "spf=none (sender IP is )\n\tsmtp.mailfrom=udit.agarwal@nxp.com; " ], "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 44pCLQ001Fz9sB3\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 23 Apr 2019 15:53:49 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid B5D57C21E3E; Tue, 23 Apr 2019 05:53:07 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id F374DC21DF9;\n\tTue, 23 Apr 2019 05:52:49 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 554F5C21DD3; Tue, 23 Apr 2019 05:52:47 +0000 (UTC)", "from EUR01-VE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr140075.outbound.protection.outlook.com [40.107.14.75])\n\tby lists.denx.de (Postfix) with ESMTPS id A6C32C21E02\n\tfor <u-boot@lists.denx.de>; Tue, 23 Apr 2019 05:52:18 +0000 (UTC)", "from VI1PR04MB3983.eurprd04.prod.outlook.com (10.171.182.16) by\n\tVI1PR04MB6304.eurprd04.prod.outlook.com (20.179.28.148) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1813.16; Tue, 23 Apr 2019 05:52:17 +0000", "from VI1PR04MB3983.eurprd04.prod.outlook.com\n\t([fe80::9029:fefb:9845:589c]) by\n\tVI1PR04MB3983.eurprd04.prod.outlook.com\n\t([fe80::9029:fefb:9845:589c%2]) with mapi id 15.20.1813.017;\n\tTue, 23 Apr 2019 05:52:17 +0000" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.0 required=5.0 tests=SPF_HELO_PASS, T_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=F3puklp/UCVTWkunXjDegwZ6NZJmmyM+owprMC9osCw=;\n\tb=iZFloP0G6n9GusWw2xdvNRbJkajDeTJ1csv9AGtFMiskx8JcMW4uwlzaxwJiTMJvK9WWfokN4+ZdtlpXVAmdeDfYnIl2ow5qQbedVt6eOi0QIvFdgRAg3BTikw4223PNIcBlpVF139pwhmKrQEugcwKkIEU0Ipf58Od7Tlunk/M=", "From": "Udit Agarwal <udit.agarwal@nxp.com>", "To": "\"u-boot@lists.denx.de\" <u-boot@lists.denx.de>", "Thread-Topic": "[Patch v2] armv8: Secure Boot: Modify boot_a_script definition", "Thread-Index": "AQHU+Zi1hF7s+TcQ3EOTXLy5mQM8zA==", "Date": "Tue, 23 Apr 2019 05:52:17 +0000", "Message-ID": "<20190423055054.16095-1-udit.agarwal@nxp.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-mailer": "git-send-email 2.17.1", "x-clientproxiedby": "BM1PR0101CA0017.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:18::27) To VI1PR04MB3983.eurprd04.prod.outlook.com\n\t(2603:10a6:803:4c::16)", "authentication-results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=nxp.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"iZFloP0G\";\n\tdkim-atps=neutral", "spf=none (sender IP is )\n\tsmtp.mailfrom=udit.agarwal@nxp.com; " ], "x-ms-exchange-messagesentrepresentingtype": "1", "x-originating-ip": "[92.120.1.69]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "93dcc3fa-7013-4d39-1594-08d6c7afd7b0", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);\n\tSRVR:VI1PR04MB6304; ", "x-ms-traffictypediagnostic": "VI1PR04MB6304:", "x-microsoft-antispam-prvs": "<VI1PR04MB6304B2D16549997E99A7DD189E230@VI1PR04MB6304.eurprd04.prod.outlook.com>", "x-forefront-prvs": "0016DEFF96", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(136003)(396003)(376002)(346002)(366004)(39860400002)(199004)(189003)(14444005)(5660300002)(6512007)(99286004)(14454004)(256004)(6916009)(52116002)(4326008)(71200400001)(71190400001)(2906002)(68736007)(478600001)(6486002)(36756003)(66066001)(53936002)(6436002)(3846002)(6116002)(5640700003)(1076003)(54906003)(2616005)(2351001)(316002)(97736004)(44832011)(73956011)(305945005)(7736002)(2501003)(186003)(8936002)(8676002)(64756008)(26005)(102836004)(66446008)(6506007)(386003)(25786009)(476003)(66946007)(81166006)(66476007)(86362001)(66556008)(81156014)(486006)(50226002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB6304;\n\tH:VI1PR04MB3983.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "4xoJCZgDzjrSK4KKGZkC1Kru7vn1qdwOltS2ySbjAsa8sdgZQgL6k+0523qdBk2hPCgdqIKGX0aljdaYGEDbWo454Qu5UqNqh+GuaiGFhVZUgEz+O7GGIo+UOZMjhUY2jAu5rdXfDOjYTvTbyHAW1k9QIlCp13itCt3g3TQsVQDAWPfuSGSWv9W2VTWAtsurrWtdZhCrvOYGOzAm5TrDiEZiLym0++el5DOgZaw6XZNk9lebq39Pj8nB+zxgZeKPFtmHoiTweCjXkABJazPhjbue9Dt+iJUV38EjmL8/cC1MjtuLnldolWnczWnHEMPVLyVqo7W7fKI5Xkwwh7Y43fMjjWwBzpfTlZOzHNZOERSd2Yyl5EYLfLGEdJU+pJAeZ3XBRQVdTJojBgPCcul4D0hjCvaJn4/p4u5K9ja8r60=", "MIME-Version": "1.0", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "93dcc3fa-7013-4d39-1594-08d6c7afd7b0", "X-MS-Exchange-CrossTenant-originalarrivaltime": "23 Apr 2019 05:52:17.4251\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR04MB6304", "Cc": "Udit Agarwal <udit.agarwal@nxp.com>,\n\tRuchika Gupta <ruchika.gupta@nxp.com>, \n\tVinitha V Pillai <vinitha.pillai@nxp.com>", "Subject": "[U-Boot] [Patch v2] armv8: Secure Boot: Modify boot_a_script\n\tdefinition", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "From: Vinitha V Pillai <vinitha.pillai@nxp.com>\n\nboot_script_hdr does not exist, it should not continue to\nboot. So adding separate validation after loading boot_script.\n\nThe secure boot validation of the bootscript header will fail\nand halts the further execution of commands which prevent\nsource command from execution.\n\nSigned-off-by: Vinitha V Pillai <vinitha.pillai@nxp.com>\nSigned-off-by: Udit Agarwal <udit.agarwal@nxp.com>\n---\nChanges in V2:\nCorrects commit message to add more clarity.\n\n include/configs/ls1012afrwy.h | 3 ++-\n include/configs/ls1012ardb.h | 3 ++-\n include/configs/ls1021atwr.h | 3 ++-\n include/configs/ls1043a_common.h | 3 ++-\n include/configs/ls1046a_common.h | 5 +++--\n include/configs/ls1088ardb.h | 3 ++-\n include/configs/ls2080ardb.h | 3 ++-\n 7 files changed, 15 insertions(+), 8 deletions(-)", "diff": "diff --git a/include/configs/ls1012afrwy.h b/include/configs/ls1012afrwy.h\r\nindex ebb1df41c7..12e6437a05 100644\r\n--- a/include/configs/ls1012afrwy.h\r\n+++ b/include/configs/ls1012afrwy.h\r\n@@ -98,7 +98,8 @@\r\n \t\t\t\"${scriptaddr} ${prefix}${script}; \" \\\r\n \t\t\"env exists secureboot && load ${devtype} \" \\\r\n \t\t\t\"${devnum}:${distro_bootpart} \"\t\t\\\r\n-\t\t\t\"${scripthdraddr} ${prefix}${boot_script_hdr} \" \\\r\n+\t\t\t\"${scripthdraddr} ${prefix}${boot_script_hdr}; \" \\\r\n+\t\t\t\"env exists secureboot \"\t\\\r\n \t\t\t\"&& esbc_validate ${scripthdraddr};\" \\\r\n \t\t\"source ${scriptaddr}\\0\"\t \\\r\n \t\"installer=load mmc 0:2 $load_addr \"\t\\\r\ndiff --git a/include/configs/ls1012ardb.h b/include/configs/ls1012ardb.h\r\nindex f149a604cf..f6640fa499 100644\r\n--- a/include/configs/ls1012ardb.h\r\n+++ b/include/configs/ls1012ardb.h\r\n@@ -98,7 +98,8 @@\r\n \t\t\t\"${scriptaddr} ${prefix}${script}; \" \\\r\n \t\t\"env exists secureboot && load ${devtype} \" \\\r\n \t\t\t\"${devnum}:${distro_bootpart} \"\t\t\\\r\n-\t\t\t\"${scripthdraddr} ${prefix}${boot_script_hdr} \" \\\r\n+\t\t\t\"${scripthdraddr} ${prefix}${boot_script_hdr}; \" \\\r\n+\t\t\t\"env exists secureboot \"\t\\\r\n \t\t\t\"&& esbc_validate ${scripthdraddr};\" \\\r\n \t\t\"source ${scriptaddr}\\0\"\t \\\r\n \t\"installer=load mmc 0:2 $load_addr \"\t\\\r\ndiff --git a/include/configs/ls1021atwr.h b/include/configs/ls1021atwr.h\r\nindex da55bf2f43..2616f4aa5c 100644\r\n--- a/include/configs/ls1021atwr.h\r\n+++ b/include/configs/ls1021atwr.h\r\n@@ -364,7 +364,8 @@\r\n \t\t\t\"${scriptaddr} ${prefix}${script}; \" \\\r\n \t\t\"env exists secureboot && load ${devtype} \" \\\r\n \t\t\t\"${devnum}:${distro_bootpart} \"\t\t\\\r\n-\t\t\t\"${scripthdraddr} ${prefix}${boot_script_hdr} \" \\\r\n+\t\t\t\"${scripthdraddr} ${prefix}${boot_script_hdr}; \" \\\r\n+\t\t\t\"env exists secureboot \"\t\\\r\n \t\t\t\"&& esbc_validate ${scripthdraddr};\" \\\r\n \t\t\"source ${scriptaddr}\\0\"\t \\\r\n \t\"installer=load mmc 0:2 $load_addr \"\t\\\r\ndiff --git a/include/configs/ls1043a_common.h b/include/configs/ls1043a_common.h\r\nindex 2e9d476483..8618a5f182 100644\r\n--- a/include/configs/ls1043a_common.h\r\n+++ b/include/configs/ls1043a_common.h\r\n@@ -275,7 +275,8 @@\r\n \t\t\t\"${scriptaddr} ${prefix}${script}; \"\t\\\r\n \t\t\"env exists secureboot && load ${devtype} \"\t\\\r\n \t\t\t\"${devnum}:${distro_bootpart} \"\t\t\\\r\n-\t\t\t\"${scripthdraddr} ${prefix}${boot_script_hdr} \"\t\\\r\n+\t\t\t\"${scripthdraddr} ${prefix}${boot_script_hdr}; \" \\\r\n+\t\t\t\"env exists secureboot \"\t\\\r\n \t\t\t\"&& esbc_validate ${scripthdraddr};\"\t\\\r\n \t\t\"source ${scriptaddr}\\0\"\t\t\t\\\r\n \t\"qspi_bootcmd=echo Trying load from qspi..;\"\t\\\r\ndiff --git a/include/configs/ls1046a_common.h b/include/configs/ls1046a_common.h\r\nindex 24ff2d1547..e4e71b24d4 100644\r\n--- a/include/configs/ls1046a_common.h\r\n+++ b/include/configs/ls1046a_common.h\r\n@@ -256,8 +256,9 @@\r\n \t\t\t\"${scriptaddr} ${prefix}${script}; \" \\\r\n \t\t\"env exists secureboot && load ${devtype} \" \\\r\n \t\t\t\"${devnum}:${distro_bootpart} \"\t\t\\\r\n-\t\t\t\"${scripthdraddr} ${prefix}${boot_script_hdr} \" \\\r\n-\t\t\t\"&& esbc_validate ${scripthdraddr};\" \\\r\n+\t\t\t\"${scripthdraddr} ${prefix}${boot_script_hdr}; \" \\\r\n+\t\t\t\"env exists secureboot \"\t\\\r\n+\t\t\t\"&& esbc_validate ${scripthdraddr};\"\t\\\r\n \t\t\"source ${scriptaddr}\\0\"\t \\\r\n \t\"qspi_bootcmd=echo Trying load from qspi..;\" \\\r\n \t\t\"sf probe && sf read $load_addr \" \\\r\ndiff --git a/include/configs/ls1088ardb.h b/include/configs/ls1088ardb.h\r\nindex 45af087dc6..322adb530a 100644\r\n--- a/include/configs/ls1088ardb.h\r\n+++ b/include/configs/ls1088ardb.h\r\n@@ -398,7 +398,8 @@\r\n \t\t\"${scriptaddr} ${prefix}${script}; \"\t\t\\\r\n \t\"env exists secureboot && load ${devtype} \"\t\t\\\r\n \t\t\"${devnum}:${distro_bootpart} \"\t\t\t\\\r\n-\t\t\"${scripthdraddr} ${prefix}${boot_script_hdr} \" \\\r\n+\t\t\"${scripthdraddr} ${prefix}${boot_script_hdr}; \"\\\r\n+\t\t\"env exists secureboot \"\t\t\t\\\r\n \t\t\"&& esbc_validate ${scripthdraddr};\"\t\t\\\r\n \t\t\"source ${scriptaddr}\\0\"\t\t\t\\\r\n \t\"installer=load mmc 0:2 $load_addr \"\t\t\t\\\r\ndiff --git a/include/configs/ls2080ardb.h b/include/configs/ls2080ardb.h\r\nindex e41ace6685..2e8a8bbdb7 100644\r\n--- a/include/configs/ls2080ardb.h\r\n+++ b/include/configs/ls2080ardb.h\r\n@@ -495,7 +495,8 @@ unsigned long get_board_sys_clk(void);\r\n \t\t\t\"${scriptaddr} ${prefix}${script}; \"\t\\\r\n \t\t\"env exists secureboot && load ${devtype} \"\t\\\r\n \t\t\t\"${devnum}:${distro_bootpart} \"\t\t\\\r\n-\t\t\t\"${scripthdraddr} ${prefix}${boot_script_hdr} \"\t\\\r\n+\t\t\t\"${scripthdraddr} ${prefix}${boot_script_hdr}; \" \\\r\n+\t\t\t\"env exists secureboot \"\t\\\r\n \t\t\t\"&& esbc_validate ${scripthdraddr};\"\t\\\r\n \t\t\"source ${scriptaddr}\\0\"\t\t\t\\\r\n \t\"qspi_bootcmd=echo Trying load from qspi..;\"\t\t\\\r\n", "prefixes": [ "U-Boot", "v2" ] }