Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1088449/?format=api
{ "id": 1088449, "url": "http://patchwork.ozlabs.org/api/patches/1088449/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190421081723.34232-1-sasha.neftin@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190421081723.34232-1-sasha.neftin@intel.com>", "list_archive_url": null, "date": "2019-04-21T08:17:23", "name": "[v1,1/1] igc: Cleanup the redundant code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e81068c799ea86c27372b239a01c037cd0f301e5", "submitter": { "id": 69860, "url": "http://patchwork.ozlabs.org/api/people/69860/?format=api", "name": "Sasha Neftin", "email": "sasha.neftin@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190421081723.34232-1-sasha.neftin@intel.com/mbox/", "series": [ { "id": 103831, "url": "http://patchwork.ozlabs.org/api/series/103831/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=103831", "date": "2019-04-21T08:17:23", "name": "[v1,1/1] igc: Cleanup the redundant code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/103831/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1088449/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1088449/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 44n2dB0Zsmz9s5c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 21 Apr 2019 18:17:31 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id BC908838D9;\n\tSun, 21 Apr 2019 08:17:29 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 9668JzGu1rnG; Sun, 21 Apr 2019 08:17:27 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B78E581FEE;\n\tSun, 21 Apr 2019 08:17:27 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8A5C01BF8C7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 21 Apr 2019 08:17:26 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8656D85657\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 21 Apr 2019 08:17:26 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id gf_zwdHG8KCL for <intel-wired-lan@lists.osuosl.org>;\n\tSun, 21 Apr 2019 08:17:26 +0000 (UTC)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id EECE285625\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 21 Apr 2019 08:17:25 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Apr 2019 01:17:24 -0700", "from ccdlinuxdev08.iil.intel.com ([143.185.161.150])\n\tby fmsmga002.fm.intel.com with ESMTP; 21 Apr 2019 01:17:24 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,377,1549958400\"; d=\"scan'208\";a=\"163449334\"", "From": "Sasha Neftin <sasha.neftin@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Sun, 21 Apr 2019 11:17:23 +0300", "Message-Id": "<20190421081723.34232-1-sasha.neftin@intel.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[Intel-wired-lan] [PATCH v1 1/1] igc: Cleanup the redundant code", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The default flow control settings for the i225 device is both\n'rx' and 'tx' pause frames. There is no depend on the NVM value.\nThis patch comes to fix this and clean up the driver code.\n\nSigned-off-by: Sasha Neftin <sasha.neftin@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_mac.c | 23 +++--------------------\n 1 file changed, 3 insertions(+), 20 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_mac.c b/drivers/net/ethernet/intel/igc/igc_mac.c\nindex f7683d3ae47c..ba4646737288 100644\n--- a/drivers/net/ethernet/intel/igc/igc_mac.c\n+++ b/drivers/net/ethernet/intel/igc/igc_mac.c\n@@ -8,7 +8,6 @@\n #include \"igc_hw.h\"\n \n /* forward declaration */\n-static s32 igc_set_default_fc(struct igc_hw *hw);\n static s32 igc_set_fc_watermarks(struct igc_hw *hw);\n \n /**\n@@ -96,13 +95,10 @@ s32 igc_setup_link(struct igc_hw *hw)\n \t\tgoto out;\n \n \t/* If requested flow control is set to default, set flow control\n-\t * based on the EEPROM flow control settings.\n+\t * to the both 'rx' and 'tx' pause frames.\n \t */\n-\tif (hw->fc.requested_mode == igc_fc_default) {\n-\t\tret_val = igc_set_default_fc(hw);\n-\t\tif (ret_val)\n-\t\t\tgoto out;\n-\t}\n+\tif (hw->fc.requested_mode == igc_fc_default)\n+\t\thw->fc.requested_mode = igc_fc_full;\n \n \t/* We want to save off the original Flow Control configuration just\n \t * in case we get disconnected and then reconnected into a different\n@@ -136,19 +132,6 @@ s32 igc_setup_link(struct igc_hw *hw)\n }\n \n /**\n- * igc_set_default_fc - Set flow control default values\n- * @hw: pointer to the HW structure\n- *\n- * Read the EEPROM for the default values for flow control and store the\n- * values.\n- */\n-static s32 igc_set_default_fc(struct igc_hw *hw)\n-{\n-\thw->fc.requested_mode = igc_fc_full;\n-\treturn 0;\n-}\n-\n-/**\n * igc_force_mac_fc - Force the MAC's flow control settings\n * @hw: pointer to the HW structure\n *\n", "prefixes": [ "v1", "1/1" ] }