Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1087816/?format=api
{ "id": 1087816, "url": "http://patchwork.ozlabs.org/api/patches/1087816/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190418203153.37605-1-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190418203153.37605-1-alice.michael@intel.com>", "list_archive_url": null, "date": "2019-04-18T20:31:53", "name": "i40e: Memory leak in i40e_config_iwarp_qvlist", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "de4cc74b336b324ebb1747df1c251c5d7a22cdab", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190418203153.37605-1-alice.michael@intel.com/mbox/", "series": [ { "id": 103589, "url": "http://patchwork.ozlabs.org/api/series/103589/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=103589", "date": "2019-04-18T20:31:53", "name": "i40e: Memory leak in i40e_config_iwarp_qvlist", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/103589/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1087816/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1087816/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 44lW6P6vM4z9s4V\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 19 Apr 2019 06:34:03 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id C4CED85F49;\n\tThu, 18 Apr 2019 20:34:01 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id fRhGpfUiSztq; Thu, 18 Apr 2019 20:34:00 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 014BC85DB1;\n\tThu, 18 Apr 2019 20:34:00 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 657871BF315\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 18 Apr 2019 20:33:58 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 618F0228D5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 18 Apr 2019 20:33:58 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id EhThVkJN180L for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 18 Apr 2019 20:33:57 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby silver.osuosl.org (Postfix) with ESMTPS id AC22C2284A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 18 Apr 2019 20:33:57 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Apr 2019 13:33:56 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby orsmga005.jf.intel.com with ESMTP; 18 Apr 2019 13:33:56 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,367,1549958400\"; d=\"scan'208\";a=\"317114771\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Thu, 18 Apr 2019 13:31:53 -0700", "Message-Id": "<20190418203153.37605-1-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.19.2", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] i40e: Memory leak in\n\ti40e_config_iwarp_qvlist", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Martyna Szapar <martyna.szapar@intel.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Martyna Szapar <martyna.szapar@intel.com>\n\nAdded freeing the old allocation of vf->qvlist_info in function\ni40e_config_iwarp_qvlist before overwriting it with\nthe new allocation.\n\nSigned-off-by: Martyna Szapar <martyna.szapar@intel.com>\n---\n .../ethernet/intel/i40e/i40e_virtchnl_pf.c | 23 ++++++++++++-------\n 1 file changed, 15 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex ebe18276cea1..479bc60c8f71 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -441,6 +441,7 @@ static int i40e_config_iwarp_qvlist(struct i40e_vf *vf,\n \tu32 v_idx, i, reg_idx, reg;\n \tu32 next_q_idx, next_q_type;\n \tu32 msix_vf, size;\n+\tint ret = 0;\n \n \tmsix_vf = pf->hw.func_caps.num_msix_vectors_vf;\n \n@@ -449,16 +450,19 @@ static int i40e_config_iwarp_qvlist(struct i40e_vf *vf,\n \t\t\t \"Incorrect number of iwarp vectors %u. Maximum %u allowed.\\n\",\n \t\t\t qvlist_info->num_vectors,\n \t\t\t msix_vf);\n-\t\tgoto err;\n+\t\tret = -EINVAL;\n+\t\tgoto err_out;\n \t}\n \n \tsize = sizeof(struct virtchnl_iwarp_qvlist_info) +\n \t (sizeof(struct virtchnl_iwarp_qv_info) *\n \t\t\t\t\t\t(qvlist_info->num_vectors - 1));\n+\tkfree(vf->qvlist_info);\n \tvf->qvlist_info = kzalloc(size, GFP_KERNEL);\n-\tif (!vf->qvlist_info)\n-\t\treturn -ENOMEM;\n-\n+\tif (!vf->qvlist_info) {\n+\t\tret = -ENOMEM;\n+\t\tgoto err_out;\n+\t}\n \tvf->qvlist_info->num_vectors = qvlist_info->num_vectors;\n \n \tmsix_vf = pf->hw.func_caps.num_msix_vectors_vf;\n@@ -469,8 +473,10 @@ static int i40e_config_iwarp_qvlist(struct i40e_vf *vf,\n \t\tv_idx = qv_info->v_idx;\n \n \t\t/* Validate vector id belongs to this vf */\n-\t\tif (!i40e_vc_isvalid_vector_id(vf, v_idx))\n-\t\t\tgoto err;\n+\t\tif (!i40e_vc_isvalid_vector_id(vf, v_idx)) {\n+\t\t\tret = -EINVAL;\n+\t\t\tgoto err_free;\n+\t\t}\n \n \t\tvf->qvlist_info->qv_info[i] = *qv_info;\n \n@@ -512,10 +518,11 @@ static int i40e_config_iwarp_qvlist(struct i40e_vf *vf,\n \t}\n \n \treturn 0;\n-err:\n+err_free:\n \tkfree(vf->qvlist_info);\n \tvf->qvlist_info = NULL;\n-\treturn -EINVAL;\n+err_out:\n+\treturn ret;\n }\n \n /**\n", "prefixes": [] }