Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1086839/?format=api
{ "id": 1086839, "url": "http://patchwork.ozlabs.org/api/patches/1086839/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/155548880068.3454.1621821881762819373.stgit@buzz/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<155548880068.3454.1621821881762819373.stgit@buzz>", "list_archive_url": null, "date": "2019-04-17T08:13:20", "name": "[2/2] e1000e: start network tx queue only when link is up", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "85da66aae7dd29547591ac7ed809ee0b1233bade", "submitter": { "id": 65606, "url": "http://patchwork.ozlabs.org/api/people/65606/?format=api", "name": "Konstantin Khlebnikov", "email": "khlebnikov@yandex-team.ru" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/155548880068.3454.1621821881762819373.stgit@buzz/mbox/", "series": [ { "id": 103219, "url": "http://patchwork.ozlabs.org/api/series/103219/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=103219", "date": "2019-04-17T08:13:16", "name": "[1/2] Revert \"e1000e: fix cyclic resets at link up with active tx\"", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/103219/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1086839/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1086839/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=fail (p=none dis=none)\n\theader.from=yandex-team.ru", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n\theader.b=\"bHJJfJba\"; dkim-atps=neutral", "mxbackcorp1g.mail.yandex.net;\n\tdkim=pass header.i=@yandex-team.ru" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 44kZtx3z6Kz9s3Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Apr 2019 18:20:57 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5980D86C18;\n\tWed, 17 Apr 2019 08:20:55 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tCjX3jUpB-DF; Wed, 17 Apr 2019 08:20:50 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5DE0886BB7;\n\tWed, 17 Apr 2019 08:20:50 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id D3C7D1BF2AF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Apr 2019 08:20:48 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id CF70D87009\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Apr 2019 08:20:48 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CGTQjE+WCCVw for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Apr 2019 08:20:45 +0000 (UTC)", "from forwardcorp1o.mail.yandex.net (forwardcorp1o.mail.yandex.net\n\t[95.108.205.193])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 00D0786CDC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Apr 2019 08:20:44 +0000 (UTC)", "from mxbackcorp1g.mail.yandex.net (mxbackcorp1g.mail.yandex.net\n\t[IPv6:2a02:6b8:0:1402::301])\n\tby forwardcorp1o.mail.yandex.net (Yandex) with ESMTP id E76C12E145C; \n\tWed, 17 Apr 2019 11:13:21 +0300 (MSK)", "from smtpcorp1p.mail.yandex.net (smtpcorp1p.mail.yandex.net\n\t[2a02:6b8:0:1472:2741:0:8b6:10])\n\tby mxbackcorp1g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id\n\ttyKNRnWhQ2-DLoOacZo; Wed, 17 Apr 2019 11:13:21 +0300", "from dynamic-red.dhcp.yndx.net (dynamic-red.dhcp.yndx.net\n\t[2a02:6b8:0:40c:f5ec:9361:ed45:768f])\n\tby smtpcorp1p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id\n\t5VSG6SVdjC-DK0ipQ0r; Wed, 17 Apr 2019 11:13:20 +0300\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (Client certificate not present)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:07:21 by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n\ts=default; \n\tt=1555488801; bh=erQjNL5gbIE//F78NAsnJp4HRRQg3PFtAJnUT1IRkZE=;\n\th=In-Reply-To:Message-ID:References:Date:To:From:Subject:Cc;\n\tb=bHJJfJba+FA5aWWTIIGEzUQciZrmfp72Vp/9N1kFEx4hN6Mu7wNZUCi8nYx9qaDmE\n\t0xx/moDmxWmdLQth9QM9TBLTIo52/FuP+MfYvQRTfDao/xUFIsXypSNPs5ICYtpEHs\n\trIsRdpNVN14GMjRG/Xgc+CwTMO4prpQYne2oyVlM=", "From": "Konstantin Khlebnikov <khlebnikov@yandex-team.ru>", "To": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tlinux-kernel@vger.kernel.org, Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Wed, 17 Apr 2019 11:13:20 +0300", "Message-ID": "<155548880068.3454.1621821881762819373.stgit@buzz>", "In-Reply-To": "<155548879651.3454.13167784936351314661.stgit@buzz>", "References": "<155548879651.3454.13167784936351314661.stgit@buzz>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 2/2] e1000e: start network tx queue only\n\twhen link is up", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Sasha Levin <sashal@kernel.org>, e1000-devel@lists.sourceforge.net,\n\tJoseph Yasi <joe.yasi@gmail.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Driver does not want to keep packets in tx queue when link is lost.\nBut present code only reset NIC to flush them, but does not prevent\nqueuing new packets. Moreover reset sequence itself could generate\nnew packets via netconsole and NIC falls into endless reset loop.\n\nThis patch wakes tx queue only when NIC is ready to send packets.\n\nThis is proper fix for problem addressed by commit 0f9e980bf5ee\n(\"e1000e: fix cyclic resets at link up with active tx\").\n\nSigned-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>\nSuggested-by: Alexander Duyck <alexander.duyck@gmail.com>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex ba96e52aa8d1..fe643d66aa10 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -4209,7 +4209,7 @@ void e1000e_up(struct e1000_adapter *adapter)\n \t\te1000_configure_msix(adapter);\n \te1000_irq_enable(adapter);\n \n-\tnetif_start_queue(adapter->netdev);\n+\t/* tx queue started by watchdog timer when link is up */\n \n \te1000e_trigger_lsc(adapter);\n }\n@@ -4607,6 +4607,7 @@ int e1000e_open(struct net_device *netdev)\n \tpm_runtime_get_sync(&pdev->dev);\n \n \tnetif_carrier_off(netdev);\n+\tnetif_stop_queue(netdev);\n \n \t/* allocate transmit descriptors */\n \terr = e1000e_setup_tx_resources(adapter->tx_ring);\n@@ -4667,7 +4668,6 @@ int e1000e_open(struct net_device *netdev)\n \te1000_irq_enable(adapter);\n \n \tadapter->tx_hang_recheck = false;\n-\tnetif_start_queue(netdev);\n \n \thw->mac.get_link_status = true;\n \tpm_runtime_put(&pdev->dev);\n@@ -5289,6 +5289,7 @@ static void e1000_watchdog_task(struct work_struct *work)\n \t\t\tif (phy->ops.cfg_on_link_up)\n \t\t\t\tphy->ops.cfg_on_link_up(hw);\n \n+\t\t\tnetif_wake_queue(netdev);\n \t\t\tnetif_carrier_on(netdev);\n \n \t\t\tif (!test_bit(__E1000_DOWN, &adapter->state))\n@@ -5302,6 +5303,7 @@ static void e1000_watchdog_task(struct work_struct *work)\n \t\t\t/* Link status message must follow this format */\n \t\t\tpr_info(\"%s NIC Link is Down\\n\", adapter->netdev->name);\n \t\t\tnetif_carrier_off(netdev);\n+\t\t\tnetif_stop_queue(netdev);\n \t\t\tif (!test_bit(__E1000_DOWN, &adapter->state))\n \t\t\t\tmod_timer(&adapter->phy_info_timer,\n \t\t\t\t\t round_jiffies(jiffies + 2 * HZ));\n", "prefixes": [ "2/2" ] }