Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1086478/?format=api
{ "id": 1086478, "url": "http://patchwork.ozlabs.org/api/patches/1086478/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190416173052.28928-9-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190416173052.28928-9-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2019-04-16T17:30:45", "name": "[S20,08/15] ice: Check all VFs for MDD activity, don't disable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "990420cdfc1a9cf388256c0857b3537496a271cf", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190416173052.28928-9-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 103108, "url": "http://patchwork.ozlabs.org/api/series/103108/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=103108", "date": "2019-04-16T17:30:37", "name": "Fixes and feature updates for ice", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/103108/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1086478/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1086478/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 44kC8l5ckkz9s55\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Apr 2019 03:31:35 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6A5F485F43;\n\tTue, 16 Apr 2019 17:31:34 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tynaXbTg7lAv; Tue, 16 Apr 2019 17:31:33 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id C259A85E8C;\n\tTue, 16 Apr 2019 17:31:33 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id E8A291BF28D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Apr 2019 17:31:29 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id E3D552206D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Apr 2019 17:31:29 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hyQ1wS+XML-F for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Apr 2019 17:31:27 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby silver.osuosl.org (Postfix) with ESMTPS id F0381241AE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Apr 2019 17:31:26 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t16 Apr 2019 10:31:25 -0700", "from shasta.jf.intel.com ([10.166.244.191])\n\tby orsmga002.jf.intel.com with ESMTP; 16 Apr 2019 10:31:25 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,358,1549958400\"; d=\"scan'208\";a=\"151390484\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 16 Apr 2019 10:30:45 -0700", "Message-Id": "<20190416173052.28928-9-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190416173052.28928-1-anirudh.venkataramanan@intel.com>", "References": "<20190416173052.28928-1-anirudh.venkataramanan@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S20 08/15] ice: Check all VFs for MDD\n\tactivity, don't disable", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nDon't use the mdd_detected variable as an exit condition for this loop;\nthe first VF to NOT have an MDD event will cause the loop to terminate.\n\nInstead just look at all of the VFs, but don't disable them. This\nprevents proper release of resources if the VFs are rebooted or the VF\ndriver reloaded. Instead, just log a message and call out repeat\noffenders.\n\nTo make it clear what we are doing, use a differently-named variable in\nthe loop.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_main.c | 23 +++++++++++------------\n 1 file changed, 11 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 6fc4d8176d14..59971f6224f1 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -1161,16 +1161,16 @@ static void ice_handle_mdd_event(struct ice_pf *pf)\n \t\t}\n \t}\n \n-\t/* see if one of the VFs needs to be reset */\n-\tfor (i = 0; i < pf->num_alloc_vfs && mdd_detected; i++) {\n+\t/* check to see if one of the VFs caused the MDD */\n+\tfor (i = 0; i < pf->num_alloc_vfs; i++) {\n \t\tstruct ice_vf *vf = &pf->vf[i];\n \n-\t\tmdd_detected = false;\n+\t\tbool vf_mdd_detected = false;\n \n \t\treg = rd32(hw, VP_MDET_TX_PQM(i));\n \t\tif (reg & VP_MDET_TX_PQM_VALID_M) {\n \t\t\twr32(hw, VP_MDET_TX_PQM(i), 0xFFFF);\n-\t\t\tmdd_detected = true;\n+\t\t\tvf_mdd_detected = true;\n \t\t\tdev_info(&pf->pdev->dev, \"TX driver issue detected on VF %d\\n\",\n \t\t\t\t i);\n \t\t}\n@@ -1178,7 +1178,7 @@ static void ice_handle_mdd_event(struct ice_pf *pf)\n \t\treg = rd32(hw, VP_MDET_TX_TCLAN(i));\n \t\tif (reg & VP_MDET_TX_TCLAN_VALID_M) {\n \t\t\twr32(hw, VP_MDET_TX_TCLAN(i), 0xFFFF);\n-\t\t\tmdd_detected = true;\n+\t\t\tvf_mdd_detected = true;\n \t\t\tdev_info(&pf->pdev->dev, \"TX driver issue detected on VF %d\\n\",\n \t\t\t\t i);\n \t\t}\n@@ -1186,7 +1186,7 @@ static void ice_handle_mdd_event(struct ice_pf *pf)\n \t\treg = rd32(hw, VP_MDET_TX_TDPU(i));\n \t\tif (reg & VP_MDET_TX_TDPU_VALID_M) {\n \t\t\twr32(hw, VP_MDET_TX_TDPU(i), 0xFFFF);\n-\t\t\tmdd_detected = true;\n+\t\t\tvf_mdd_detected = true;\n \t\t\tdev_info(&pf->pdev->dev, \"TX driver issue detected on VF %d\\n\",\n \t\t\t\t i);\n \t\t}\n@@ -1194,19 +1194,18 @@ static void ice_handle_mdd_event(struct ice_pf *pf)\n \t\treg = rd32(hw, VP_MDET_RX(i));\n \t\tif (reg & VP_MDET_RX_VALID_M) {\n \t\t\twr32(hw, VP_MDET_RX(i), 0xFFFF);\n-\t\t\tmdd_detected = true;\n+\t\t\tvf_mdd_detected = true;\n \t\t\tdev_info(&pf->pdev->dev, \"RX driver issue detected on VF %d\\n\",\n \t\t\t\t i);\n \t\t}\n \n-\t\tif (mdd_detected) {\n+\t\tif (vf_mdd_detected) {\n \t\t\tvf->num_mdd_events++;\n-\t\t\tdev_info(&pf->pdev->dev,\n-\t\t\t\t \"Use PF Control I/F to re-enable the VF\\n\");\n-\t\t\tset_bit(ICE_VF_STATE_DIS, vf->vf_states);\n+\t\t\tif (vf->num_mdd_events > 1)\n+\t\t\t\tdev_info(&pf->pdev->dev, \"VF %d has had %llu MDD events since last boot\\n\",\n+\t\t\t\t\t i, vf->num_mdd_events);\n \t\t}\n \t}\n-\n }\n \n /**\n", "prefixes": [ "S20", "08/15" ] }