Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1086471/?format=api
{ "id": 1086471, "url": "http://patchwork.ozlabs.org/api/patches/1086471/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190416172439.27908-7-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190416172439.27908-7-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2019-04-16T17:24:30", "name": "[S19,06/15] ice: Advertise supported link modes if none requested", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "dcf9df0252f22f2618e61b7654afdd9d2cd17890", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190416172439.27908-7-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 103107, "url": "http://patchwork.ozlabs.org/api/series/103107/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=103107", "date": "2019-04-16T17:24:38", "name": "Fixes and feature updates for ice", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/103107/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1086471/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1086471/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 44kC1n5cDRz9s55\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Apr 2019 03:25:33 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5F76E23600;\n\tTue, 16 Apr 2019 17:25:32 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ArNXURaq2J09; Tue, 16 Apr 2019 17:25:23 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id AEBB925D30;\n\tTue, 16 Apr 2019 17:25:19 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7FBCB1BF9A0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Apr 2019 17:25:15 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7C45E8739E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Apr 2019 17:25:15 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id N1mqGpcy4fDu for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Apr 2019 17:25:14 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 0FFA487A1D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Apr 2019 17:25:14 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t16 Apr 2019 10:25:11 -0700", "from shasta.jf.intel.com ([10.166.244.191])\n\tby orsmga001.jf.intel.com with ESMTP; 16 Apr 2019 10:25:11 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,358,1549958400\"; d=\"scan'208\";a=\"224064169\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 16 Apr 2019 10:24:30 -0700", "Message-Id": "<20190416172439.27908-7-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190416172439.27908-1-anirudh.venkataramanan@intel.com>", "References": "<20190416172439.27908-1-anirudh.venkataramanan@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S19 06/15] ice: Advertise supported link\n\tmodes if none requested", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Tony Nguyen <anthony.l.nguyen@intel.com>\n\nUser requested link modes affect what is returned as an advertised\nlink mode. If no modes have been requested, we are not advertising\nany link modes. Advertise what we are capable of supporting if no\nlink modes have been requested.\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 75 +++++++++++++-------\n 1 file changed, 50 insertions(+), 25 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex c1511393846f..91e3c451c66c 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -628,7 +628,8 @@ ice_phy_type_to_ethtool(struct net_device *netdev,\n \t phy_types_low & ICE_PHY_TYPE_LOW_100M_SGMII) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 100baseT_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_100MB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_100MB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 100baseT_Full);\n \t}\n@@ -636,14 +637,16 @@ ice_phy_type_to_ethtool(struct net_device *netdev,\n \t phy_types_low & ICE_PHY_TYPE_LOW_1G_SGMII) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 1000baseT_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_1000MB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_1000MB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 1000baseT_Full);\n \t}\n \tif (phy_types_low & ICE_PHY_TYPE_LOW_1000BASE_KX) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 1000baseKX_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_1000MB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_1000MB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 1000baseKX_Full);\n \t}\n@@ -651,14 +654,16 @@ ice_phy_type_to_ethtool(struct net_device *netdev,\n \t phy_types_low & ICE_PHY_TYPE_LOW_1000BASE_LX) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 1000baseX_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_1000MB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_1000MB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 1000baseX_Full);\n \t}\n \tif (phy_types_low & ICE_PHY_TYPE_LOW_2500BASE_T) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 2500baseT_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_2500MB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_2500MB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 2500baseT_Full);\n \t}\n@@ -666,7 +671,8 @@ ice_phy_type_to_ethtool(struct net_device *netdev,\n \t phy_types_low & ICE_PHY_TYPE_LOW_2500BASE_KX) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 2500baseX_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_2500MB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_2500MB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 2500baseX_Full);\n \t}\n@@ -674,7 +680,8 @@ ice_phy_type_to_ethtool(struct net_device *netdev,\n \t phy_types_low & ICE_PHY_TYPE_LOW_5GBASE_KR) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 5000baseT_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_5GB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_5GB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 5000baseT_Full);\n \t}\n@@ -684,28 +691,32 @@ ice_phy_type_to_ethtool(struct net_device *netdev,\n \t phy_types_low & ICE_PHY_TYPE_LOW_10G_SFI_C2C) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 10000baseT_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_10GB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_10GB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 10000baseT_Full);\n \t}\n \tif (phy_types_low & ICE_PHY_TYPE_LOW_10GBASE_KR_CR1) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 10000baseKR_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_10GB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_10GB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 10000baseKR_Full);\n \t}\n \tif (phy_types_low & ICE_PHY_TYPE_LOW_10GBASE_SR) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 10000baseSR_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_10GB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_10GB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 10000baseSR_Full);\n \t}\n \tif (phy_types_low & ICE_PHY_TYPE_LOW_10GBASE_LR) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 10000baseLR_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_10GB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_10GB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 10000baseLR_Full);\n \t}\n@@ -717,7 +728,8 @@ ice_phy_type_to_ethtool(struct net_device *netdev,\n \t phy_types_low & ICE_PHY_TYPE_LOW_25G_AUI_C2C) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 25000baseCR_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_25GB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_25GB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 25000baseCR_Full);\n \t}\n@@ -725,7 +737,8 @@ ice_phy_type_to_ethtool(struct net_device *netdev,\n \t phy_types_low & ICE_PHY_TYPE_LOW_25GBASE_LR) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 25000baseSR_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_25GB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_25GB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 25000baseSR_Full);\n \t}\n@@ -734,14 +747,16 @@ ice_phy_type_to_ethtool(struct net_device *netdev,\n \t phy_types_low & ICE_PHY_TYPE_LOW_25GBASE_KR1) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 25000baseKR_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_25GB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_25GB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 25000baseKR_Full);\n \t}\n \tif (phy_types_low & ICE_PHY_TYPE_LOW_40GBASE_KR4) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 40000baseKR4_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_40GB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_40GB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 40000baseKR4_Full);\n \t}\n@@ -750,21 +765,24 @@ ice_phy_type_to_ethtool(struct net_device *netdev,\n \t phy_types_low & ICE_PHY_TYPE_LOW_40G_XLAUI) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 40000baseCR4_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_40GB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_40GB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 40000baseCR4_Full);\n \t}\n \tif (phy_types_low & ICE_PHY_TYPE_LOW_40GBASE_SR4) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 40000baseSR4_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_40GB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_40GB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 40000baseSR4_Full);\n \t}\n \tif (phy_types_low & ICE_PHY_TYPE_LOW_40GBASE_LR4) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 40000baseLR4_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_40GB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_40GB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 40000baseLR4_Full);\n \t}\n@@ -779,7 +797,8 @@ ice_phy_type_to_ethtool(struct net_device *netdev,\n \t phy_types_low & ICE_PHY_TYPE_LOW_50G_AUI1) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 50000baseCR2_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_50GB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_50GB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 50000baseCR2_Full);\n \t}\n@@ -787,7 +806,8 @@ ice_phy_type_to_ethtool(struct net_device *netdev,\n \t phy_types_low & ICE_PHY_TYPE_LOW_50GBASE_KR_PAM4) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 50000baseKR2_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_50GB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_50GB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 50000baseKR2_Full);\n \t}\n@@ -797,7 +817,8 @@ ice_phy_type_to_ethtool(struct net_device *netdev,\n \t phy_types_low & ICE_PHY_TYPE_LOW_50GBASE_LR) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 50000baseSR2_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_50GB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_50GB)\n \t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t\t 50000baseSR2_Full);\n \t}\n@@ -814,7 +835,8 @@ ice_phy_type_to_ethtool(struct net_device *netdev,\n \t phy_types_high & ICE_PHY_TYPE_HIGH_100G_AUI2) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 100000baseCR4_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_100GB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_100GB)\n \t\t\tneed_add_adv_mode = true;\n \t}\n \tif (need_add_adv_mode) {\n@@ -826,7 +848,8 @@ ice_phy_type_to_ethtool(struct net_device *netdev,\n \t phy_types_low & ICE_PHY_TYPE_LOW_100GBASE_SR2) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 100000baseSR4_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_100GB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_100GB)\n \t\t\tneed_add_adv_mode = true;\n \t}\n \tif (need_add_adv_mode) {\n@@ -838,7 +861,8 @@ ice_phy_type_to_ethtool(struct net_device *netdev,\n \t phy_types_low & ICE_PHY_TYPE_LOW_100GBASE_DR) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 100000baseLR4_ER4_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_100GB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_100GB)\n \t\t\tneed_add_adv_mode = true;\n \t}\n \tif (need_add_adv_mode) {\n@@ -851,7 +875,8 @@ ice_phy_type_to_ethtool(struct net_device *netdev,\n \t phy_types_high & ICE_PHY_TYPE_HIGH_100GBASE_KR2_PAM4) {\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 100000baseKR4_Full);\n-\t\tif (hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_100GB)\n+\t\tif (!hw_link_info->req_speeds ||\n+\t\t hw_link_info->req_speeds & ICE_AQ_LINK_SPEED_100GB)\n \t\t\tneed_add_adv_mode = true;\n \t}\n \tif (need_add_adv_mode)\n", "prefixes": [ "S19", "06/15" ] }