Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1086461/?format=api
{ "id": 1086461, "url": "http://patchwork.ozlabs.org/api/patches/1086461/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190416172439.27908-12-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190416172439.27908-12-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2019-04-16T17:24:35", "name": "[S19,11/15] ice: Use bitfields when possible", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "dc484f096ba319f4cfdd32f871e771bb976bf636", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190416172439.27908-12-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 103107, "url": "http://patchwork.ozlabs.org/api/series/103107/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=103107", "date": "2019-04-16T17:24:38", "name": "Fixes and feature updates for ice", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/103107/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1086461/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1086461/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 44kC1X3z6fz9s3l\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Apr 2019 03:25:20 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id CEDFD24F56;\n\tTue, 16 Apr 2019 17:25:18 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 8bjUFtnTByZe; Tue, 16 Apr 2019 17:25:16 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4ADC222053;\n\tTue, 16 Apr 2019 17:25:16 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 021A41C1626\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Apr 2019 17:25:14 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id F0E2C870B3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Apr 2019 17:25:13 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id kYg7ZwYpPOjH for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Apr 2019 17:25:13 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id DE761870A2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Apr 2019 17:25:12 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t16 Apr 2019 10:25:11 -0700", "from shasta.jf.intel.com ([10.166.244.191])\n\tby orsmga001.jf.intel.com with ESMTP; 16 Apr 2019 10:25:11 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,358,1549958400\"; d=\"scan'208\";a=\"224064174\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 16 Apr 2019 10:24:35 -0700", "Message-Id": "<20190416172439.27908-12-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190416172439.27908-1-anirudh.venkataramanan@intel.com>", "References": "<20190416172439.27908-1-anirudh.venkataramanan@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S19 11/15] ice: Use bitfields when possible", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nWe can use bitfields to store boolean values and when the\nbitfields are next to each other, the compiler will combine them\n(as long as the size holds enough).\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice.h | 10 +++++-----\n drivers/net/ethernet/intel/ice/ice_txrx.h | 2 +-\n drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h | 10 +++++-----\n 3 files changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h\nindex 7958f2bac8da..23e30a69f5fa 100644\n--- a/drivers/net/ethernet/intel/ice/ice.h\n+++ b/drivers/net/ethernet/intel/ice/ice.h\n@@ -277,10 +277,10 @@ struct ice_vsi {\n \tstruct list_head tmp_sync_list;\t\t/* MAC filters to be synced */\n \tstruct list_head tmp_unsync_list;\t/* MAC filters to be unsynced */\n \n-\tu8 irqs_ready;\n-\tu8 current_isup;\t\t /* Sync 'link up' logging */\n-\tu8 stat_offsets_loaded;\n-\tu8 vlan_ena;\n+\tu8 irqs_ready:1;\n+\tu8 current_isup:1;\t\t /* Sync 'link up' logging */\n+\tu8 stat_offsets_loaded:1;\n+\tu8 vlan_ena:1;\n \n \t/* queue information */\n \tu8 tx_mapping_mode;\t\t /* ICE_MAP_MODE_[CONTIG|SCATTER] */\n@@ -384,7 +384,7 @@ struct ice_pf {\n \tstruct ice_hw_port_stats stats;\n \tstruct ice_hw_port_stats stats_prev;\n \tstruct ice_hw hw;\n-\tu8 stat_prev_loaded;\t/* has previous stats been loaded */\n+\tu8 stat_prev_loaded:1; /* has previous stats been loaded */\n #ifdef CONFIG_DCB\n \tu16 dcbx_cap;\n #endif /* CONFIG_DCB */\ndiff --git a/drivers/net/ethernet/intel/ice/ice_txrx.h b/drivers/net/ethernet/intel/ice/ice_txrx.h\nindex 4cff52ffefe0..ec76aba347b9 100644\n--- a/drivers/net/ethernet/intel/ice/ice_txrx.h\n+++ b/drivers/net/ethernet/intel/ice/ice_txrx.h\n@@ -166,7 +166,7 @@ struct ice_ring {\n \tu16 q_index;\t\t\t/* Queue number of ring */\n \tu16 q_handle;\t\t\t/* Queue handle per TC */\n \n-\tu8 ring_active;\t\t\t/* is ring online or not */\n+\tu8 ring_active:1;\t\t/* is ring online or not */\n \n \tu16 count;\t\t\t/* Number of descriptors */\n \tu16 reg_idx;\t\t\t/* HW register index of the ring */\ndiff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h\nindex 3725aea16840..60f024ae281d 100644\n--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h\n+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h\n@@ -55,8 +55,8 @@ struct ice_vf {\n \tstruct virtchnl_version_info vf_ver;\n \tstruct virtchnl_ether_addr dflt_lan_addr;\n \tu16 port_vlan_id;\n-\tu8 pf_set_mac;\t\t\t/* VF MAC address set by VMM admin */\n-\tu8 trusted;\n+\tu8 pf_set_mac:1;\t\t/* VF MAC address set by VMM admin */\n+\tu8 trusted:1;\n \tu16 lan_vsi_idx;\t\t/* index into PF struct */\n \tu16 lan_vsi_num;\t\t/* ID as used by firmware */\n \tu64 num_mdd_events;\t\t/* number of MDD events detected */\n@@ -65,9 +65,9 @@ struct ice_vf {\n \tunsigned long vf_caps;\t\t/* VF's adv. capabilities */\n \tDECLARE_BITMAP(vf_states, ICE_VF_STATES_NBITS);\t/* VF runtime states */\n \tunsigned int tx_rate;\t\t/* Tx bandwidth limit in Mbps */\n-\tu8 link_forced;\n-\tu8 link_up;\t\t\t/* only valid if VF link is forced */\n-\tu8 spoofchk;\n+\tu8 link_forced:1;\n+\tu8 link_up:1;\t\t\t/* only valid if VF link is forced */\n+\tu8 spoofchk:1;\n \tu16 num_mac;\n \tu16 num_vlan;\n \tu16 num_vf_qs;\t\t\t/* num of queue configured per VF */\n", "prefixes": [ "S19", "11/15" ] }