Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1086452/?format=api
{ "id": 1086452, "url": "http://patchwork.ozlabs.org/api/patches/1086452/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190416172128.27184-15-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190416172128.27184-15-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2019-04-16T17:21:27", "name": "[S18,14/15] ice: Disable sniffing VF traffic on PF", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "79f0d0ce4d8ee6e7d7d1daa588ca7f22eea185fd", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190416172128.27184-15-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 103105, "url": "http://patchwork.ozlabs.org/api/series/103105/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=103105", "date": "2019-04-16T17:21:13", "name": "Fixes and feature updates for ice", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/103105/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1086452/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1086452/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 44kBy25ZN3z9s00\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Apr 2019 03:22:18 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id B20B225D07;\n\tTue, 16 Apr 2019 17:22:16 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id AdtN5H9wQ4YB; Tue, 16 Apr 2019 17:22:12 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4A60625C66;\n\tTue, 16 Apr 2019 17:22:10 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 41FA41C1626\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Apr 2019 17:22:06 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3F51686DB4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Apr 2019 17:22:06 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Hzw5LJPCB35l for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Apr 2019 17:22:05 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id C86F2870DF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Apr 2019 17:22:02 +0000 (UTC)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t16 Apr 2019 10:22:02 -0700", "from shasta.jf.intel.com ([10.166.244.191])\n\tby fmsmga006.fm.intel.com with ESMTP; 16 Apr 2019 10:22:02 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,358,1549958400\"; d=\"scan'208\";a=\"338040584\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 16 Apr 2019 10:21:27 -0700", "Message-Id": "<20190416172128.27184-15-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190416172128.27184-1-anirudh.venkataramanan@intel.com>", "References": "<20190416172128.27184-1-anirudh.venkataramanan@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S18 14/15] ice: Disable sniffing VF\n\ttraffic on PF", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Michal Swiatkowski <michal.swiatkowski@intel.com>\n\nDelete code that add default Tx rule on PF. With this rule PF can see\nTx VF traffic that should go outside. For traffic from VF to another\nVF default Tx rule on PF doesn't apply because of lower priority than\nVF mac rule.\n\nWith this change on PF in promisc mode we can see only Rx traffic that\ndoesn't match any other rule (mac etc.). We can't see Tx traffic from\nother VSI.\n\nSigned-off-by: Michal Swiatkowski <michal.swiatkowski@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_main.c | 24 ++---------------------\n 1 file changed, 2 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex aa832d9b2458..7843abf4d44d 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -317,42 +317,22 @@ static int ice_vsi_sync_fltr(struct ice_vsi *vsi)\n \t test_bit(ICE_VSI_FLAG_PROMISC_CHANGED, vsi->flags)) {\n \t\tclear_bit(ICE_VSI_FLAG_PROMISC_CHANGED, vsi->flags);\n \t\tif (vsi->current_netdev_flags & IFF_PROMISC) {\n-\t\t\t/* Apply Tx filter rule to get traffic from VMs */\n-\t\t\tstatus = ice_cfg_dflt_vsi(hw, vsi->idx, true,\n-\t\t\t\t\t\t ICE_FLTR_TX);\n-\t\t\tif (status) {\n-\t\t\t\tnetdev_err(netdev, \"Error setting default VSI %i tx rule\\n\",\n-\t\t\t\t\t vsi->vsi_num);\n-\t\t\t\tvsi->current_netdev_flags &= ~IFF_PROMISC;\n-\t\t\t\terr = -EIO;\n-\t\t\t\tgoto out_promisc;\n-\t\t\t}\n \t\t\t/* Apply Rx filter rule to get traffic from wire */\n \t\t\tstatus = ice_cfg_dflt_vsi(hw, vsi->idx, true,\n \t\t\t\t\t\t ICE_FLTR_RX);\n \t\t\tif (status) {\n-\t\t\t\tnetdev_err(netdev, \"Error setting default VSI %i rx rule\\n\",\n+\t\t\t\tnetdev_err(netdev, \"Error setting default VSI %i Rx rule\\n\",\n \t\t\t\t\t vsi->vsi_num);\n \t\t\t\tvsi->current_netdev_flags &= ~IFF_PROMISC;\n \t\t\t\terr = -EIO;\n \t\t\t\tgoto out_promisc;\n \t\t\t}\n \t\t} else {\n-\t\t\t/* Clear Tx filter rule to stop traffic from VMs */\n-\t\t\tstatus = ice_cfg_dflt_vsi(hw, vsi->idx, false,\n-\t\t\t\t\t\t ICE_FLTR_TX);\n-\t\t\tif (status) {\n-\t\t\t\tnetdev_err(netdev, \"Error clearing default VSI %i tx rule\\n\",\n-\t\t\t\t\t vsi->vsi_num);\n-\t\t\t\tvsi->current_netdev_flags |= IFF_PROMISC;\n-\t\t\t\terr = -EIO;\n-\t\t\t\tgoto out_promisc;\n-\t\t\t}\n \t\t\t/* Clear Rx filter to remove traffic from wire */\n \t\t\tstatus = ice_cfg_dflt_vsi(hw, vsi->idx, false,\n \t\t\t\t\t\t ICE_FLTR_RX);\n \t\t\tif (status) {\n-\t\t\t\tnetdev_err(netdev, \"Error clearing default VSI %i rx rule\\n\",\n+\t\t\t\tnetdev_err(netdev, \"Error clearing default VSI %i Rx rule\\n\",\n \t\t\t\t\t vsi->vsi_num);\n \t\t\t\tvsi->current_netdev_flags |= IFF_PROMISC;\n \t\t\t\terr = -EIO;\n", "prefixes": [ "S18", "14/15" ] }