Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1086451/?format=api
{ "id": 1086451, "url": "http://patchwork.ozlabs.org/api/patches/1086451/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190416172128.27184-11-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190416172128.27184-11-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2019-04-16T17:21:23", "name": "[S18,10/15] ice: Separate if conditions for ice_set_features()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3c2d2f6c4506cc4a6367a51708b0516b06d81f24", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190416172128.27184-11-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 103105, "url": "http://patchwork.ozlabs.org/api/series/103105/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=103105", "date": "2019-04-16T17:21:13", "name": "Fixes and feature updates for ice", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/103105/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1086451/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1086451/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 44kBy20lGJz9s55\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Apr 2019 03:22:18 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A4A328409C;\n\tTue, 16 Apr 2019 17:22:15 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id kgN8dLOJQHLP; Tue, 16 Apr 2019 17:22:10 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 93C14870B6;\n\tTue, 16 Apr 2019 17:22:10 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9325F1BF28D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Apr 2019 17:22:06 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8DC5D86DB4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Apr 2019 17:22:06 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id L3LRp6+Ux4v4 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Apr 2019 17:22:04 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 8314E870B3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 16 Apr 2019 17:22:02 +0000 (UTC)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t16 Apr 2019 10:22:02 -0700", "from shasta.jf.intel.com ([10.166.244.191])\n\tby fmsmga006.fm.intel.com with ESMTP; 16 Apr 2019 10:22:02 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,358,1549958400\"; d=\"scan'208\";a=\"338040575\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 16 Apr 2019 10:21:23 -0700", "Message-Id": "<20190416172128.27184-11-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190416172128.27184-1-anirudh.venkataramanan@intel.com>", "References": "<20190416172128.27184-1-anirudh.venkataramanan@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S18 10/15] ice: Separate if conditions for\n\tice_set_features()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Tony Nguyen <anthony.l.nguyen@intel.com>\n\nSet features can have multiple features turned on|off in a single\ncall. Grouping these all in an if/else means after one condition\nis met, other conditions/features will not be evaluated. Break\nthe if/else statements by feature to ensure all features will be\nhandled properly.\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_main.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 2352b4129a62..aa832d9b2458 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -2873,6 +2873,9 @@ ice_set_features(struct net_device *netdev, netdev_features_t features)\n \tstruct ice_vsi *vsi = np->vsi;\n \tint ret = 0;\n \n+\t/* Multiple features can be changed in one call so keep features in\n+\t * separate if/else statements to guarantee each feature is checked\n+\t */\n \tif (features & NETIF_F_RXHASH && !(netdev->features & NETIF_F_RXHASH))\n \t\tret = ice_vsi_manage_rss_lut(vsi, true);\n \telse if (!(features & NETIF_F_RXHASH) &&\n@@ -2885,8 +2888,9 @@ ice_set_features(struct net_device *netdev, netdev_features_t features)\n \telse if (!(features & NETIF_F_HW_VLAN_CTAG_RX) &&\n \t\t (netdev->features & NETIF_F_HW_VLAN_CTAG_RX))\n \t\tret = ice_vsi_manage_vlan_stripping(vsi, false);\n-\telse if ((features & NETIF_F_HW_VLAN_CTAG_TX) &&\n-\t\t !(netdev->features & NETIF_F_HW_VLAN_CTAG_TX))\n+\n+\tif ((features & NETIF_F_HW_VLAN_CTAG_TX) &&\n+\t !(netdev->features & NETIF_F_HW_VLAN_CTAG_TX))\n \t\tret = ice_vsi_manage_vlan_insertion(vsi);\n \telse if (!(features & NETIF_F_HW_VLAN_CTAG_TX) &&\n \t\t (netdev->features & NETIF_F_HW_VLAN_CTAG_TX))\n", "prefixes": [ "S18", "10/15" ] }