Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1085966/?format=api
{ "id": 1085966, "url": "http://patchwork.ozlabs.org/api/patches/1085966/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190415214307.74674-1-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190415214307.74674-1-alice.michael@intel.com>", "list_archive_url": null, "date": "2019-04-15T21:43:07", "name": "[next] i40e: Fix of memory leak and integer truncation in i40e_virtchnl.c", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "612083a2419587442fc21966736d4d234ab1daa7", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190415214307.74674-1-alice.michael@intel.com/mbox/", "series": [ { "id": 102905, "url": "http://patchwork.ozlabs.org/api/series/102905/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=102905", "date": "2019-04-15T21:43:07", "name": "[next] i40e: Fix of memory leak and integer truncation in i40e_virtchnl.c", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/102905/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1085966/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1085966/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 44jhr15vC5z9s55\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 16 Apr 2019 07:45:19 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id A6EFA23491;\n\tMon, 15 Apr 2019 21:45:16 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ZTl6PrtJtGDw; Mon, 15 Apr 2019 21:45:11 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 48C8A233D8;\n\tMon, 15 Apr 2019 21:45:11 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 435D61BF39C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Apr 2019 21:45:10 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3F32085C98\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Apr 2019 21:45:10 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id LNKSG8jSG5gH for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Apr 2019 21:45:09 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 57A1285C92\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Apr 2019 21:45:09 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t15 Apr 2019 14:45:08 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby orsmga001.jf.intel.com with ESMTP; 15 Apr 2019 14:45:08 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,355,1549958400\"; d=\"scan'208\";a=\"223798955\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@osuosl.org, intel-wired-lan@lists.osuosl.org", "Date": "Mon, 15 Apr 2019 14:43:07 -0700", "Message-Id": "<20190415214307.74674-1-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.19.2", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH] i40e: Fix of memory leak and integer\n\ttruncation in i40e_virtchnl.c", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Martyna Szapar <martyna.szapar@intel.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Martyna Szapar <martyna.szapar@intel.com>\n\nFixed possible memory leak in i40e_vc_add_cloud_filter function:\ncfilter is being allocated and in some error conditions\nthe function returns without freeing the memory.\n\nFix of integer truncation from u16 (type of queue_id value) to u8\nwhen calling i40e_vc_isvalid_queue_id function.\n\nSigned-off-by: Martyna Szapar <martyna.szapar@intel.com>\n---\n .../net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 16 ++++++++++------\n 1 file changed, 10 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 6a812eeaba8d..ebe18276cea1 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -181,7 +181,7 @@ static inline bool i40e_vc_isvalid_vsi_id(struct i40e_vf *vf, u16 vsi_id)\n * check for the valid queue id\n **/\n static inline bool i40e_vc_isvalid_queue_id(struct i40e_vf *vf, u16 vsi_id,\n-\t\t\t\t\t u8 qid)\n+\t\t\t\t\t u16 qid)\n {\n \tstruct i40e_pf *pf = vf->pf;\n \tstruct i40e_vsi *vsi = i40e_find_vsi_from_id(pf, vsi_id);\n@@ -3421,7 +3421,7 @@ static int i40e_vc_add_cloud_filter(struct i40e_vf *vf, u8 *msg)\n \n \tif (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states)) {\n \t\taq_ret = I40E_ERR_PARAM;\n-\t\tgoto err;\n+\t\tgoto err_out;\n \t}\n \n \tif (!vf->adq_enabled) {\n@@ -3429,7 +3429,7 @@ static int i40e_vc_add_cloud_filter(struct i40e_vf *vf, u8 *msg)\n \t\t\t \"VF %d: ADq is not enabled, can't apply cloud filter\\n\",\n \t\t\t vf->vf_id);\n \t\taq_ret = I40E_ERR_PARAM;\n-\t\tgoto err;\n+\t\tgoto err_out;\n \t}\n \n \tif (i40e_validate_cloud_filter(vf, vcf)) {\n@@ -3437,7 +3437,7 @@ static int i40e_vc_add_cloud_filter(struct i40e_vf *vf, u8 *msg)\n \t\t\t \"VF %d: Invalid input/s, can't apply cloud filter\\n\",\n \t\t\t vf->vf_id);\n \t\taq_ret = I40E_ERR_PARAM;\n-\t\tgoto err;\n+\t\tgoto err_out;\n \t}\n \n \tcfilter = kzalloc(sizeof(*cfilter), GFP_KERNEL);\n@@ -3498,13 +3498,17 @@ static int i40e_vc_add_cloud_filter(struct i40e_vf *vf, u8 *msg)\n \t\t\t\"VF %d: Failed to add cloud filter, err %s aq_err %s\\n\",\n \t\t\tvf->vf_id, i40e_stat_str(&pf->hw, ret),\n \t\t\ti40e_aq_str(&pf->hw, pf->hw.aq.asq_last_status));\n-\t\tgoto err;\n+\t\tgoto err_free;\n \t}\n \n \tINIT_HLIST_NODE(&cfilter->cloud_node);\n \thlist_add_head(&cfilter->cloud_node, &vf->cloud_filter_list);\n+\t/* release the pointer passing it to the collection */\n+\tcfilter = NULL;\n \tvf->num_cloud_filters++;\n-err:\n+err_free:\n+\tkfree(cfilter);\n+err_out:\n \treturn i40e_vc_send_resp_to_vf(vf, VIRTCHNL_OP_ADD_CLOUD_FILTER,\n \t\t\t\t aq_ret);\n }\n", "prefixes": [ "next" ] }