Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107739/?format=api
{ "id": 107739, "url": "http://patchwork.ozlabs.org/api/patches/107739/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/CAMe9rOp0AwAacAXf1Evk9RYos+u4GbQS6gwUznegKoPaxUxRYQ@mail.gmail.com/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<CAMe9rOp0AwAacAXf1Evk9RYos+u4GbQS6gwUznegKoPaxUxRYQ@mail.gmail.com>", "list_archive_url": null, "date": "2011-08-01T13:51:49", "name": "ARM fixed-point support [5.5/6]: argument & return padding for libcalls", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "bef21f3062140ac978644a8cb77aa7c324ce2924", "submitter": { "id": 4387, "url": "http://patchwork.ozlabs.org/api/people/4387/?format=api", "name": "H.J. Lu", "email": "hjl.tools@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/CAMe9rOp0AwAacAXf1Evk9RYos+u4GbQS6gwUznegKoPaxUxRYQ@mail.gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/107739/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/107739/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-return-298564-incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "mailing list gcc-patches@gcc.gnu.org" ], "Received": [ "from sourceware.org (server1.sourceware.org [209.132.180.131])\n\tby ozlabs.org (Postfix) with SMTP id 4FC4AB7091\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 1 Aug 2011 23:52:16 +1000 (EST)", "(qmail 21732 invoked by alias); 1 Aug 2011 13:52:07 -0000", "(qmail 21715 invoked by uid 22791); 1 Aug 2011 13:52:05 -0000", "from mail-qy0-f175.google.com (HELO mail-qy0-f175.google.com)\n\t(209.85.216.175) by sourceware.org (qpsmtpd/0.43rc1) with\n\tESMTP; Mon, 01 Aug 2011 13:51:50 +0000", "by qyk30 with SMTP id 30so1006995qyk.20 for\n\t<gcc-patches@gcc.gnu.org>; Mon, 01 Aug 2011 06:51:49 -0700 (PDT)", "by 10.229.81.198 with SMTP id y6mr3315315qck.8.1312206709795;\n\tMon, 01 Aug 2011 06:51:49 -0700 (PDT)", "by 10.229.177.164 with HTTP; Mon, 1 Aug 2011 06:51:49 -0700 (PDT)" ], "X-SWARE-Spam-Status": "No, hits=-2.4 required=5.0\ttests=AWL, BAYES_00,\n\tDKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_LOW", "X-Spam-Check-By": "sourceware.org", "MIME-Version": "1.0", "In-Reply-To": "<CAMe9rOoD81nY2tFx536i=Q6z+g=S7PnvvS1SOOkvqpQsKwuFaQ@mail.gmail.com>", "References": "<20110526175634.4bcab9b5@rex.config>\t<CAMe9rOoD81nY2tFx536i=Q6z+g=S7PnvvS1SOOkvqpQsKwuFaQ@mail.gmail.com>", "Date": "Mon, 1 Aug 2011 06:51:49 -0700", "Message-ID": "<CAMe9rOp0AwAacAXf1Evk9RYos+u4GbQS6gwUznegKoPaxUxRYQ@mail.gmail.com>", "Subject": "Re: [PATCH] ARM fixed-point support [5.5/6]: argument & return\n\tpadding for libcalls", "From": "\"H.J. Lu\" <hjl.tools@gmail.com>", "To": "Julian Brown <julian@codesourcery.com>", "Cc": "gcc-patches@gcc.gnu.org", "Content-Type": "text/plain; charset=ISO-8859-1", "Content-Transfer-Encoding": "quoted-printable", "X-IsSubscribed": "yes", "Mailing-List": "contact gcc-patches-help@gcc.gnu.org; run by ezmlm", "Precedence": "bulk", "List-Id": "<gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org>", "List-Archive": "<http://gcc.gnu.org/ml/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-help@gcc.gnu.org>", "Sender": "gcc-patches-owner@gcc.gnu.org" }, "content": "On Mon, Aug 1, 2011 at 6:38 AM, H.J. Lu <hjl.tools@gmail.com> wrote:\n> On Thu, May 26, 2011 at 9:56 AM, Julian Brown <julian@codesourcery.com> wrote:\n>> This patch allows padding to be specified per-target for libcalls. This\n>> hasn't been traditionally important, because libcalls haven't accepted\n>> quantities which might need padding, but that's no longer true with the\n>> new(-ish) fixed-point support helper functions.\n>>\n>> Tested (alongside other fixed-point support patches) with cross to ARM\n>> EABI in both big & little-endian mode (the target-specific part is to\n>> avoid a behaviour change for half-float types on ARM). OK to apply?\n>>\n>> Thanks,\n>>\n>> Julian\n>>\n>> ChangeLog\n>>\n>> gcc/\n>> * calls.c (emit_library_call_value_1): Support padding for libcall\n>> arguments and return values.\n>> * config/arm/arm.c (arm_pad_arg_upward): Pad half-float values\n>> downwards in big-endian mode.\n>\n> This breaks bootstrap on Linux/x86:\n>\n> http://gcc.gnu.org/ml/gcc-regression/2011-08/msg00007.html\n>\n> ../../src-trunk/gcc/calls.c: In function 'rtx_def*\n> emit_library_call_value_1(int, rtx, rtx, libcall_type, machine_mode,\n> int, __va_list_tag*)':\n> ../../src-trunk/gcc/calls.c:3832:11: error: unused variable 'size'\n> [-Werror=unused-variable]\n> cc1plus: all warnings being treated as errors\n>\n> make[6]: *** [calls.o] Error 1\n>\n\nI am testing this patch.", "diff": "diff --git a/gcc/calls.c b/gcc/calls.c\nindex 7ad30b4..c4f8b46 100644\n--- a/gcc/calls.c\n+++ b/gcc/calls.c\n@@ -3829,7 +3829,9 @@ emit_library_call_value_1 (int retval, rtx orgfun, rtx val\nue,\n rtx val = argvec[argnum].value;\n rtx reg = argvec[argnum].reg;\n int partial = argvec[argnum].partial;\n+#ifdef BLOCK_REG_PADDING\n int size = 0;\n+#endif\n\n /* Handle calls that pass values in multiple non-contiguous\n", "prefixes": [] }