Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1070298/?format=api
{ "id": 1070298, "url": "http://patchwork.ozlabs.org/api/patches/1070298/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190329233850.29630-6-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190329233850.29630-6-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2019-03-29T23:38:50", "name": "[6/6] iavf: iavf_client: use struct_size() helper", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9aadfdbdf89e599b90ee0e458789b739fd4086e4", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190329233850.29630-6-jeffrey.t.kirsher@intel.com/mbox/", "series": [ { "id": 100037, "url": "http://patchwork.ozlabs.org/api/series/100037/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=100037", "date": "2019-03-29T23:38:48", "name": "[1/6] igb: mark expected switch fall-through", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/100037/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1070298/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1070298/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 44WJ6m5FX9z9sQq\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 30 Mar 2019 10:37:04 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 222AB2EE62;\n\tFri, 29 Mar 2019 23:37:03 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VyKOEG+75S5J; Fri, 29 Mar 2019 23:36:59 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4E5922E4D2;\n\tFri, 29 Mar 2019 23:36:58 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id E9DC31BF23F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Mar 2019 23:36:56 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id E744C87D05\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Mar 2019 23:36:56 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YwgoYbIFtK2u for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Mar 2019 23:36:56 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 4052287E7B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Mar 2019 23:36:56 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Mar 2019 16:36:55 -0700", "from jtkirshe-desk1.jf.intel.com ([134.134.177.96])\n\tby orsmga001.jf.intel.com with ESMTP; 29 Mar 2019 16:36:55 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,286,1549958400\"; d=\"scan'208\";a=\"218897605\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 29 Mar 2019 16:38:50 -0700", "Message-Id": "<20190329233850.29630-6-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190329233850.29630-1-jeffrey.t.kirsher@intel.com>", "References": "<20190329233850.29630-1-jeffrey.t.kirsher@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 6/6] iavf: iavf_client: use struct_size()\n\thelper", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: \"Gustavo A. R. Silva\" <gustavo@embeddedor.com>\n\nOne of the more common cases of allocation size calculations is finding\nthe size of a structure that has a zero-sized array at the end, along\nwith memory for some number of elements for that array. For example:\n\nstruct foo {\n int stuff;\n struct boo entry[];\n};\n\nsize = sizeof(struct foo) + count * sizeof(struct boo);\n\nInstead of leaving these open-coded and prone to type mistakes, we can\nnow use the new struct_size() helper:\n\nsize = struct_size(instance, entry, count);\n\nThis code was detected with the help of Coccinelle.\n\nSigned-off-by: \"Gustavo A. R. Silva\" <gustavo@embeddedor.com>\n---\n drivers/net/ethernet/intel/iavf/iavf_client.c | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/iavf/iavf_client.c b/drivers/net/ethernet/intel/iavf/iavf_client.c\nindex aea45364fd1c..ab9db7e9f09d 100644\n--- a/drivers/net/ethernet/intel/iavf/iavf_client.c\n+++ b/drivers/net/ethernet/intel/iavf/iavf_client.c\n@@ -451,7 +451,7 @@ static int iavf_client_setup_qvlist(struct i40e_info *ldev,\n \tstruct i40e_qv_info *qv_info;\n \tiavf_status err;\n \tu32 v_idx, i;\n-\tu32 msg_size;\n+\tsize_t msg_size;\n \n \tif (adapter->aq_required)\n \t\treturn -EAGAIN;\n@@ -469,9 +469,8 @@ static int iavf_client_setup_qvlist(struct i40e_info *ldev,\n \t}\n \n \tv_qvlist_info = (struct virtchnl_iwarp_qvlist_info *)qvlist_info;\n-\tmsg_size = sizeof(struct virtchnl_iwarp_qvlist_info) +\n-\t\t\t(sizeof(struct virtchnl_iwarp_qv_info) *\n-\t\t\t(v_qvlist_info->num_vectors - 1));\n+\tmsg_size = struct_size(v_qvlist_info, qv_info,\n+\t\t\t v_qvlist_info->num_vectors - 1);\n \n \tadapter->client_pending |= BIT(VIRTCHNL_OP_CONFIG_IWARP_IRQ_MAP);\n \terr = iavf_aq_send_msg_to_pf(&adapter->hw,\n", "prefixes": [ "6/6" ] }