Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1070225/?format=api
{ "id": 1070225, "url": "http://patchwork.ozlabs.org/api/patches/1070225/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190329220840.51187-11-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190329220840.51187-11-alice.michael@intel.com>", "list_archive_url": null, "date": "2019-03-29T22:08:40", "name": "[next,S4,11/11] i40e: Revert ShadowRAM checksum calculation change", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ce24be4530a8bec4cf8251f5d5a5c94543f3fd9d", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190329220840.51187-11-alice.michael@intel.com/mbox/", "series": [ { "id": 100029, "url": "http://patchwork.ozlabs.org/api/series/100029/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=100029", "date": "2019-03-29T22:08:31", "name": "[next,S4,01/11] i40e: VF's promiscuous attribute is not kept", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/100029/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1070225/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1070225/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 44WGCf1wqqz9sPc\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 30 Mar 2019 09:11:10 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 950E484763;\n\tFri, 29 Mar 2019 22:11:08 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HnPAJrQ+wK5J; Fri, 29 Mar 2019 22:11:05 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id EE1C084E38;\n\tFri, 29 Mar 2019 22:11:03 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 02A2F1BF98E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Mar 2019 22:10:32 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0021224CC1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Mar 2019 22:10:32 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5mG3lfgT+pOT for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Mar 2019 22:10:28 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby silver.osuosl.org (Postfix) with ESMTPS id BC21A2FCEC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Mar 2019 22:10:27 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Mar 2019 15:10:27 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby fmsmga001.fm.intel.com with ESMTP; 29 Mar 2019 15:10:26 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,286,1549958400\"; d=\"scan'208\";a=\"159698911\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Fri, 29 Mar 2019 15:08:40 -0700", "Message-Id": "<20190329220840.51187-11-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20190329220840.51187-1-alice.michael@intel.com>", "References": "<20190329220840.51187-1-alice.michael@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S4 11/11] i40e: Revert ShadowRAM\n\tchecksum calculation change", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Maciej Paczkowski <maciej.paczkowski@intel.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Maciej Paczkowski <maciej.paczkowski@intel.com>\n\nThe reason of this revert is unexpected issue found in NVM Update tool\nduring NVM image downgrade. The implementation is no longer needed\nsince the QV tools are already aware of new FW double ShadowRAM dump\nmechanism.\n\nThis patch reverts ShadowRAM checksum calculation change introduced in\ncommit 9d12f0c4e436 (\"i40e: Revert ShadowRAM checksum calculation change\")\n\nSigned-off-by: Maciej Paczkowski <maciej.paczkowski@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_nvm.c | 28 +++-------------------\n 1 file changed, 3 insertions(+), 25 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_nvm.c b/drivers/net/ethernet/intel/i40e/i40e_nvm.c\nindex ee89779a9a6f..c508b75c3c09 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_nvm.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_nvm.c\n@@ -574,36 +574,14 @@ static i40e_status i40e_calc_nvm_checksum(struct i40e_hw *hw,\n i40e_status i40e_update_nvm_checksum(struct i40e_hw *hw)\n {\n \ti40e_status ret_code;\n-\tu16 checksum, checksum_sr;\n+\tu16 checksum;\n \t__le16 le_sum;\n \n \tret_code = i40e_calc_nvm_checksum(hw, &checksum);\n-\tif (ret_code)\n-\t\treturn ret_code;\n-\n \tle_sum = cpu_to_le16(checksum);\n-\tret_code = i40e_write_nvm_aq(hw, 0x00, I40E_SR_SW_CHECKSUM_WORD,\n-\t\t\t\t 1, &le_sum, true);\n-\tif (ret_code)\n-\t\treturn ret_code;\n-\n-\t/* Due to changes in FW the SW is required to perform double SR-dump\n-\t * in some cases. SR-dump is the process when internal shadow RAM is\n-\t * dumped into flash bank. It is triggered by setting \"last_command\"\n-\t * argument in i40e_write_nvm_aq function call.\n-\t * Since FW 1.8 we need to calculate SR checksum again and update it\n-\t * in flash if it is not equal to previously computed checksum.\n-\t * This situation would occur only in FW >= 1.8\n-\t */\n-\tret_code = i40e_calc_nvm_checksum(hw, &checksum_sr);\n-\tif (ret_code)\n-\t\treturn ret_code;\n-\tif (checksum_sr != checksum) {\n-\t\tle_sum = cpu_to_le16(checksum_sr);\n-\t\tret_code = i40e_write_nvm_aq(hw, 0x00,\n-\t\t\t\t\t I40E_SR_SW_CHECKSUM_WORD,\n+\tif (!ret_code)\n+\t\tret_code = i40e_write_nvm_aq(hw, 0x00, I40E_SR_SW_CHECKSUM_WORD,\n \t\t\t\t\t 1, &le_sum, true);\n-\t}\n \n \treturn ret_code;\n }\n", "prefixes": [ "next", "S4", "11/11" ] }