Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1070221/?format=api
{ "id": 1070221, "url": "http://patchwork.ozlabs.org/api/patches/1070221/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190329220840.51187-1-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190329220840.51187-1-alice.michael@intel.com>", "list_archive_url": null, "date": "2019-03-29T22:08:30", "name": "[next,S4,01/11] i40e: VF's promiscuous attribute is not kept", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "35dbed2dc8f6feeff1896c10561dd182ecc60ac4", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190329220840.51187-1-alice.michael@intel.com/mbox/", "series": [ { "id": 100029, "url": "http://patchwork.ozlabs.org/api/series/100029/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=100029", "date": "2019-03-29T22:08:31", "name": "[next,S4,01/11] i40e: VF's promiscuous attribute is not kept", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/100029/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1070221/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1070221/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 44WGCZ6ZgRz9sPv\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 30 Mar 2019 09:11:06 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 24F432FCEC;\n\tFri, 29 Mar 2019 22:11:05 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id gdzB-EzLmXDw; Fri, 29 Mar 2019 22:11:03 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 9165B2F94F;\n\tFri, 29 Mar 2019 22:11:03 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 48C281BF995\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Mar 2019 22:10:31 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 468B82E46D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Mar 2019 22:10:31 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id u2-he7Hos2ox for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Mar 2019 22:10:27 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 142BE24CC1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Mar 2019 22:10:27 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Mar 2019 15:10:26 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby fmsmga001.fm.intel.com with ESMTP; 29 Mar 2019 15:10:26 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,286,1549958400\"; d=\"scan'208\";a=\"159698880\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Fri, 29 Mar 2019 15:08:30 -0700", "Message-Id": "<20190329220840.51187-1-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.19.2", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S4 01/11] i40e: VF's promiscuous\n\tattribute is not kept", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Grzegorz Siwik <grzegorz.siwik@intel.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Grzegorz Siwik <grzegorz.siwik@intel.com>\n\nThis patch fixes a bug where the promiscuous mode was not being\nkept when the VF switched to a new VLAN.\nNow we are config two times a promiscuous mode when we switch VLAN.\nWithout this change when we change VF VLAN we still receive\nall the packets from previous VLAN and only unicast from new VLAN.\n\nSigned-off-by: Grzegorz Siwik <grzegorz.siwik@intel.com>\n---\n .../ethernet/intel/i40e/i40e_virtchnl_pf.c | 23 +++++++++++++++++++\n 1 file changed, 23 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 8a6fb9c03955..00345bbf68ec 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -4016,6 +4016,7 @@ int i40e_ndo_set_vf_port_vlan(struct net_device *netdev, int vf_id,\n {\n \tu16 vlanprio = vlan_id | (qos << I40E_VLAN_PRIORITY_SHIFT);\n \tstruct i40e_netdev_priv *np = netdev_priv(netdev);\n+\tbool allmulti = false, alluni = false;\n \tstruct i40e_pf *pf = np->vsi->back;\n \tstruct i40e_vsi *vsi;\n \tstruct i40e_vf *vf;\n@@ -4100,6 +4101,15 @@ int i40e_ndo_set_vf_port_vlan(struct net_device *netdev, int vf_id,\n \t}\n \n \tspin_unlock_bh(&vsi->mac_filter_hash_lock);\n+\n+\t/* disable promisc modes in case they were enabled */\n+\tret = i40e_config_vf_promiscuous_mode(vf, vf->lan_vsi_id,\n+\t\t\t\t\t allmulti, alluni);\n+\tif (ret) {\n+\t\tdev_err(&pf->pdev->dev, \"Unable to config VF promiscuous mode\\n\");\n+\t\tgoto error_pvid;\n+\t}\n+\n \tif (vlan_id || qos)\n \t\tret = i40e_vsi_add_pvid(vsi, vlanprio);\n \telse\n@@ -4126,6 +4136,12 @@ int i40e_ndo_set_vf_port_vlan(struct net_device *netdev, int vf_id,\n \n \tspin_unlock_bh(&vsi->mac_filter_hash_lock);\n \n+\tif (test_bit(I40E_VF_STATE_UC_PROMISC, &vf->vf_states))\n+\t\talluni = true;\n+\n+\tif (test_bit(I40E_VF_STATE_MC_PROMISC, &vf->vf_states))\n+\t\tallmulti = true;\n+\n \t/* Schedule the worker thread to take care of applying changes */\n \ti40e_service_event_schedule(vsi->back);\n \n@@ -4138,6 +4154,13 @@ int i40e_ndo_set_vf_port_vlan(struct net_device *netdev, int vf_id,\n \t * default LAN MAC address.\n \t */\n \tvf->port_vlan_id = le16_to_cpu(vsi->info.pvid);\n+\n+\tret = i40e_config_vf_promiscuous_mode(vf, vsi->id, allmulti, alluni);\n+\tif (ret) {\n+\t\tdev_err(&pf->pdev->dev, \"Unable to config vf promiscuous mode\\n\");\n+\t\tgoto error_pvid;\n+\t}\n+\n \tret = 0;\n \n error_pvid:\n", "prefixes": [ "next", "S4", "01/11" ] }