Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1060081/?format=api
{ "id": 1060081, "url": "http://patchwork.ozlabs.org/api/patches/1060081/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190321124535.18311-1-sassmann@kpanic.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190321124535.18311-1-sassmann@kpanic.de>", "list_archive_url": null, "date": "2019-03-21T12:45:35", "name": "i40e: fix WoL support check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e329a3723980e74f13a75073ef835746c88c3bac", "submitter": { "id": 7508, "url": "http://patchwork.ozlabs.org/api/people/7508/?format=api", "name": "Stefan Assmann", "email": "sassmann@kpanic.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190321124535.18311-1-sassmann@kpanic.de/mbox/", "series": [ { "id": 98437, "url": "http://patchwork.ozlabs.org/api/series/98437/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=98437", "date": "2019-03-21T12:45:35", "name": "i40e: fix WoL support check", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/98437/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1060081/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1060081/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=kpanic.de" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 44Q62z5KpMz9sQv\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 21 Mar 2019 23:45:45 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id A078D22CCE;\n\tThu, 21 Mar 2019 12:45:42 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id q4n+swDhbP82; Thu, 21 Mar 2019 12:45:41 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 3E05C22855;\n\tThu, 21 Mar 2019 12:45:41 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id B53571BF2C9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 21 Mar 2019 12:45:40 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B197585D8E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 21 Mar 2019 12:45:40 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jjwX74cN3WtW for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 21 Mar 2019 12:45:40 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id F05BA855FE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 21 Mar 2019 12:45:39 +0000 (UTC)", "from smtp.corp.redhat.com\n\t(int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DCA8A7D7D0;\n\tThu, 21 Mar 2019 12:45:38 +0000 (UTC)", "from p50.redhat.com (ovpn-116-65.ams2.redhat.com [10.36.116.65])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 85F611001E8A;\n\tThu, 21 Mar 2019 12:45:37 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": [ "from auto-whitelisted by SQLgrey-1.7.6", "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]); Thu, 21 Mar 2019 12:45:39 +0000 (UTC)" ], "From": "Stefan Assmann <sassmann@kpanic.de>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 21 Mar 2019 13:45:35 +0100", "Message-Id": "<20190321124535.18311-1-sassmann@kpanic.de>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "Subject": "[Intel-wired-lan] [PATCH] i40e: fix WoL support check", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, davem@davemloft.net, sassmann@kpanic.de", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The current check for WoL on i40e is broken. Code comment says only\nmagic packet is supported, so only check for that.\n\nFixes: 540a152da762 (i40e/ixgbe/igb: fail on new WoL flag setting WAKE_MAGICSECURE)\n\nSigned-off-by: Stefan Assmann <sassmann@kpanic.de>\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 4c885801fa26..7874d0ec7fb0 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -2573,8 +2573,7 @@ static int i40e_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)\n \t\treturn -EOPNOTSUPP;\n \n \t/* only magic packet is supported */\n-\tif (wol->wolopts && (wol->wolopts != WAKE_MAGIC)\n-\t\t\t | (wol->wolopts != WAKE_FILTER))\n+\tif (wol->wolopts & ~WAKE_MAGIC)\n \t\treturn -EOPNOTSUPP;\n \n \t/* is this a new value? */\n", "prefixes": [] }