Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1057126/?format=api
{ "id": 1057126, "url": "http://patchwork.ozlabs.org/api/patches/1057126/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190315084515.22983-1-ivecera@redhat.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190315084515.22983-1-ivecera@redhat.com>", "list_archive_url": null, "date": "2019-03-15T08:45:15", "name": "[net] ixgbe: fix mdio bus registration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a3be275d974f2a73e517ac1290b3e4906f8e48f1", "submitter": { "id": 262, "url": "http://patchwork.ozlabs.org/api/people/262/?format=api", "name": "Ivan Vecera", "email": "ivecera@redhat.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190315084515.22983-1-ivecera@redhat.com/mbox/", "series": [ { "id": 97396, "url": "http://patchwork.ozlabs.org/api/series/97396/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=97396", "date": "2019-03-15T08:45:15", "name": "[net] ixgbe: fix mdio bus registration", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/97396/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1057126/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1057126/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=redhat.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 44LWYl00tBz9s3l\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 16 Mar 2019 03:41:28 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 504A130FCB;\n\tFri, 15 Mar 2019 16:41:26 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1dIGeMhnwHr7; Fri, 15 Mar 2019 16:41:23 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id B8E0430FBC;\n\tFri, 15 Mar 2019 16:41:23 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id DB62E1BF3AE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 15 Mar 2019 08:45:18 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D765B882B4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 15 Mar 2019 08:45:18 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id aXZI5joSlpOs for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 15 Mar 2019 08:45:18 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 59C56882B2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 15 Mar 2019 08:45:18 +0000 (UTC)", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id CBC7330832EA;\n\tFri, 15 Mar 2019 08:45:17 +0000 (UTC)", "from ceranb.redhat.com (ovpn-204-143.brq.redhat.com\n\t[10.40.204.143])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 4536C60BF4;\n\tFri, 15 Mar 2019 08:45:16 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": [ "domain auto-whitelisted by SQLgrey-1.7.6", "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.44]); Fri, 15 Mar 2019 08:45:17 +0000 (UTC)" ], "From": "Ivan Vecera <ivecera@redhat.com>", "To": "netdev@vger.kernel.org", "Date": "Fri, 15 Mar 2019 09:45:15 +0100", "Message-Id": "<20190315084515.22983-1-ivecera@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Mailman-Approved-At": "Fri, 15 Mar 2019 16:41:22 +0000", "Subject": "[Intel-wired-lan] [PATCH net] ixgbe: fix mdio bus registration", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "open list <linux-kernel@vger.kernel.org>,\n\t\"moderated list:INTEL ETHERNET DRIVERS\"\n\t<intel-wired-lan@lists.osuosl.org>, \n\t\"David S. Miller\" <davem@davemloft.net>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The ixgbe ignores errors returned from mdiobus_register() and leaves\nadapter->mii_bus non-NULL and MDIO bus state as MDIOBUS_ALLOCATED.\nThis triggers a BUG from mdiobus_unregister() during ixgbe_remove() call.\n\nFixes: 8fa10ef01260 (\"ixgbe: register a mdiobus\")\nSigned-off-by: Ivan Vecera <ivecera@redhat.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 16 +++++++++-------\n 1 file changed, 9 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\nindex cc4907f9ff02..2fb97967961c 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\n@@ -905,13 +905,12 @@ s32 ixgbe_mii_bus_init(struct ixgbe_hw *hw)\n \tstruct pci_dev *pdev = adapter->pdev;\n \tstruct device *dev = &adapter->netdev->dev;\n \tstruct mii_bus *bus;\n+\tint err = -ENODEV;\n \n-\tadapter->mii_bus = devm_mdiobus_alloc(dev);\n-\tif (!adapter->mii_bus)\n+\tbus = devm_mdiobus_alloc(dev);\n+\tif (!bus)\n \t\treturn -ENOMEM;\n \n-\tbus = adapter->mii_bus;\n-\n \tswitch (hw->device_id) {\n \t/* C3000 SoCs */\n \tcase IXGBE_DEV_ID_X550EM_A_KR:\n@@ -949,12 +948,15 @@ s32 ixgbe_mii_bus_init(struct ixgbe_hw *hw)\n \t */\n \thw->phy.mdio.mode_support = MDIO_SUPPORTS_C45 | MDIO_SUPPORTS_C22;\n \n-\treturn mdiobus_register(bus);\n+\terr = mdiobus_register(bus);\n+\tif (!err) {\n+\t\tadapter->mii_bus = bus;\n+\t\treturn 0;\n+\t}\n \n ixgbe_no_mii_bus:\n \tdevm_mdiobus_free(dev, bus);\n-\tadapter->mii_bus = NULL;\n-\treturn -ENODEV;\n+\treturn err;\n }\n \n /**\n", "prefixes": [ "net" ] }