Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1054149/?format=api
{ "id": 1054149, "url": "http://patchwork.ozlabs.org/api/patches/1054149/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190311061732.19064-1-kjlu@umn.edu/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190311061732.19064-1-kjlu@umn.edu>", "list_archive_url": null, "date": "2019-03-11T06:17:32", "name": "net: fm10k: fix a potential NULL pointer dereference", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "42f3bd8777018c10de80c5039f136809baa725c9", "submitter": { "id": 75603, "url": "http://patchwork.ozlabs.org/api/people/75603/?format=api", "name": "Kangjie Lu", "email": "kjlu@umn.edu" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190311061732.19064-1-kjlu@umn.edu/mbox/", "series": [ { "id": 96367, "url": "http://patchwork.ozlabs.org/api/series/96367/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=96367", "date": "2019-03-11T06:17:32", "name": "net: fm10k: fix a potential NULL pointer dereference", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/96367/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1054149/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1054149/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=umn.edu", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=umn.edu header.i=@umn.edu header.b=\"lhqMw+3U\";\n\tdkim-atps=neutral" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 44Hnvy12btz9s55\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 11 Mar 2019 17:17:47 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 52E92233A6;\n\tMon, 11 Mar 2019 06:17:44 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 56sTviR9eZCA; Mon, 11 Mar 2019 06:17:42 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 6DB10232F2;\n\tMon, 11 Mar 2019 06:17:42 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id C07A31BF86D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Mar 2019 06:17:41 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id BB335232F2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Mar 2019 06:17:41 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 9mtzQwQu2grV for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Mar 2019 06:17:41 +0000 (UTC)", "from mta-p7.oit.umn.edu (mta-p7.oit.umn.edu [134.84.196.207])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 1FB512150A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Mar 2019 06:17:41 +0000 (UTC)", "from localhost (unknown [127.0.0.1])\n\tby mta-p7.oit.umn.edu (Postfix) with ESMTP id 74AFD975\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Mar 2019 06:17:40 +0000 (UTC)", "from mta-p7.oit.umn.edu ([127.0.0.1])\n\tby localhost (mta-p7.oit.umn.edu [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id IoC52o6Ks_AH for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Mar 2019 01:17:40 -0500 (CDT)", "from mail-io1-f72.google.com (mail-io1-f72.google.com\n\t[209.85.166.72])\n\t(using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby mta-p7.oit.umn.edu (Postfix) with ESMTPS id 4B269945\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 11 Mar 2019 01:17:40 -0500 (CDT)", "by mail-io1-f72.google.com with SMTP id p143so3467175iod.19\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 10 Mar 2019 23:17:40 -0700 (PDT)", "from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63])\n\tby smtp.gmail.com with ESMTPSA id\n\ta8sm340203iol.35.2019.03.10.23.17.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 10 Mar 2019 23:17:37 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org", "amavisd-new at umn.edu" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google;\n\th=from:to:cc:subject:date:message-id;\n\tbh=xN31h4x5ZALT9IMTYpU74QFk79bWQWoed0tpkI2F+nc=;\n\tb=lhqMw+3UXwVFwXl0FlWnFiknCdFKbcPn4bcDr9SYzwLToP6jmqIEfxEiyZ6bV8mczk\n\trRsFOtuu7QkDsene56c5AF8QdnUpjEfdWexasd+JH1MiwgcgtjUhVxtf0q9gSBXmbOdj\n\tXYrJcrjedis1BVvaw4yEfM/bVC/uqO04lhmqs8j5HjgmoxfS67xCIIUHKnFqdDU9+WSf\n\t2uucKhjndeHHAxoCsora0ix1u6xO6T1YkYa4nUz7DiR1f6a59XLpOupROj9NNuiJDa2e\n\tCAHGSyrFIpN0wejAq+85md7xBVBGZBN2X9Q+kFT0s0//Wrn6dyXHk6ZXZNOwsLfIlOKO\n\tLW9A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=xN31h4x5ZALT9IMTYpU74QFk79bWQWoed0tpkI2F+nc=;\n\tb=iLWZU/xvsO06DDSyHDav9PxKfLZz2w/4cYMkGHmWTPQjoX/b+oBwuPo08QaqWNtsnw\n\t1ztagPldQFgbeDG8EdvNG9hzPVwV6JzSqNomww9B5s9Is5z0jHYWwTc/S06XUWjBhIR8\n\tIoBfZtkdf6TlBL2mjzjpKDbZKRV9i5WMImhkgJarnytWznFZip2cf1MFhc53dVudfw5t\n\t8WgzAmotqjsKqls42O0J9sXsYUSLYsWjMbhRdU07hWfFk5lNBAYEaL3Sf+in6qoghl8q\n\tconu/0izsetocoEnfQUiH2glFCKR8hG7eaFyZdVjbT+zrTpN3SYzN2oOYP9K3+Z1hP0r\n\t27Pg==", "X-Gm-Message-State": "APjAAAVCugN26LHE9dJeRrhFyyKvkyCYKP+UJAZibczQua38mzPtKPZh\n\t+7ufVtCPXe9rdqG6lT09WKJY8yu3mgnsmmejKuMqmXDGAcu6ZEVaaAbbF0kTGFH2XWu8QEjBM1T\n\t77IY6AHacKMFp0/OnRfUChrjZ/qQ4TutGYw==", "X-Received": [ "by 2002:a6b:ee1a:: with SMTP id\n\ti26mr1570080ioh.201.1552285058642; \n\tSun, 10 Mar 2019 23:17:38 -0700 (PDT)", "by 2002:a6b:ee1a:: with SMTP id\n\ti26mr1570072ioh.201.1552285058445; \n\tSun, 10 Mar 2019 23:17:38 -0700 (PDT)" ], "X-Google-Smtp-Source": "APXvYqx5swzk1OVg/XV75LuXGqzphQmq0xi2cmDiKpqytwW0qY3fSutv0qCaNUh11Pq+BuZlsqzpRQ==", "From": "Kangjie Lu <kjlu@umn.edu>", "To": "kjlu@umn.edu", "Date": "Mon, 11 Mar 2019 01:17:32 -0500", "Message-Id": "<20190311061732.19064-1-kjlu@umn.edu>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[Intel-wired-lan] [PATCH] net: fm10k: fix a potential NULL pointer\n\tdereference", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org, pakki001@umn.edu,\n\t\"David S. Miller\" <davem@davemloft.net>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "In case alloc_workqueue fails, the fix returns -ENOMEM to avoid\npotential NULL pointer dereference.\n\nSigned-off-by: Kangjie Lu <kjlu@umn.edu>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_main.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\nindex 5a0419421511..215f232674f1 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n@@ -41,6 +41,8 @@ static int __init fm10k_init_module(void)\n \t/* create driver workqueue */\n \tfm10k_workqueue = alloc_workqueue(\"%s\", WQ_MEM_RECLAIM, 0,\n \t\t\t\t\t fm10k_driver_name);\n+\tif (unlikely(!fm10k_workqueue))\n+\t\treturn -ENOMEM;\n \n \tfm10k_dbg_init();\n \n", "prefixes": [] }