Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1052742/?format=api
{ "id": 1052742, "url": "http://patchwork.ozlabs.org/api/patches/1052742/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190307093014.3293229-1-arnd@arndb.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190307093014.3293229-1-arnd@arndb.de>", "list_archive_url": null, "date": "2019-03-07T09:29:57", "name": "igc: remove unused igc_priv_flags_strings array", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "1657fdc45885087313ce683d78bbc6fd97b6224c", "submitter": { "id": 30, "url": "http://patchwork.ozlabs.org/api/people/30/?format=api", "name": "Arnd Bergmann", "email": "arnd@arndb.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190307093014.3293229-1-arnd@arndb.de/mbox/", "series": [ { "id": 95859, "url": "http://patchwork.ozlabs.org/api/series/95859/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=95859", "date": "2019-03-07T09:29:57", "name": "igc: remove unused igc_priv_flags_strings array", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/95859/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1052742/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1052742/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=arndb.de" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 44FQNM4TxPz9sMQ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 7 Mar 2019 20:30:43 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 6F370228B4;\n\tThu, 7 Mar 2019 09:30:41 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id TLsjyq0cj27y; Thu, 7 Mar 2019 09:30:39 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7CEC422274;\n\tThu, 7 Mar 2019 09:30:39 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 006FB1BF2A2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Mar 2019 09:30:38 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id F09D084462\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Mar 2019 09:30:38 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 23-0FX54B-Ko for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Mar 2019 09:30:38 +0000 (UTC)", "from mout.kundenserver.de (mout.kundenserver.de [212.227.126.187])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id CF467840B5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Mar 2019 09:30:37 +0000 (UTC)", "from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de\n\t(mreue011 [212.227.15.129]) with ESMTPA (Nemesis) id\n\t1Mq33i-1ggE2u0AMs-00n6Hn; Thu, 07 Mar 2019 10:30:22 +0100" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "From": "Arnd Bergmann <arnd@arndb.de>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\t\"David S. Miller\" <davem@davemloft.net>", "Date": "Thu, 7 Mar 2019 10:29:57 +0100", "Message-Id": "<20190307093014.3293229-1-arnd@arndb.de>", "X-Mailer": "git-send-email 2.20.0", "MIME-Version": "1.0", "X-Provags-ID": "V03:K1:N3mvzSfNDVeTkiwt0IdLZpwokV6/9jud1nD98nGRX1EUJEqVPGy\n\tD2FdE55gGo8FUMjX06Bg4VZA9E54mdlygtYJUcS7FI6C/ZB1B7u0MjZegnvMLTGa5WpGGMj\n\tnd/QizUeLx5QaBZmbTJIfXJevyB6Ro4KkAPCFyr4jFi7x7eNzOKB4sWax3vGxfiVt+AfnJI\n\tXvWa8gjtxBb8xjlcZfm7A==", "X-UI-Out-Filterresults": "notjunk:1; V03:K0:Lli521qOlkE=:PQHUQR4B0W6D5kxGg4KDai\n\tCaPaQ7rmfvijXUDElKJIpX6wIA3PMiPIyYHn6DIafsclM4zWtO6+MctLLywc11FiY+v11EXKq\n\tp4HYL3npnjPKIyYj4z6AIzgTyEy6YhjfoNtnu1FLfcgY7sGHn5OLff0gLXejiGbg/2mry0Mzh\n\tGrK8h3cn2iHBCqROZ2mPmPtsyA/g/NotVV/ZRci8zG+0r625RaxBdeyMa34TL3+vo8mikE8sB\n\t7mDDi3rnV7QMyRDHWZmgPkvNzyx9788YsmmRJu4cUhFuLrwFEVzocaBudfWuB3VefxXNqwS3p\n\t/YoNsZas5TvgS8pllNKmEn61M3fZ+tka7qLEZCw5TIfV/Ysz0Gdtb9MwvRSh37bb6A7qlqDQp\n\tAHoCJv9foPLiiSZSehr2IVOi1wmoy6MV99YtVuV3QAwQIYQ8qqwIEdFqdY8wsS2/gHGss6lgO\n\t5p3EQyOTIsVfpHv8aSzsN+zOtRAypuamLs7s5rDjvCQqUCUmfoYymt9SHFwGPFFyE68IAI7Qu\n\tKgQjY0hj3MyfmuGJMyvibNpR1o0MgUvVDj5Yvq4w0N+8WDQtu8ljqbvMx0ZwP6OWIipYhH320\n\t86rBAdheiNp/nCgUpgUtxwgYUdsPqOmxFGlOO1kHYeSCKW4RiuaoMdoch7khTsVPjNsRLabN8\n\tXPNGA7j50MKYFHD7ksAoTqapOqNcNN5kSsZDABXU44esuKPEApCQmFaqR6aGVJQjUyqfEY50R\n\t1oR/kQiOUYuEOTFefrgNCp5QovGoM0Iq0ORYLQ==", "Subject": "[Intel-wired-lan] [PATCH] igc: remove unused igc_priv_flags_strings\n\tarray", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Arnd Bergmann <arnd@arndb.de>, netdev@vger.kernel.org,\n\tNick Desaulniers <ndesaulniers@google.com>,\n\tlinux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "clang points out that the igc_priv_flags_strings[] array is never\nreferenced, aside from being used for calculating its length:\n\ndrivers/net/ethernet/intel/igc/igc_ethtool.c:9:19: error: variable 'igc_priv_flags_strings' is not needed and will not\n be emitted [-Werror,-Wunneeded-internal-declaration]\nstatic const char igc_priv_flags_strings[][ETH_GSTRING_LEN] = {\n\nA similar array is present in several other intel ethernet drivers,\nbut all the others use it in their .get_strings() callback, which\nigc does not implement (yet).\n\nProbably it should be implemented, but as I have no way of testing\nit, this does the simpler alternative of removing the array to\nget rid of the warning.\n\nFixes: 8c5ad0dae93c (\"igc: Add ethtool support\")\nSigned-off-by: Arnd Bergmann <arnd@arndb.de>\n---\n drivers/net/ethernet/intel/igc/igc_ethtool.c | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c\nindex eff37a6c0afa..9e352c2be644 100644\n--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c\n+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c\n@@ -6,12 +6,9 @@\n \n #include \"igc.h\"\n \n-static const char igc_priv_flags_strings[][ETH_GSTRING_LEN] = {\n #define IGC_PRIV_FLAGS_LEGACY_RX\tBIT(0)\n-\t\"legacy-rx\",\n-};\n \n-#define IGC_PRIV_FLAGS_STR_LEN ARRAY_SIZE(igc_priv_flags_strings)\n+#define IGC_PRIV_FLAGS_STR_LEN\t\t1\n \n static void igc_get_drvinfo(struct net_device *netdev,\n \t\t\t struct ethtool_drvinfo *drvinfo)\n", "prefixes": [] }