Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1049857/?format=api
{ "id": 1049857, "url": "http://patchwork.ozlabs.org/api/patches/1049857/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190228232603.32156-8-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190228232603.32156-8-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2019-02-28T23:25:53", "name": "[S17,07/17] ice: Use ice_for_each_q_vector macro where possible", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0ce78979e2e5d3df6ac5fbbc7f2aa06151464bb6", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190228232603.32156-8-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 94829, "url": "http://patchwork.ozlabs.org/api/series/94829/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=94829", "date": "2019-02-28T23:25:46", "name": "Implementation updates for ice", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/94829/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1049857/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1049857/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 449TFh240fz9sCJ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 1 Mar 2019 10:26:16 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 804DA8601B;\n\tThu, 28 Feb 2019 23:26:14 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3w3RgQWVntEY; Thu, 28 Feb 2019 23:26:10 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4A03781AE7;\n\tThu, 28 Feb 2019 23:26:10 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8F3B91BF3EA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 28 Feb 2019 23:26:06 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8C97B21505\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 28 Feb 2019 23:26:06 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DuoNW71ZxM40 for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 28 Feb 2019 23:26:05 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby silver.osuosl.org (Postfix) with ESMTPS id A224B2076E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 28 Feb 2019 23:26:05 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Feb 2019 15:26:04 -0800", "from shasta.jf.intel.com ([10.166.241.11])\n\tby FMSMGA003.fm.intel.com with ESMTP; 28 Feb 2019 15:26:04 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,425,1544515200\"; d=\"scan'208\";a=\"137127996\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 28 Feb 2019 15:25:53 -0800", "Message-Id": "<20190228232603.32156-8-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.14.5", "In-Reply-To": "<20190228232603.32156-1-anirudh.venkataramanan@intel.com>", "References": "<20190228232603.32156-1-anirudh.venkataramanan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH S17 07/17] ice: Use ice_for_each_q_vector\n\tmacro where possible", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Brett Creeley <brett.creeley@intel.com>\n\nThere are many places in the code where we do the following:\n\nfor (i = 0; i < vsi->num_q_vectors; i++)\n\nInstead use the macro mentioned in the commit title:\n\nice_for_each_q_vector(vsi, i)\n\nSigned-off-by: Brett Creeley <brett.creeley@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_lib.c | 6 +++---\n drivers/net/ethernet/intel/ice/ice_main.c | 10 +++++-----\n 2 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c\nindex 57b2873a6123..e75d8c4fadc6 100644\n--- a/drivers/net/ethernet/intel/ice/ice_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_lib.c\n@@ -1054,7 +1054,7 @@ void ice_vsi_free_q_vectors(struct ice_vsi *vsi)\n {\n \tint v_idx;\n \n-\tfor (v_idx = 0; v_idx < vsi->num_q_vectors; v_idx++)\n+\tice_for_each_q_vector(vsi, v_idx)\n \t\tice_free_q_vector(vsi, v_idx);\n }\n \n@@ -2409,7 +2409,7 @@ void ice_vsi_free_irq(struct ice_vsi *vsi)\n \t\t\treturn;\n \n \t\tvsi->irqs_ready = false;\n-\t\tfor (i = 0; i < vsi->num_q_vectors; i++) {\n+\t\tice_for_each_q_vector(vsi, i) {\n \t\t\tu16 vector = i + base;\n \t\t\tint irq_num;\n \n@@ -2633,7 +2633,7 @@ void ice_vsi_dis_irq(struct ice_vsi *vsi)\n \t\t\twr32(hw, GLINT_DYN_CTL(i), 0);\n \n \t\tice_flush(hw);\n-\t\tfor (i = 0; i < vsi->num_q_vectors; i++)\n+\t\tice_for_each_q_vector(vsi, i)\n \t\t\tsynchronize_irq(pf->msix_entries[i + base].vector);\n \t}\n }\ndiff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 94105f0a0b48..260ab69c2c00 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -1338,7 +1338,7 @@ static int ice_vsi_ena_irq(struct ice_vsi *vsi)\n \tif (test_bit(ICE_FLAG_MSIX_ENA, pf->flags)) {\n \t\tint i;\n \n-\t\tfor (i = 0; i < vsi->num_q_vectors; i++)\n+\t\tice_for_each_q_vector(vsi, i)\n \t\t\tice_irq_dynamic_ena(hw, vsi, vsi->q_vectors[i]);\n \t}\n \n@@ -1705,7 +1705,7 @@ void ice_napi_del(struct ice_vsi *vsi)\n \tif (!vsi->netdev)\n \t\treturn;\n \n-\tfor (v_idx = 0; v_idx < vsi->num_q_vectors; v_idx++)\n+\tice_for_each_q_vector(vsi, v_idx)\n \t\tnetif_napi_del(&vsi->q_vectors[v_idx]->napi);\n }\n \n@@ -1724,7 +1724,7 @@ static void ice_napi_add(struct ice_vsi *vsi)\n \tif (!vsi->netdev)\n \t\treturn;\n \n-\tfor (v_idx = 0; v_idx < vsi->num_q_vectors; v_idx++)\n+\tice_for_each_q_vector(vsi, v_idx)\n \t\tnetif_napi_add(vsi->netdev, &vsi->q_vectors[v_idx]->napi,\n \t\t\t ice_napi_poll, NAPI_POLL_WEIGHT);\n }\n@@ -2960,7 +2960,7 @@ static void ice_napi_enable_all(struct ice_vsi *vsi)\n \tif (!vsi->netdev)\n \t\treturn;\n \n-\tfor (q_idx = 0; q_idx < vsi->num_q_vectors; q_idx++) {\n+\tice_for_each_q_vector(vsi, q_idx) {\n \t\tstruct ice_q_vector *q_vector = vsi->q_vectors[q_idx];\n \n \t\tif (q_vector->rx.ring || q_vector->tx.ring)\n@@ -3334,7 +3334,7 @@ static void ice_napi_disable_all(struct ice_vsi *vsi)\n \tif (!vsi->netdev)\n \t\treturn;\n \n-\tfor (q_idx = 0; q_idx < vsi->num_q_vectors; q_idx++) {\n+\tice_for_each_q_vector(vsi, q_idx) {\n \t\tstruct ice_q_vector *q_vector = vsi->q_vectors[q_idx];\n \n \t\tif (q_vector->rx.ring || q_vector->tx.ring)\n", "prefixes": [ "S17", "07/17" ] }