Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1049856/?format=api
{ "id": 1049856, "url": "http://patchwork.ozlabs.org/api/patches/1049856/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190228232603.32156-13-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190228232603.32156-13-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2019-02-28T23:25:58", "name": "[S17,12/17] ice: Remove runtime change of PFINT_OICR_ENA register", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "92110b9e5438b6e122ac3e7a24645dd2d7039e5b", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190228232603.32156-13-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 94829, "url": "http://patchwork.ozlabs.org/api/series/94829/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=94829", "date": "2019-02-28T23:25:46", "name": "Implementation updates for ice", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/94829/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1049856/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1049856/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 449TFg6mp7z9s70\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 1 Mar 2019 10:26:15 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 9319B87A1D;\n\tThu, 28 Feb 2019 23:26:14 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id C5WlBpu93CsJ; Thu, 28 Feb 2019 23:26:11 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4211F877E2;\n\tThu, 28 Feb 2019 23:26:11 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1FE141BF964\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 28 Feb 2019 23:26:07 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1D2128126A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 28 Feb 2019 23:26:07 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jL75kYNIhYls for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 28 Feb 2019 23:26:05 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id CFA0B813E6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 28 Feb 2019 23:26:05 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Feb 2019 15:26:05 -0800", "from shasta.jf.intel.com ([10.166.241.11])\n\tby FMSMGA003.fm.intel.com with ESMTP; 28 Feb 2019 15:26:05 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,425,1544515200\"; d=\"scan'208\";a=\"137128002\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 28 Feb 2019 15:25:58 -0800", "Message-Id": "<20190228232603.32156-13-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.14.5", "In-Reply-To": "<20190228232603.32156-1-anirudh.venkataramanan@intel.com>", "References": "<20190228232603.32156-1-anirudh.venkataramanan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH S17 12/17] ice: Remove runtime change of\n\tPFINT_OICR_ENA register", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Md Fahad Iqbal Polash <md.fahad.iqbal.polash@intel.com>\n\nRuntime change of PFINT_OICR_ENA register is unnecessary.\nThe handlers should always clear the atomic bit for each\ntask as they start, because it will make sure that any late\ninterrupt will either 1) re-set the bit, or 2) be handled\ndirectly in the \"already running\" task handler.\n\nSigned-off-by: Md Fahad Iqbal Polash <md.fahad.iqbal.polash@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_main.c | 13 ++-----------\n drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 13 +------------\n 2 files changed, 3 insertions(+), 23 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 260ab69c2c00..94b2aa6b4c3d 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -1096,7 +1096,7 @@ static void ice_handle_mdd_event(struct ice_pf *pf)\n \tu32 reg;\n \tint i;\n \n-\tif (!test_bit(__ICE_MDD_EVENT_PENDING, pf->state))\n+\tif (!test_and_clear_bit(__ICE_MDD_EVENT_PENDING, pf->state))\n \t\treturn;\n \n \t/* find what triggered the MDD event */\n@@ -1229,12 +1229,6 @@ static void ice_handle_mdd_event(struct ice_pf *pf)\n \t\t}\n \t}\n \n-\t/* re-enable MDD interrupt cause */\n-\tclear_bit(__ICE_MDD_EVENT_PENDING, pf->state);\n-\treg = rd32(hw, PFINT_OICR_ENA);\n-\treg |= PFINT_OICR_MAL_DETECT_M;\n-\twr32(hw, PFINT_OICR_ENA, reg);\n-\tice_flush(hw);\n }\n \n /**\n@@ -1523,7 +1517,7 @@ static irqreturn_t ice_misc_intr(int __always_unused irq, void *data)\n \t\t\trd32(hw, PFHMC_ERRORDATA));\n \t}\n \n-\t/* Report and mask off any remaining unexpected interrupts */\n+\t/* Report any remaining unexpected interrupts */\n \toicr &= ena_mask;\n \tif (oicr) {\n \t\tdev_dbg(&pf->pdev->dev, \"unhandled interrupt oicr=0x%08x\\n\",\n@@ -1537,12 +1531,9 @@ static irqreturn_t ice_misc_intr(int __always_unused irq, void *data)\n \t\t\tset_bit(__ICE_PFR_REQ, pf->state);\n \t\t\tice_service_task_schedule(pf);\n \t\t}\n-\t\tena_mask &= ~oicr;\n \t}\n \tret = IRQ_HANDLED;\n \n-\t/* re-enable interrupt causes that are not handled during this pass */\n-\twr32(hw, PFINT_OICR_ENA, ena_mask);\n \tif (!test_bit(__ICE_DOWN, pf->state)) {\n \t\tice_service_task_schedule(pf);\n \t\tice_irq_dynamic_ena(hw, NULL, NULL);\ndiff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\nindex f52f0fc52f46..abc958788267 100644\n--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n@@ -1273,21 +1273,10 @@ void ice_process_vflr_event(struct ice_pf *pf)\n \tint vf_id;\n \tu32 reg;\n \n-\tif (!test_bit(__ICE_VFLR_EVENT_PENDING, pf->state) ||\n+\tif (!test_and_clear_bit(__ICE_VFLR_EVENT_PENDING, pf->state) ||\n \t !pf->num_alloc_vfs)\n \t\treturn;\n \n-\t/* Re-enable the VFLR interrupt cause here, before looking for which\n-\t * VF got reset. Otherwise, if another VF gets a reset while the\n-\t * first one is being processed, that interrupt will be lost, and\n-\t * that VF will be stuck in reset forever.\n-\t */\n-\treg = rd32(hw, PFINT_OICR_ENA);\n-\treg |= PFINT_OICR_VFLR_M;\n-\twr32(hw, PFINT_OICR_ENA, reg);\n-\tice_flush(hw);\n-\n-\tclear_bit(__ICE_VFLR_EVENT_PENDING, pf->state);\n \tfor (vf_id = 0; vf_id < pf->num_alloc_vfs; vf_id++) {\n \t\tstruct ice_vf *vf = &pf->vf[vf_id];\n \t\tu32 reg_idx, bit_idx;\n", "prefixes": [ "S17", "12/17" ] }