Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1049651/?format=api
{ "id": 1049651, "url": "http://patchwork.ozlabs.org/api/patches/1049651/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190228175255.54754-9-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190228175255.54754-9-alice.michael@intel.com>", "list_archive_url": null, "date": "2019-02-28T17:52:55", "name": "[next,S3,9/9] i40e: fix misleading message about promisc setting on un-trusted VF", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "64554e6fd3f33a90b137da1cc412c05455f4657d", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190228175255.54754-9-alice.michael@intel.com/mbox/", "series": [ { "id": 94754, "url": "http://patchwork.ozlabs.org/api/series/94754/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=94754", "date": "2019-02-28T17:52:49", "name": "[next,S3,1/9] i40e: Fix for allowing too many MDD events on VF", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/94754/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1049651/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1049651/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 449Kth59zNz9s4V\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 1 Mar 2019 04:54:20 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 56DF226FB8;\n\tThu, 28 Feb 2019 17:54:18 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DnY5vHBroo6F; Thu, 28 Feb 2019 17:54:12 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id A7E392272C;\n\tThu, 28 Feb 2019 17:54:12 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id F40071BF410\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 28 Feb 2019 17:54:09 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id ED64D214EB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 28 Feb 2019 17:54:09 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id LlrZacNKQkvr for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 28 Feb 2019 17:54:08 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 8C11B22E20\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 28 Feb 2019 17:54:07 +0000 (UTC)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Feb 2019 09:54:07 -0800", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby fmsmga005.fm.intel.com with ESMTP; 28 Feb 2019 09:54:07 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,423,1544515200\"; d=\"scan'208\";a=\"324246242\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Thu, 28 Feb 2019 09:52:55 -0800", "Message-Id": "<20190228175255.54754-9-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20190228175255.54754-1-alice.michael@intel.com>", "References": "<20190228175255.54754-1-alice.michael@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S3 9/9] i40e: fix misleading message\n\tabout promisc setting on un-trusted VF", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>\n\nA refactor of the i40e_vc_config_promiscuous_mode_msg function moved\nthe check for un-trusted VF into another function. We have to lie to\nan un-trusted VF that its request to set promiscuous mode is\nsuccessful even when it is not because we don't want the VF to find\nout its trust status this way. With the refactor, we were running into\na case where even though we were not setting promiscuous mode for an\nun-trusted VF, we still printed a misleading message that it was\nsuccessful.\n\nThis patch fixes that by ensuring that a success message is printed\non the host side only when the promiscuous mode change has been\nsuccessful.\n\nSigned-off-by: Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>\n---\n .../ethernet/intel/i40e/i40e_virtchnl_pf.c | 28 +++++++++++--------\n 1 file changed, 16 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 925ca880bea3..8a6fb9c03955 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -1112,15 +1112,6 @@ static i40e_status i40e_config_vf_promiscuous_mode(struct i40e_vf *vf,\n \tif (!i40e_vc_isvalid_vsi_id(vf, vsi_id) || !vsi)\n \t\treturn I40E_ERR_PARAM;\n \n-\tif (!test_bit(I40E_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps) &&\n-\t (allmulti || alluni)) {\n-\t\tdev_err(&pf->pdev->dev,\n-\t\t\t\"Unprivileged VF %d is attempting to configure promiscuous mode\\n\",\n-\t\t\tvf->vf_id);\n-\t\t/* Lie to the VF on purpose. */\n-\t\treturn 0;\n-\t}\n-\n \tif (vf->port_vlan_id) {\n \t\taq_ret = i40e_aq_set_vsi_mc_promisc_on_vlan(hw, vsi->seid,\n \t\t\t\t\t\t\t allmulti,\n@@ -1997,8 +1988,21 @@ static int i40e_vc_config_promiscuous_mode_msg(struct i40e_vf *vf, u8 *msg)\n \tbool allmulti = false;\n \tbool alluni = false;\n \n-\tif (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states))\n-\t\treturn I40E_ERR_PARAM;\n+\tif (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states)) {\n+\t\taq_ret = I40E_ERR_PARAM;\n+\t\tgoto err_out;\n+\t}\n+\tif (!test_bit(I40E_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps)) {\n+\t\tdev_err(&pf->pdev->dev,\n+\t\t\t\"Unprivileged VF %d is attempting to configure promiscuous mode\\n\",\n+\t\t\tvf->vf_id);\n+\n+\t\t/* Lie to the VF on purpose, because this is an error we can\n+\t\t * ignore. Unprivileged VF is not a virtual channel error.\n+\t\t */\n+\t\taq_ret = 0;\n+\t\tgoto err_out;\n+\t}\n \n \t/* Multicast promiscuous handling*/\n \tif (info->flags & FLAG_VF_MULTICAST_PROMISC)\n@@ -2032,7 +2036,7 @@ static int i40e_vc_config_promiscuous_mode_msg(struct i40e_vf *vf, u8 *msg)\n \t\t\tclear_bit(I40E_VF_STATE_UC_PROMISC, &vf->vf_states);\n \t\t}\n \t}\n-\n+err_out:\n \t/* send the response to the VF */\n \treturn i40e_vc_send_resp_to_vf(vf,\n \t\t\t\t VIRTCHNL_OP_CONFIG_PROMISCUOUS_MODE,\n", "prefixes": [ "next", "S3", "9/9" ] }