Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1049646/?format=api
{ "id": 1049646, "url": "http://patchwork.ozlabs.org/api/patches/1049646/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190228175255.54754-7-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190228175255.54754-7-alice.michael@intel.com>", "list_archive_url": null, "date": "2019-02-28T17:52:53", "name": "[next,S3,7/9] i40e: remove out-of-range comparisions in i40e_validate_cloud_filter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8b931b453a8cc9f6cb4711f5afc8785727d5a872", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190228175255.54754-7-alice.michael@intel.com/mbox/", "series": [ { "id": 94754, "url": "http://patchwork.ozlabs.org/api/series/94754/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=94754", "date": "2019-02-28T17:52:49", "name": "[next,S3,1/9] i40e: Fix for allowing too many MDD events on VF", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/94754/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1049646/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1049646/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 449Ktb4DzTz9s9L\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 1 Mar 2019 04:54:14 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 20F2587D5E;\n\tThu, 28 Feb 2019 17:54:12 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id JUPHj5KN8biB; Thu, 28 Feb 2019 17:54:10 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1E1C087D28;\n\tThu, 28 Feb 2019 17:54:10 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 06E8D1BF410\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 28 Feb 2019 17:54:09 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 01A4E21539\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 28 Feb 2019 17:54:09 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OmIwvO1lPYwa for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 28 Feb 2019 17:54:08 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 5AED022CCE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 28 Feb 2019 17:54:07 +0000 (UTC)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Feb 2019 09:54:06 -0800", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby fmsmga005.fm.intel.com with ESMTP; 28 Feb 2019 09:54:06 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,423,1544515200\"; d=\"scan'208\";a=\"324246235\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Thu, 28 Feb 2019 09:52:53 -0800", "Message-Id": "<20190228175255.54754-7-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20190228175255.54754-1-alice.michael@intel.com>", "References": "<20190228175255.54754-1-alice.michael@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S3 7/9] i40e: remove out-of-range\n\tcomparisions in i40e_validate_cloud_filter", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nThe function i40e_validate_cloud_filter checks that the destination and\nsource port numbers are valid by attempting to ensure that the number is\nnon-zero and no larger than 0xFFFF. However, the types for the dst_port\nand src_port variable are __be16 which by definition cannot be larger\nthan 0xFFFF\n\nSince these values cannot be larger than 2 bytes, the check to see if\nthey exceed 0xFFFF is meaningless.\n\nOne might consider these checks as some sort of defensive coding, in\ncase the type was later changed. However, these checks also byte-swap\nthe value before comparision using be16_to_cpu, which will truncate the\nvalues to 16bits anyways. Additionally, changing the type would require\nupdating the opcodes to support new data layout of these virtchnl\ncommands.\n\nRemove the check to silence the -Wtype-limits warning that was added to\nGCC 8.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 24628de8e624..925ca880bea3 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -3129,7 +3129,7 @@ static int i40e_validate_cloud_filter(struct i40e_vf *vf,\n \t}\n \n \tif (mask.dst_port & data.dst_port) {\n-\t\tif (!data.dst_port || be16_to_cpu(data.dst_port) > 0xFFFF) {\n+\t\tif (!data.dst_port) {\n \t\t\tdev_info(&pf->pdev->dev, \"VF %d: Invalid Dest port\\n\",\n \t\t\t\t vf->vf_id);\n \t\t\tgoto err;\n@@ -3137,7 +3137,7 @@ static int i40e_validate_cloud_filter(struct i40e_vf *vf,\n \t}\n \n \tif (mask.src_port & data.src_port) {\n-\t\tif (!data.src_port || be16_to_cpu(data.src_port) > 0xFFFF) {\n+\t\tif (!data.src_port) {\n \t\t\tdev_info(&pf->pdev->dev, \"VF %d: Invalid Source port\\n\",\n \t\t\t\t vf->vf_id);\n \t\t\tgoto err;\n", "prefixes": [ "next", "S3", "7/9" ] }