Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1049,
    "url": "http://patchwork.ozlabs.org/api/patches/1049/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20080923043005.358e19e7.akpm@linux-foundation.org/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20080923043005.358e19e7.akpm@linux-foundation.org>",
    "list_archive_url": null,
    "date": "2008-09-23T11:30:05",
    "name": "[4/4] mISDN: misc timerdev fixes",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "e4b85bad13145d25203ab4e8adaf6a36a8bffa0a",
    "submitter": {
        "id": 107,
        "url": "http://patchwork.ozlabs.org/api/people/107/?format=api",
        "name": "Andrew Morton",
        "email": "akpm@linux-foundation.org"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20080923043005.358e19e7.akpm@linux-foundation.org/mbox/",
    "series": [],
    "comments": "http://patchwork.ozlabs.org/api/patches/1049/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/1049/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 4C2A7DDDE7\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 23 Sep 2008 21:30:56 +1000 (EST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750954AbYIWLaw (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 23 Sep 2008 07:30:52 -0400",
            "(majordomo@vger.kernel.org) by vger.kernel.org id S1750884AbYIWLaw\n\t(ORCPT <rfc822; netdev-outgoing>); Tue, 23 Sep 2008 07:30:52 -0400",
            "from smtp1.linux-foundation.org ([140.211.169.13]:41196 \"EHLO\n\tsmtp1.linux-foundation.org\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1750869AbYIWLav (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 23 Sep 2008 07:30:51 -0400",
            "from imap1.linux-foundation.org (imap1.linux-foundation.org\n\t[140.211.169.55])\n\tby smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with\n\tESMTP id m8NBU6U2005666\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);\n\tTue, 23 Sep 2008 04:30:07 -0700",
            "from y.localdomain (localhost [127.0.0.1])\n\tby imap1.linux-foundation.org\n\t(8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with SMTP id\n\tm8NBU6si029737; Tue, 23 Sep 2008 04:30:06 -0700"
        ],
        "Date": "Tue, 23 Sep 2008 04:30:05 -0700",
        "From": "Andrew Morton <akpm@linux-foundation.org>",
        "To": "Christoph Hellwig <hch@infradead.org>",
        "Cc": "kkeil@suse.de, netdev@vger.kernel.org, andi@firstfloor.org,\n\tak@linux.intel.com",
        "Subject": "Re: [patch 4/4] mISDN: misc timerdev fixes",
        "Message-Id": "<20080923043005.358e19e7.akpm@linux-foundation.org>",
        "In-Reply-To": "<20080923104026.GA12535@infradead.org>",
        "References": "<200809222151.m8MLp3tb031906@imap1.linux-foundation.org>\n\t<20080923104026.GA12535@infradead.org>",
        "X-Mailer": "Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu)",
        "Mime-Version": "1.0",
        "Content-Type": "text/plain; charset=US-ASCII",
        "Content-Transfer-Encoding": "7bit",
        "X-Spam-Status": "No, hits=-3.36 required=5 tests=AWL, BAYES_00,\n\tOSDL_HEADER_SUBJECT_BRACKETED",
        "X-Spam-Checker-Version": "SpamAssassin 3.2.4-osdl_revision__1.47__",
        "X-MIMEDefang-Filter": "lf$Revision: 1.188 $",
        "X-Scanned-By": "MIMEDefang 2.63 on 140.211.169.13",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "On Tue, 23 Sep 2008 06:40:26 -0400 Christoph Hellwig <hch@infradead.org> wrote:\n\n> On Mon, Sep 22, 2008 at 02:51:03PM -0700, akpm@linux-foundation.org wrote:\n> > From: Andi Kleen <andi@firstfloor.org>\n> > \n> > - Remove noop VFS stubs. The VFS does that on a NULL pointer anyways.\n> \n> > -static loff_t\n> > -mISDN_llseek(struct file *filep, loff_t offset, int orig)\n> > -{\n> > -\treturn -ESPIPE;\n> > -}\n> \n> >  static struct file_operations mISDN_fops = {\n> > -\t.llseek\t\t= mISDN_llseek,\n> \n> This is wrong.  no llseek means we use default_llseek, which is\n> different from returning -ESPIPE.\n\nso.. this?",
    "diff": "--- a/drivers/isdn/mISDN/timerdev.c~misdn-misc-timerdev-fixes-fix\n+++ a/drivers/isdn/mISDN/timerdev.c\n@@ -61,7 +61,7 @@ mISDN_open(struct inode *ino, struct fil\n \tinit_waitqueue_head(&dev->wait);\n \tfilep->private_data = dev;\n \t__module_get(THIS_MODULE);\n-\treturn 0;\n+\treturn nonseekable_open(ino, filep);\n }\n \n static int\n",
    "prefixes": [
        "4/4"
    ]
}