Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1045381/?format=api
{ "id": 1045381, "url": "http://patchwork.ozlabs.org/api/patches/1045381/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190220152014.13376-1-jan.sokolowski@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190220152014.13376-1-jan.sokolowski@intel.com>", "list_archive_url": null, "date": "2019-02-20T15:20:14", "name": "[net] ixgbe: don't do any AF_XDP zero-copy transmit if netif is not OK", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "dd19a26fc985afe4cd222bdc18a42197f7888df3", "submitter": { "id": 75418, "url": "http://patchwork.ozlabs.org/api/people/75418/?format=api", "name": "Jan Sokolowski", "email": "jan.sokolowski@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190220152014.13376-1-jan.sokolowski@intel.com/mbox/", "series": [ { "id": 93177, "url": "http://patchwork.ozlabs.org/api/series/93177/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=93177", "date": "2019-02-20T15:20:14", "name": "[net] ixgbe: don't do any AF_XDP zero-copy transmit if netif is not OK", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/93177/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1045381/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1045381/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 444Lsc3SlJz9sB3\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 21 Feb 2019 02:21:07 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 10EA586833;\n\tWed, 20 Feb 2019 15:21:06 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VPcTpYpDjyAZ; Wed, 20 Feb 2019 15:21:04 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7EF39863B2;\n\tWed, 20 Feb 2019 15:21:04 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8D9711BF2BF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 20 Feb 2019 15:21:02 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 89DE485A97\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 20 Feb 2019 15:21:02 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DeYTVK40TdAB for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 20 Feb 2019 15:21:02 +0000 (UTC)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id F14E485A4B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 20 Feb 2019 15:21:01 +0000 (UTC)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Feb 2019 07:21:01 -0800", "from gklab-18-202.igk.intel.com (HELO u2032.nql.local)\n\t([10.102.18.202])\n\tby orsmga007.jf.intel.com with ESMTP; 20 Feb 2019 07:21:00 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,391,1544515200\"; d=\"scan'208\";a=\"116404459\"", "From": "Jan Sokolowski <jan.sokolowski@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 20 Feb 2019 15:20:14 +0000", "Message-Id": "<20190220152014.13376-1-jan.sokolowski@intel.com>", "X-Mailer": "git-send-email 2.18.1", "Subject": "[Intel-wired-lan] [PATCH net] ixgbe: don't do any AF_XDP zero-copy\n\ttransmit if netif is not OK", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "An issue has been found while testing zero-copy XDP that\ncauses a reset to be triggered. As it takes some time to\nturn the carrier on after setting zc, and we already\nstart trying to transmit some packets, watchdog considers\nthis as an erroneous state and triggers a reset.\n\nDon't do any work if netif carrier is not OK.\n\nFixes: 8221c5eba8c13 (ixgbe: add AF_XDP zero-copy Tx support)\nSigned-off-by: Jan Sokolowski <jan.sokolowski@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c\nindex 98870707b51a..51c29358c2a9 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c\n@@ -617,7 +617,8 @@ static bool ixgbe_xmit_zc(struct ixgbe_ring *xdp_ring, unsigned int budget)\n \tdma_addr_t dma;\n \n \twhile (budget-- > 0) {\n-\t\tif (unlikely(!ixgbe_desc_unused(xdp_ring))) {\n+\t\tif (unlikely(!ixgbe_desc_unused(xdp_ring)) ||\n+\t\t !netif_carrier_ok(xdp_ring->netdev)) {\n \t\t\twork_done = false;\n \t\t\tbreak;\n \t\t}\n", "prefixes": [ "net" ] }