Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1045,
    "url": "http://patchwork.ozlabs.org/api/patches/1045/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20080923.025542.193703353.davem@davemloft.net/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20080923.025542.193703353.davem@davemloft.net>",
    "list_archive_url": null,
    "date": "2008-09-23T09:55:42",
    "name": ": tcp: Fix queue traversal in tcp_use_frto().",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "4680d317c18b3df3db9ee3f8984bc2e6b4109e55",
    "submitter": {
        "id": 15,
        "url": "http://patchwork.ozlabs.org/api/people/15/?format=api",
        "name": "David Miller",
        "email": "davem@davemloft.net"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20080923.025542.193703353.davem@davemloft.net/mbox/",
    "series": [],
    "comments": "http://patchwork.ozlabs.org/api/patches/1045/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/1045/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 1363FDDDE7\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 23 Sep 2008 19:56:02 +1000 (EST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751034AbYIWJzz (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 23 Sep 2008 05:55:55 -0400",
            "(majordomo@vger.kernel.org) by vger.kernel.org id S1751051AbYIWJzz\n\t(ORCPT <rfc822; netdev-outgoing>); Tue, 23 Sep 2008 05:55:55 -0400",
            "from 74-93-104-97-Washington.hfc.comcastbusiness.net\n\t([74.93.104.97]:49693\n\t\"EHLO sunset.davemloft.net\" rhost-flags-OK-FAIL-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751007AbYIWJzz (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 23 Sep 2008 05:55:55 -0400",
            "from localhost (localhost [127.0.0.1])\n\tby sunset.davemloft.net (Postfix) with ESMTP id 14AFEC8C185\n\tfor <netdev@vger.kernel.org>; Tue, 23 Sep 2008 02:55:43 -0700 (PDT)"
        ],
        "Date": "Tue, 23 Sep 2008 02:55:42 -0700 (PDT)",
        "Message-Id": "<20080923.025542.193703353.davem@davemloft.net>",
        "To": "netdev@vger.kernel.org",
        "Subject": "[PATCH]: tcp: Fix queue traversal in tcp_use_frto().",
        "From": "David Miller <davem@davemloft.net>",
        "X-Mailer": "Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI)",
        "Mime-Version": "1.0",
        "Content-Type": "Text/Plain; charset=us-ascii",
        "Content-Transfer-Encoding": "7bit",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "One more skb_queue_next() BUG trigger.  I double audited the\nremaining tcp_write_queue_next() cases and they should all\nbe good.\n\ntcp: Fix queue traversal in tcp_use_frto().\n\nWe must check tcp_skb_is_last() before doing a tcp_write_queue_next().\n\nSigned-off-by: David S. Miller <davem@davemloft.net>\n---\n net/ipv4/tcp_input.c |    2 ++\n 1 files changed, 2 insertions(+), 0 deletions(-)",
    "diff": "diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c\nindex cbfe13d..3b76bce 100644\n--- a/net/ipv4/tcp_input.c\n+++ b/net/ipv4/tcp_input.c\n@@ -1746,6 +1746,8 @@ int tcp_use_frto(struct sock *sk)\n \t\treturn 0;\n \n \tskb = tcp_write_queue_head(sk);\n+\tif (tcp_skb_is_last(sk, skb))\n+\t\treturn 1;\n \tskb = tcp_write_queue_next(sk, skb);\t/* Skips head */\n \ttcp_for_write_queue_from(skb, sk) {\n \t\tif (skb == tcp_send_head(sk))\n",
    "prefixes": []
}