Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1044946/?format=api
{ "id": 1044946, "url": "http://patchwork.ozlabs.org/api/patches/1044946/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190219230414.25627-4-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190219230414.25627-4-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2019-02-19T23:04:03", "name": "[S15,03/14] ice: Fix issue with VF attempt to delete default MAC address", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "92ece3a33f2c714e1fa9a4569b8ec8884f4c7ae3", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190219230414.25627-4-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 93015, "url": "http://patchwork.ozlabs.org/api/series/93015/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=93015", "date": "2019-02-19T23:04:04", "name": "Bug fixes and minor clean up for ice", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/93015/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1044946/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1044946/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 443xBl4wDgz9s21\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Feb 2019 10:04:31 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 15249234AA;\n\tTue, 19 Feb 2019 23:04:30 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id xhNM7lx-A4iI; Tue, 19 Feb 2019 23:04:24 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 9D08B232D2;\n\tTue, 19 Feb 2019 23:04:21 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1C53C1BF2EA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Feb 2019 23:04:19 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 17887232BD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Feb 2019 23:04:19 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id WTHitUUtn+ai for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Feb 2019 23:04:16 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 810102326C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Feb 2019 23:04:16 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Feb 2019 15:04:15 -0800", "from shasta.jf.intel.com ([10.166.241.11])\n\tby fmsmga002.fm.intel.com with ESMTP; 19 Feb 2019 15:04:15 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,388,1544515200\"; d=\"scan'208\";a=\"144858764\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 19 Feb 2019 15:04:03 -0800", "Message-Id": "<20190219230414.25627-4-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.14.5", "In-Reply-To": "<20190219230414.25627-1-anirudh.venkataramanan@intel.com>", "References": "<20190219230414.25627-1-anirudh.venkataramanan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH S15 03/14] ice: Fix issue with VF attempt\n\tto delete default MAC address", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>\n\nThis patch fixes issue that occurs when VF is attempting to remove\ndefault LAN/MAC address, which is programmed by the administrator.\nWe shouldn't return error for the call by the VF, but continue with\nthe remaining steps to handle MAC opcode.\n\nSigned-off-by: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 15 +++++++--------\n 1 file changed, 7 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\nindex 7a4f86ad8149..e322bde45c59 100644\n--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n@@ -2061,23 +2061,22 @@ ice_vc_handle_mac_addr_msg(struct ice_vf *vf, u8 *msg, bool set)\n \t\t\t\t * already added. Just continue.\n \t\t\t\t */\n \t\t\t\tdev_info(&pf->pdev->dev,\n-\t\t\t\t\t \"mac %pM already set for VF %d\\n\",\n+\t\t\t\t\t \"MAC %pM already set for VF %d\\n\",\n \t\t\t\t\t maddr, vf->vf_id);\n \t\t\t\tcontinue;\n \t\t\t} else {\n \t\t\t\t/* VF can't remove dflt_lan_addr/bcast mac */\n \t\t\t\tdev_err(&pf->pdev->dev,\n-\t\t\t\t\t\"can't remove mac %pM for VF %d\\n\",\n+\t\t\t\t\t\"VF can't remove default MAC address or MAC %pM programmed by PF for VF %d\\n\",\n \t\t\t\t\tmaddr, vf->vf_id);\n-\t\t\t\tv_ret = VIRTCHNL_STATUS_ERR_PARAM;\n-\t\t\t\tgoto handle_mac_exit;\n+\t\t\t\tcontinue;\n \t\t\t}\n \t\t}\n \n \t\t/* check for the invalid cases and bail if necessary */\n \t\tif (is_zero_ether_addr(maddr)) {\n \t\t\tdev_err(&pf->pdev->dev,\n-\t\t\t\t\"invalid mac %pM provided for VF %d\\n\",\n+\t\t\t\t\"invalid MAC %pM provided for VF %d\\n\",\n \t\t\t\tmaddr, vf->vf_id);\n \t\t\tv_ret = VIRTCHNL_STATUS_ERR_PARAM;\n \t\t\tgoto handle_mac_exit;\n@@ -2086,7 +2085,7 @@ ice_vc_handle_mac_addr_msg(struct ice_vf *vf, u8 *msg, bool set)\n \t\tif (is_unicast_ether_addr(maddr) &&\n \t\t !ice_can_vf_change_mac(vf)) {\n \t\t\tdev_err(&pf->pdev->dev,\n-\t\t\t\t\"can't change unicast mac for untrusted VF %d\\n\",\n+\t\t\t\t\"can't change unicast MAC for untrusted VF %d\\n\",\n \t\t\t\tvf->vf_id);\n \t\t\tv_ret = VIRTCHNL_STATUS_ERR_PARAM;\n \t\t\tgoto handle_mac_exit;\n@@ -2108,7 +2107,7 @@ ice_vc_handle_mac_addr_msg(struct ice_vf *vf, u8 *msg, bool set)\n \n \tif (v_ret) {\n \t\tdev_err(&pf->pdev->dev,\n-\t\t\t\"can't update mac filters for VF %d, error %d\\n\",\n+\t\t\t\"can't update MAC filters for VF %d, error %d\\n\",\n \t\t\tvf->vf_id, v_ret);\n \t} else {\n \t\tif (set)\n@@ -2809,7 +2808,7 @@ int ice_set_vf_mac(struct net_device *netdev, int vf_id, u8 *mac)\n \tether_addr_copy(vf->dflt_lan_addr.addr, mac);\n \tvf->pf_set_mac = true;\n \tnetdev_info(netdev,\n-\t\t \"mac on VF %d set to %pM. VF driver will be reinitialized\\n\",\n+\t\t \"MAC on VF %d set to %pM. VF driver will be reinitialized\\n\",\n \t\t vf_id, mac);\n \n \tice_vc_dis_vf(vf);\n", "prefixes": [ "S15", "03/14" ] }