Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1044942/?format=api
{ "id": 1044942, "url": "http://patchwork.ozlabs.org/api/patches/1044942/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190219230414.25627-12-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190219230414.25627-12-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2019-02-19T23:04:11", "name": "[S15,11/14] ice: Remove \"2 BITS\" comment", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "18ffc86a4d9ba182effd9958542dcd5eefb1fbe2", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190219230414.25627-12-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 93015, "url": "http://patchwork.ozlabs.org/api/series/93015/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=93015", "date": "2019-02-19T23:04:04", "name": "Bug fixes and minor clean up for ice", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/93015/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1044942/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1044942/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 443xBf68DTz9s21\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Feb 2019 10:04:26 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7BB81861B5;\n\tTue, 19 Feb 2019 23:04:25 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VNPGsHtWQ41Q; Tue, 19 Feb 2019 23:04:23 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id E39E9864CF;\n\tTue, 19 Feb 2019 23:04:22 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id C72581BF2EA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Feb 2019 23:04:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id C4438232D2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Feb 2019 23:04:20 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wvhxOSM6Bz5q for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Feb 2019 23:04:19 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 3C95323376\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Feb 2019 23:04:17 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Feb 2019 15:04:16 -0800", "from shasta.jf.intel.com ([10.166.241.11])\n\tby fmsmga002.fm.intel.com with ESMTP; 19 Feb 2019 15:04:16 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,388,1544515200\"; d=\"scan'208\";a=\"144858789\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 19 Feb 2019 15:04:11 -0800", "Message-Id": "<20190219230414.25627-12-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.14.5", "In-Reply-To": "<20190219230414.25627-1-anirudh.venkataramanan@intel.com>", "References": "<20190219230414.25627-1-anirudh.venkataramanan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH S15 11/14] ice: Remove \"2 BITS\" comment", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Some enums in ice_tx_desc_cmd_bits have a trailing /* 2 BITS */ comment,\nbut the value has just one bit set (ex. ICE_TX_DESC_CMD_L4T_EOFT_SCTP\nhas the value 0x200 (i.e. only bit 9 is set). This is confusing and\nmisleading. So remove the comment.\n\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h b/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h\nindex 2e87b69aff4f..a8c3fe87d7aa 100644\n--- a/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h\n+++ b/drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h\n@@ -342,12 +342,12 @@ enum ice_tx_desc_cmd_bits {\n \tICE_TX_DESC_CMD_EOP\t\t\t= 0x0001,\n \tICE_TX_DESC_CMD_RS\t\t\t= 0x0002,\n \tICE_TX_DESC_CMD_IL2TAG1\t\t\t= 0x0008,\n-\tICE_TX_DESC_CMD_IIPT_IPV6\t\t= 0x0020, /* 2 BITS */\n-\tICE_TX_DESC_CMD_IIPT_IPV4\t\t= 0x0040, /* 2 BITS */\n-\tICE_TX_DESC_CMD_IIPT_IPV4_CSUM\t\t= 0x0060, /* 2 BITS */\n-\tICE_TX_DESC_CMD_L4T_EOFT_TCP\t\t= 0x0100, /* 2 BITS */\n-\tICE_TX_DESC_CMD_L4T_EOFT_SCTP\t\t= 0x0200, /* 2 BITS */\n-\tICE_TX_DESC_CMD_L4T_EOFT_UDP\t\t= 0x0300, /* 2 BITS */\n+\tICE_TX_DESC_CMD_IIPT_IPV6\t\t= 0x0020,\n+\tICE_TX_DESC_CMD_IIPT_IPV4\t\t= 0x0040,\n+\tICE_TX_DESC_CMD_IIPT_IPV4_CSUM\t\t= 0x0060,\n+\tICE_TX_DESC_CMD_L4T_EOFT_TCP\t\t= 0x0100,\n+\tICE_TX_DESC_CMD_L4T_EOFT_SCTP\t\t= 0x0200,\n+\tICE_TX_DESC_CMD_L4T_EOFT_UDP\t\t= 0x0300,\n };\n \n #define ICE_TXD_QW1_OFFSET_S\t16\n", "prefixes": [ "S15", "11/14" ] }