Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1040932/?format=api
{ "id": 1040932, "url": "http://patchwork.ozlabs.org/api/patches/1040932/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1550025714-76215-1-git-send-email-feng.tang@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1550025714-76215-1-git-send-email-feng.tang@intel.com>", "list_archive_url": null, "date": "2019-02-13T02:41:54", "name": "[v2] intel-ethernet: warn when fatal read failure happens", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "be91539ca222dfa4cf211b6064d8f68d9163d143", "submitter": { "id": 5814, "url": "http://patchwork.ozlabs.org/api/people/5814/?format=api", "name": "Feng Tang", "email": "feng.tang@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1550025714-76215-1-git-send-email-feng.tang@intel.com/mbox/", "series": [ { "id": 91618, "url": "http://patchwork.ozlabs.org/api/series/91618/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=91618", "date": "2019-02-13T02:41:54", "name": "[v2] intel-ethernet: warn when fatal read failure happens", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/91618/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1040932/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1040932/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 43zkLc3KpLz9sMr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Feb 2019 13:41:44 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B71D385F38;\n\tWed, 13 Feb 2019 02:41:42 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HLbGixtLY6Hi; Wed, 13 Feb 2019 02:41:34 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6B1C8861F8;\n\tWed, 13 Feb 2019 02:41:34 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7678F1BF39A\n\tfor <intel-wired-lan@osuosl.org>;\n\tWed, 13 Feb 2019 02:41:32 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 731AC22686\n\tfor <intel-wired-lan@osuosl.org>;\n\tWed, 13 Feb 2019 02:41:32 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id b4FeMxKJPnnA for <intel-wired-lan@osuosl.org>;\n\tWed, 13 Feb 2019 02:41:31 +0000 (UTC)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby silver.osuosl.org (Postfix) with ESMTPS id ADF3422661\n\tfor <intel-wired-lan@osuosl.org>;\n\tWed, 13 Feb 2019 02:41:31 +0000 (UTC)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Feb 2019 18:41:31 -0800", "from shbuild999.sh.intel.com ([10.239.147.118])\n\tby fmsmga005.fm.intel.com with ESMTP; 12 Feb 2019 18:41:30 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,364,1544515200\"; d=\"scan'208\";a=\"319908165\"", "From": "Feng Tang <feng.tang@intel.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tSasha Neftin <sasha.neftin@intel.com>,\n\tAaron F Brown <aaron.f.brown@intel.com>, intel-wired-lan@osuosl.org", "Date": "Wed, 13 Feb 2019 10:41:54 +0800", "Message-Id": "<1550025714-76215-1-git-send-email-feng.tang@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[Intel-wired-lan] [PATCH v2] intel-ethernet: warn when fatal read\n\tfailure happens", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Failed in read the HW register is very serious for igb/igc driver,\nas its hw_addr will be set to NULL and cause the adapter be seen as\n\"REMOVED\".\n\nWe saw the error only a few times in the MTBF test for suspend/resume,\nbut can hardly get any useful info to debug.\n\nAdding WARN() so that we can get the necessary information about\nwhere and how it happens, and use it for root causing and fixing\nthis \"PCIe link lost issue\"\n\nThis affects igb, igc.\n\nSigned-off-by: Feng Tang <feng.tang@intel.com>\nTested-by: Aaron Brown <aaron.f.brown@intel.com>\n---\nChangelog:\n\n v2: add \"\\n\" to the warning message as suggested by Sasha Neftin\n\n drivers/net/ethernet/intel/igb/igb_main.c | 1 +\n drivers/net/ethernet/intel/igc/igc_main.c | 1 +\n 2 files changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 7137e7f..e3177e5 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -753,6 +753,7 @@ u32 igb_rd32(struct e1000_hw *hw, u32 reg)\n \t\tstruct net_device *netdev = igb->netdev;\n \t\thw->hw_addr = NULL;\n \t\tnetdev_err(netdev, \"PCIe link lost\\n\");\n+\t\tWARN(1, \"igb: Failed to read reg 0x%x!\\n\", reg);\n \t}\n \n \treturn value;\ndiff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex f201830..f0af812 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -3496,6 +3496,7 @@ u32 igc_rd32(struct igc_hw *hw, u32 reg)\n \t\thw->hw_addr = NULL;\n \t\tnetif_device_detach(netdev);\n \t\tnetdev_err(netdev, \"PCIe link lost, device now detached\\n\");\n+\t\tWARN(1, \"igc: Failed to read reg 0x%x!\\n\", reg);\n \t}\n \n \treturn value;\n", "prefixes": [ "v2" ] }