Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1039005/?format=api
{ "id": 1039005, "url": "http://patchwork.ozlabs.org/api/patches/1039005/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190208205112.12180-7-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190208205112.12180-7-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2019-02-08T20:51:02", "name": "[S13,06/16] ice: code cleanup in ice_sched.c", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9c2368ea8d1de1a0d0a0c93a86da9847d4e734e0", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190208205112.12180-7-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 90916, "url": "http://patchwork.ozlabs.org/api/series/90916/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=90916", "date": "2019-02-08T20:50:57", "name": "Bug fixes and minor feature updates for ice", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/90916/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1039005/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1039005/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 43x6sC1KHrz9sMp\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 9 Feb 2019 07:55:43 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id D512E86A51;\n\tFri, 8 Feb 2019 20:55:33 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Z4F71oo2KAcm; Fri, 8 Feb 2019 20:55:25 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id BB63684403;\n\tFri, 8 Feb 2019 20:55:24 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 550C11BF865\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 8 Feb 2019 20:53:39 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1BCFB86890\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 8 Feb 2019 20:53:34 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id yFx6RdeFSfWI for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 8 Feb 2019 20:53:13 +0000 (UTC)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id F3B1984B23\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 8 Feb 2019 20:53:11 +0000 (UTC)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Feb 2019 12:51:13 -0800", "from shasta.jf.intel.com ([10.166.241.11])\n\tby fmsmga008.fm.intel.com with ESMTP; 08 Feb 2019 12:51:13 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,348,1544515200\"; d=\"scan'208\";a=\"123065502\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 8 Feb 2019 12:51:02 -0800", "Message-Id": "<20190208205112.12180-7-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.14.5", "In-Reply-To": "<20190208205112.12180-1-anirudh.venkataramanan@intel.com>", "References": "<20190208205112.12180-1-anirudh.venkataramanan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH S13 06/16] ice: code cleanup in ice_sched.c", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Victor Raj <victor.raj@intel.com>\n\nThis patch does some clean up in the Tx scheduler code:\n\n1. Adjust the stack variable usage\n2. Modify the debug prints to display the FW error\n3. Add additional debug prints while adding/removing VSIs\n\nSigned-off-by: Victor Raj <victor.raj@intel.com>\nReviewed-by: Bruce Allan <bruce.w.allan@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n[Anirudh Venkataramanan <anirudh.venkataramanan@intel.com> cleaned up commit message]\n---\n drivers/net/ethernet/intel/ice/ice_sched.c | 17 +++++++++--------\n 1 file changed, 9 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_sched.c b/drivers/net/ethernet/intel/ice/ice_sched.c\nindex 086a4c7254c5..cf1142ec16ee 100644\n--- a/drivers/net/ethernet/intel/ice/ice_sched.c\n+++ b/drivers/net/ethernet/intel/ice/ice_sched.c\n@@ -276,7 +276,8 @@ ice_sched_remove_elems(struct ice_hw *hw, struct ice_sched_node *parent,\n \tstatus = ice_aq_delete_sched_elems(hw, 1, buf, buf_size,\n \t\t\t\t\t &num_groups_removed, NULL);\n \tif (status || num_groups_removed != 1)\n-\t\tice_debug(hw, ICE_DBG_SCHED, \"remove elements failed\\n\");\n+\t\tice_debug(hw, ICE_DBG_SCHED, \"remove node failed FW error %d\\n\",\n+\t\t\t hw->adminq.sq_last_status);\n \n \tdevm_kfree(ice_hw_to_dev(hw), buf);\n \treturn status;\n@@ -360,12 +361,8 @@ void ice_free_sched_node(struct ice_port_info *pi, struct ice_sched_node *node)\n \t node->info.data.elem_type != ICE_AQC_ELEM_TYPE_ROOT_PORT &&\n \t node->info.data.elem_type != ICE_AQC_ELEM_TYPE_LEAF) {\n \t\tu32 teid = le32_to_cpu(node->info.node_teid);\n-\t\tenum ice_status status;\n \n-\t\tstatus = ice_sched_remove_elems(hw, node->parent, 1, &teid);\n-\t\tif (status)\n-\t\t\tice_debug(hw, ICE_DBG_SCHED,\n-\t\t\t\t \"remove element failed %d\\n\", status);\n+\t\tice_sched_remove_elems(hw, node->parent, 1, &teid);\n \t}\n \tparent = node->parent;\n \t/* root has no parent */\n@@ -697,7 +694,8 @@ ice_sched_add_elems(struct ice_port_info *pi, struct ice_sched_node *tc_node,\n \tstatus = ice_aq_add_sched_elems(hw, 1, buf, buf_size,\n \t\t\t\t\t&num_groups_added, NULL);\n \tif (status || num_groups_added != 1) {\n-\t\tice_debug(hw, ICE_DBG_SCHED, \"add elements failed\\n\");\n+\t\tice_debug(hw, ICE_DBG_SCHED, \"add node failed FW Error %d\\n\",\n+\t\t\t hw->adminq.sq_last_status);\n \t\tdevm_kfree(ice_hw_to_dev(hw), buf);\n \t\treturn ICE_ERR_CFG;\n \t}\n@@ -1527,6 +1525,7 @@ ice_sched_cfg_vsi(struct ice_port_info *pi, u16 vsi_handle, u8 tc, u16 maxqs,\n \tenum ice_status status = 0;\n \tstruct ice_hw *hw = pi->hw;\n \n+\tice_debug(pi->hw, ICE_DBG_SCHED, \"add/config VSI %d\\n\", vsi_handle);\n \ttc_node = ice_sched_get_tc_node(pi, tc);\n \tif (!tc_node)\n \t\treturn ICE_ERR_PARAM;\n@@ -1646,8 +1645,9 @@ ice_sched_rm_vsi_cfg(struct ice_port_info *pi, u16 vsi_handle, u8 owner)\n {\n \tenum ice_status status = ICE_ERR_PARAM;\n \tstruct ice_vsi_ctx *vsi_ctx;\n-\tu8 i, j = 0;\n+\tu8 i;\n \n+\tice_debug(pi->hw, ICE_DBG_SCHED, \"removing VSI %d\\n\", vsi_handle);\n \tif (!ice_is_vsi_valid(pi->hw, vsi_handle))\n \t\treturn status;\n \tmutex_lock(&pi->sched_lock);\n@@ -1657,6 +1657,7 @@ ice_sched_rm_vsi_cfg(struct ice_port_info *pi, u16 vsi_handle, u8 owner)\n \n \tfor (i = 0; i < ICE_MAX_TRAFFIC_CLASS; i++) {\n \t\tstruct ice_sched_node *vsi_node, *tc_node;\n+\t\tu8 j = 0;\n \n \t\ttc_node = ice_sched_get_tc_node(pi, i);\n \t\tif (!tc_node)\n", "prefixes": [ "S13", "06/16" ] }