Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1038992/?format=api
{ "id": 1038992, "url": "http://patchwork.ozlabs.org/api/patches/1038992/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190208205043.11975-17-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190208205043.11975-17-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2019-02-08T20:50:43", "name": "[S11,16/16] ice: fix overlong string, update stats output", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6f384fdeda9ac80642b3de548f27aeffb16f94fa", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190208205043.11975-17-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 90915, "url": "http://patchwork.ozlabs.org/api/series/90915/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=90915", "date": "2019-02-08T20:50:37", "name": "Bug fixes for ice", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/90915/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1038992/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1038992/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 43x6r80fBSz9sMp\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 9 Feb 2019 07:54:47 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 08C6686890;\n\tFri, 8 Feb 2019 20:54:45 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id t6U1v05aOTe0; Fri, 8 Feb 2019 20:54:31 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 71AE6870F7;\n\tFri, 8 Feb 2019 20:54:27 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 4430D1BF982\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 8 Feb 2019 20:52:34 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 74FE523735\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 8 Feb 2019 20:52:31 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id IDgTpDMmUDkl for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 8 Feb 2019 20:52:29 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 8A7962279E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 8 Feb 2019 20:52:29 +0000 (UTC)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Feb 2019 12:50:44 -0800", "from shasta.jf.intel.com ([10.166.241.11])\n\tby orsmga008.jf.intel.com with ESMTP; 08 Feb 2019 12:50:44 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,348,1544515200\"; d=\"scan'208\";a=\"116332346\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 8 Feb 2019 12:50:43 -0800", "Message-Id": "<20190208205043.11975-17-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.14.5", "In-Reply-To": "<20190208205043.11975-1-anirudh.venkataramanan@intel.com>", "References": "<20190208205043.11975-1-anirudh.venkataramanan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH S11 16/16] ice: fix overlong string,\n\tupdate stats output", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nA test started warning on a string truncation. This led to an unfortunate\nrealization that we are likely not accounting for the stats length\ncorrectly before this patch, so fix the issue by putting \"port.\" in front\nof all the PF stats, instead of magically prepending it at runtime.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n[Anirudh Venkataramanan <anirudh.venkataramanan@intel.com> cleaned up commit message]\n---\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 80 ++++++++++++++--------------\n 1 file changed, 40 insertions(+), 40 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex 295571b1c4e8..eb8d149e317c 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -63,45 +63,45 @@ static const struct ice_stats ice_gstrings_vsi_stats[] = {\n * is queried on the base PF netdev.\n */\n static const struct ice_stats ice_gstrings_pf_stats[] = {\n-\tICE_PF_STAT(\"tx_bytes\", stats.eth.tx_bytes),\n-\tICE_PF_STAT(\"rx_bytes\", stats.eth.rx_bytes),\n-\tICE_PF_STAT(\"tx_unicast\", stats.eth.tx_unicast),\n-\tICE_PF_STAT(\"rx_unicast\", stats.eth.rx_unicast),\n-\tICE_PF_STAT(\"tx_multicast\", stats.eth.tx_multicast),\n-\tICE_PF_STAT(\"rx_multicast\", stats.eth.rx_multicast),\n-\tICE_PF_STAT(\"tx_broadcast\", stats.eth.tx_broadcast),\n-\tICE_PF_STAT(\"rx_broadcast\", stats.eth.rx_broadcast),\n-\tICE_PF_STAT(\"tx_errors\", stats.eth.tx_errors),\n-\tICE_PF_STAT(\"tx_size_64\", stats.tx_size_64),\n-\tICE_PF_STAT(\"rx_size_64\", stats.rx_size_64),\n-\tICE_PF_STAT(\"tx_size_127\", stats.tx_size_127),\n-\tICE_PF_STAT(\"rx_size_127\", stats.rx_size_127),\n-\tICE_PF_STAT(\"tx_size_255\", stats.tx_size_255),\n-\tICE_PF_STAT(\"rx_size_255\", stats.rx_size_255),\n-\tICE_PF_STAT(\"tx_size_511\", stats.tx_size_511),\n-\tICE_PF_STAT(\"rx_size_511\", stats.rx_size_511),\n-\tICE_PF_STAT(\"tx_size_1023\", stats.tx_size_1023),\n-\tICE_PF_STAT(\"rx_size_1023\", stats.rx_size_1023),\n-\tICE_PF_STAT(\"tx_size_1522\", stats.tx_size_1522),\n-\tICE_PF_STAT(\"rx_size_1522\", stats.rx_size_1522),\n-\tICE_PF_STAT(\"tx_size_big\", stats.tx_size_big),\n-\tICE_PF_STAT(\"rx_size_big\", stats.rx_size_big),\n-\tICE_PF_STAT(\"link_xon_tx\", stats.link_xon_tx),\n-\tICE_PF_STAT(\"link_xon_rx\", stats.link_xon_rx),\n-\tICE_PF_STAT(\"link_xoff_tx\", stats.link_xoff_tx),\n-\tICE_PF_STAT(\"link_xoff_rx\", stats.link_xoff_rx),\n-\tICE_PF_STAT(\"tx_dropped_link_down\", stats.tx_dropped_link_down),\n-\tICE_PF_STAT(\"rx_undersize\", stats.rx_undersize),\n-\tICE_PF_STAT(\"rx_fragments\", stats.rx_fragments),\n-\tICE_PF_STAT(\"rx_oversize\", stats.rx_oversize),\n-\tICE_PF_STAT(\"rx_jabber\", stats.rx_jabber),\n-\tICE_PF_STAT(\"rx_csum_bad\", hw_csum_rx_error),\n-\tICE_PF_STAT(\"rx_length_errors\", stats.rx_len_errors),\n-\tICE_PF_STAT(\"rx_dropped\", stats.eth.rx_discards),\n-\tICE_PF_STAT(\"rx_crc_errors\", stats.crc_errors),\n-\tICE_PF_STAT(\"illegal_bytes\", stats.illegal_bytes),\n-\tICE_PF_STAT(\"mac_local_faults\", stats.mac_local_faults),\n-\tICE_PF_STAT(\"mac_remote_faults\", stats.mac_remote_faults),\n+\tICE_PF_STAT(\"port.tx_bytes\", stats.eth.tx_bytes),\n+\tICE_PF_STAT(\"port.rx_bytes\", stats.eth.rx_bytes),\n+\tICE_PF_STAT(\"port.tx_unicast\", stats.eth.tx_unicast),\n+\tICE_PF_STAT(\"port.rx_unicast\", stats.eth.rx_unicast),\n+\tICE_PF_STAT(\"port.tx_multicast\", stats.eth.tx_multicast),\n+\tICE_PF_STAT(\"port.rx_multicast\", stats.eth.rx_multicast),\n+\tICE_PF_STAT(\"port.tx_broadcast\", stats.eth.tx_broadcast),\n+\tICE_PF_STAT(\"port.rx_broadcast\", stats.eth.rx_broadcast),\n+\tICE_PF_STAT(\"port.tx_errors\", stats.eth.tx_errors),\n+\tICE_PF_STAT(\"port.tx_size_64\", stats.tx_size_64),\n+\tICE_PF_STAT(\"port.rx_size_64\", stats.rx_size_64),\n+\tICE_PF_STAT(\"port.tx_size_127\", stats.tx_size_127),\n+\tICE_PF_STAT(\"port.rx_size_127\", stats.rx_size_127),\n+\tICE_PF_STAT(\"port.tx_size_255\", stats.tx_size_255),\n+\tICE_PF_STAT(\"port.rx_size_255\", stats.rx_size_255),\n+\tICE_PF_STAT(\"port.tx_size_511\", stats.tx_size_511),\n+\tICE_PF_STAT(\"port.rx_size_511\", stats.rx_size_511),\n+\tICE_PF_STAT(\"port.tx_size_1023\", stats.tx_size_1023),\n+\tICE_PF_STAT(\"port.rx_size_1023\", stats.rx_size_1023),\n+\tICE_PF_STAT(\"port.tx_size_1522\", stats.tx_size_1522),\n+\tICE_PF_STAT(\"port.rx_size_1522\", stats.rx_size_1522),\n+\tICE_PF_STAT(\"port.tx_size_big\", stats.tx_size_big),\n+\tICE_PF_STAT(\"port.rx_size_big\", stats.rx_size_big),\n+\tICE_PF_STAT(\"port.link_xon_tx\", stats.link_xon_tx),\n+\tICE_PF_STAT(\"port.link_xon_rx\", stats.link_xon_rx),\n+\tICE_PF_STAT(\"port.link_xoff_tx\", stats.link_xoff_tx),\n+\tICE_PF_STAT(\"port.link_xoff_rx\", stats.link_xoff_rx),\n+\tICE_PF_STAT(\"port.tx_dropped_link_down\", stats.tx_dropped_link_down),\n+\tICE_PF_STAT(\"port.rx_undersize\", stats.rx_undersize),\n+\tICE_PF_STAT(\"port.rx_fragments\", stats.rx_fragments),\n+\tICE_PF_STAT(\"port.rx_oversize\", stats.rx_oversize),\n+\tICE_PF_STAT(\"port.rx_jabber\", stats.rx_jabber),\n+\tICE_PF_STAT(\"port.rx_csum_bad\", hw_csum_rx_error),\n+\tICE_PF_STAT(\"port.rx_length_errors\", stats.rx_len_errors),\n+\tICE_PF_STAT(\"port.rx_dropped\", stats.eth.rx_discards),\n+\tICE_PF_STAT(\"port.rx_crc_errors\", stats.crc_errors),\n+\tICE_PF_STAT(\"port.illegal_bytes\", stats.illegal_bytes),\n+\tICE_PF_STAT(\"port.mac_local_faults\", stats.mac_local_faults),\n+\tICE_PF_STAT(\"port.mac_remote_faults\", stats.mac_remote_faults),\n };\n \n static const u32 ice_regs_dump_list[] = {\n@@ -304,7 +304,7 @@ static void ice_get_strings(struct net_device *netdev, u32 stringset, u8 *data)\n \t\t\treturn;\n \n \t\tfor (i = 0; i < ICE_PF_STATS_LEN; i++) {\n-\t\t\tsnprintf(p, ETH_GSTRING_LEN, \"port.%s\",\n+\t\t\tsnprintf(p, ETH_GSTRING_LEN, \"%s\",\n \t\t\t\t ice_gstrings_pf_stats[i].stat_string);\n \t\t\tp += ETH_GSTRING_LEN;\n \t\t}\n", "prefixes": [ "S11", "16/16" ] }