Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1038989/?format=api
{ "id": 1038989, "url": "http://patchwork.ozlabs.org/api/patches/1038989/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190208205101.12078-15-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190208205101.12078-15-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2019-02-08T20:51:01", "name": "[S12,14/14] ice: Fix issue reclaiming resources back to the pool after reset", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e62ac35b4de5db877ed2375d10c4f0c239288864", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190208205101.12078-15-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 90914, "url": "http://patchwork.ozlabs.org/api/series/90914/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=90914", "date": "2019-02-08T20:50:49", "name": "Bug fixes and minor feature updates for ice", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/90914/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1038989/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1038989/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 43x6r05ZKyz9sN1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 9 Feb 2019 07:54:40 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id AD0CE87100;\n\tFri, 8 Feb 2019 20:54:38 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id RAhsGDzYXqLR; Fri, 8 Feb 2019 20:54:28 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 2F44786A3C;\n\tFri, 8 Feb 2019 20:54:22 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1CB7F1BF986\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 8 Feb 2019 20:52:36 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1A58F8226F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 8 Feb 2019 20:52:34 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id gIPs33ZgsjnG for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 8 Feb 2019 20:51:49 +0000 (UTC)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id CCBAC88647\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 8 Feb 2019 20:51:04 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Feb 2019 12:51:03 -0800", "from shasta.jf.intel.com ([10.166.241.11])\n\tby fmsmga002.fm.intel.com with ESMTP; 08 Feb 2019 12:51:02 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,348,1544515200\"; d=\"scan'208\";a=\"141869803\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 8 Feb 2019 12:51:01 -0800", "Message-Id": "<20190208205101.12078-15-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.14.5", "In-Reply-To": "<20190208205101.12078-1-anirudh.venkataramanan@intel.com>", "References": "<20190208205101.12078-1-anirudh.venkataramanan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH S12 14/14] ice: Fix issue reclaiming\n\tresources back to the pool after reset", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>\n\nThis patch fixes issue reclaiming VF resources back to the pool after\nreset - Since we only allocate HW vector for all VFs and track together\nwith resources allocation for PF with ice_search_res, we need to free VFs\nresources separately, using first VF vector index to traverse the list.\nOtherwise tracker starts from the last assigned vectors list and causes\nmaximum supported number of HW vectors, 1024 to be exhausted, depending on\nthe number of VFs enabled, which causes a lot of unwanted issues, and\nfailed to reassign vectors for VFs.\n\nSigned-off-by: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_lib.c | 26 +++++++++++++++++++++++---\n 1 file changed, 23 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c\nindex d528640fc5b1..af72bb4f8f6f 100644\n--- a/drivers/net/ethernet/intel/ice/ice_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_lib.c\n@@ -2681,6 +2681,7 @@ int ice_vsi_release(struct ice_vsi *vsi)\n int ice_vsi_rebuild(struct ice_vsi *vsi, bool init_vsi)\n {\n \tu16 max_txqs[ICE_MAX_TRAFFIC_CLASS] = { 0 };\n+\tstruct ice_vf *vf = NULL;\n \tstruct ice_pf *pf;\n \tint ret, i;\n \n@@ -2688,12 +2689,31 @@ int ice_vsi_rebuild(struct ice_vsi *vsi, bool init_vsi)\n \t\treturn -EINVAL;\n \n \tpf = vsi->back;\n+\tif (vsi->type == ICE_VSI_VF)\n+\t\tvf = &pf->vf[vsi->vf_id];\n+\n \tice_rm_vsi_lan_cfg(vsi->port_info, vsi->idx);\n \tice_vsi_free_q_vectors(vsi);\n-\tice_free_res(vsi->back->sw_irq_tracker, vsi->sw_base_vector, vsi->idx);\n-\tice_free_res(vsi->back->hw_irq_tracker, vsi->hw_base_vector, vsi->idx);\n-\tvsi->sw_base_vector = 0;\n+\n+\tif (vsi->type != ICE_VSI_VF) {\n+\t\t/* reclaim SW interrupts back to the common pool */\n+\t\tice_free_res(pf->sw_irq_tracker, vsi->sw_base_vector, vsi->idx);\n+\t\tpf->num_avail_sw_msix += vsi->num_q_vectors;\n+\t\tvsi->sw_base_vector = 0;\n+\t\t/* reclaim HW interrupts back to the common pool */\n+\t\tice_free_res(pf->hw_irq_tracker, vsi->hw_base_vector,\n+\t\t\t vsi->idx);\n+\t\tpf->num_avail_hw_msix += vsi->num_q_vectors;\n+\t} else {\n+\t\t/* Reclaim VF resources back to the common pool for reset and\n+\t\t * and rebuild, with vector reassignment\n+\t\t */\n+\t\tice_free_res(pf->hw_irq_tracker, vf->first_vector_idx,\n+\t\t\t vsi->idx);\n+\t\tpf->num_avail_hw_msix += pf->num_vf_msix;\n+\t}\n \tvsi->hw_base_vector = 0;\n+\n \tice_vsi_clear_rings(vsi);\n \tice_vsi_free_arrays(vsi, false);\n \tice_dev_onetime_setup(&vsi->back->hw);\n", "prefixes": [ "S12", "14/14" ] }