Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1038981/?format=api
{ "id": 1038981, "url": "http://patchwork.ozlabs.org/api/patches/1038981/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190208205043.11975-16-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190208205043.11975-16-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2019-02-08T20:50:42", "name": "[S11,15/16] ice: Fix for FC get rx/tx pause params", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0f58c789cf7b4b9efc5d8642d9f4a218547fdb6e", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190208205043.11975-16-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 90915, "url": "http://patchwork.ozlabs.org/api/series/90915/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=90915", "date": "2019-02-08T20:50:37", "name": "Bug fixes for ice", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/90915/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1038981/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1038981/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 43x6qg1BkVz9sN1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 9 Feb 2019 07:54:23 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id AD83288070;\n\tFri, 8 Feb 2019 20:54:20 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FkNuwOaLOJ5W; Fri, 8 Feb 2019 20:54:11 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 9DA6A86DAC;\n\tFri, 8 Feb 2019 20:54:11 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 3EA7C1BF97E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 8 Feb 2019 20:52:32 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 219DB31425\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 8 Feb 2019 20:52:30 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 07jq29L1AlkJ for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 8 Feb 2019 20:52:29 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 57C703140B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 8 Feb 2019 20:52:29 +0000 (UTC)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Feb 2019 12:50:44 -0800", "from shasta.jf.intel.com ([10.166.241.11])\n\tby orsmga008.jf.intel.com with ESMTP; 08 Feb 2019 12:50:44 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,348,1544515200\"; d=\"scan'208\";a=\"116332345\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 8 Feb 2019 12:50:42 -0800", "Message-Id": "<20190208205043.11975-16-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.14.5", "In-Reply-To": "<20190208205043.11975-1-anirudh.venkataramanan@intel.com>", "References": "<20190208205043.11975-1-anirudh.venkataramanan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH S11 15/16] ice: Fix for FC get rx/tx pause\n\tparams", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Lukasz Czapnik <lukasz.czapnik@intel.com>\n\nEthtool reported pause params based on the currently negotiated\nlink settings instead of current PHY config. User was not able\nto turn off pause params because ethtool was incorrectly reporting\nparameters as off when link was down even though PHY was configured\nto support pause frames. Now pause params are taken from PHY config\ninstead of link status.\n\nSigned-off-by: Lukasz Czapnik <lukasz.czapnik@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 37 +++++++++++++++++++---------\n 1 file changed, 26 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex a93daf660171..295571b1c4e8 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -1818,21 +1818,36 @@ static void\n ice_get_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *pause)\n {\n \tstruct ice_netdev_priv *np = netdev_priv(netdev);\n-\tstruct ice_port_info *pi;\n+\tstruct ice_port_info *pi = np->vsi->port_info;\n+\tstruct ice_aqc_get_phy_caps_data *pcaps;\n+\tstruct ice_vsi *vsi = np->vsi;\n+\tenum ice_status status;\n \n-\tpi = np->vsi->port_info;\n-\tpause->autoneg =\n-\t\t((pi->phy.link_info.an_info & ICE_AQ_AN_COMPLETED) ?\n-\t\t AUTONEG_ENABLE : AUTONEG_DISABLE);\n+\t/* Initialize pause params */\n+\tpause->rx_pause = 0;\n+\tpause->tx_pause = 0;\n \n-\tif (pi->fc.current_mode == ICE_FC_RX_PAUSE) {\n-\t\tpause->rx_pause = 1;\n-\t} else if (pi->fc.current_mode == ICE_FC_TX_PAUSE) {\n+\tpcaps = devm_kzalloc(&vsi->back->pdev->dev, sizeof(*pcaps),\n+\t\t\t GFP_KERNEL);\n+\tif (!pcaps)\n+\t\treturn;\n+\n+\t/* Get current phy config */\n+\tstatus = ice_aq_get_phy_caps(pi, false, ICE_AQC_REPORT_SW_CFG, pcaps,\n+\t\t\t\t NULL);\n+\tif (status)\n+\t\tgoto out;\n+\n+\tpause->autoneg = ((pcaps->caps & ICE_AQC_PHY_AN_MODE) ?\n+\t\t\tAUTONEG_ENABLE : AUTONEG_DISABLE);\n+\n+\tif (pcaps->caps & ICE_AQC_PHY_EN_TX_LINK_PAUSE)\n \t\tpause->tx_pause = 1;\n-\t} else if (pi->fc.current_mode == ICE_FC_FULL) {\n+\tif (pcaps->caps & ICE_AQC_PHY_EN_RX_LINK_PAUSE)\n \t\tpause->rx_pause = 1;\n-\t\tpause->tx_pause = 1;\n-\t}\n+\n+out:\n+\tdevm_kfree(&vsi->back->pdev->dev, pcaps);\n }\n \n /**\n", "prefixes": [ "S11", "15/16" ] }