Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1038959/?format=api
{ "id": 1038959, "url": "http://patchwork.ozlabs.org/api/patches/1038959/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190208205101.12078-4-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190208205101.12078-4-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2019-02-08T20:50:50", "name": "[S12,03/14] ice: avoid multiple unnecessary de-references in probe", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d1d30655fc3d94140e92b93c2cb230ba49453d55", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190208205101.12078-4-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 90914, "url": "http://patchwork.ozlabs.org/api/series/90914/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=90914", "date": "2019-02-08T20:50:49", "name": "Bug fixes and minor feature updates for ice", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/90914/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1038959/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1038959/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 43x6pW2nd1z9sN1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 9 Feb 2019 07:53:23 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 131F886A51;\n\tFri, 8 Feb 2019 20:53:21 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id RctDYb2zca73; Fri, 8 Feb 2019 20:53:13 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id EBB94870F7;\n\tFri, 8 Feb 2019 20:53:11 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 3DB2E1BF973\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 8 Feb 2019 20:51:05 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 376128818E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 8 Feb 2019 20:51:05 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id eKtK1CVQJj7s for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 8 Feb 2019 20:51:04 +0000 (UTC)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id E248888145\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 8 Feb 2019 20:51:03 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Feb 2019 12:51:02 -0800", "from shasta.jf.intel.com ([10.166.241.11])\n\tby fmsmga002.fm.intel.com with ESMTP; 08 Feb 2019 12:51:01 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,348,1544515200\"; d=\"scan'208\";a=\"141869785\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 8 Feb 2019 12:50:50 -0800", "Message-Id": "<20190208205101.12078-4-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.14.5", "In-Reply-To": "<20190208205101.12078-1-anirudh.venkataramanan@intel.com>", "References": "<20190208205101.12078-1-anirudh.venkataramanan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH S12 03/14] ice: avoid multiple unnecessary\n\tde-references in probe", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Bruce Allan <bruce.w.allan@intel.com>\n\nAdd a local variable struct device *dev to avoid unnecessary de-references\nthroughout ice_probe().\n\nSigned-off-by: Bruce Allan <bruce.w.allan@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_main.c | 33 ++++++++++++++-----------------\n 1 file changed, 15 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 47cc3f905b7f..d353de4456f5 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -2075,6 +2075,7 @@ static void ice_verify_cacheline_size(struct ice_pf *pf)\n static int ice_probe(struct pci_dev *pdev,\n \t\t const struct pci_device_id __always_unused *ent)\n {\n+\tstruct device *dev = &pdev->dev;\n \tstruct ice_pf *pf;\n \tstruct ice_hw *hw;\n \tint err;\n@@ -2086,20 +2087,20 @@ static int ice_probe(struct pci_dev *pdev,\n \n \terr = pcim_iomap_regions(pdev, BIT(ICE_BAR0), pci_name(pdev));\n \tif (err) {\n-\t\tdev_err(&pdev->dev, \"BAR0 I/O map error %d\\n\", err);\n+\t\tdev_err(dev, \"BAR0 I/O map error %d\\n\", err);\n \t\treturn err;\n \t}\n \n-\tpf = devm_kzalloc(&pdev->dev, sizeof(*pf), GFP_KERNEL);\n+\tpf = devm_kzalloc(dev, sizeof(*pf), GFP_KERNEL);\n \tif (!pf)\n \t\treturn -ENOMEM;\n \n \t/* set up for high or low dma */\n-\terr = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));\n+\terr = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));\n \tif (err)\n-\t\terr = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));\n+\t\terr = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32));\n \tif (err) {\n-\t\tdev_err(&pdev->dev, \"DMA configuration failed: 0x%x\\n\", err);\n+\t\tdev_err(dev, \"DMA configuration failed: 0x%x\\n\", err);\n \t\treturn err;\n \t}\n \n@@ -2133,12 +2134,12 @@ static int ice_probe(struct pci_dev *pdev,\n \n \terr = ice_init_hw(hw);\n \tif (err) {\n-\t\tdev_err(&pdev->dev, \"ice_init_hw failed: %d\\n\", err);\n+\t\tdev_err(dev, \"ice_init_hw failed: %d\\n\", err);\n \t\terr = -EIO;\n \t\tgoto err_exit_unroll;\n \t}\n \n-\tdev_info(&pdev->dev, \"firmware %d.%d.%05d api %d.%d\\n\",\n+\tdev_info(dev, \"firmware %d.%d.%05d api %d.%d\\n\",\n \t\t hw->fw_maj_ver, hw->fw_min_ver, hw->fw_build,\n \t\t hw->api_maj_ver, hw->api_min_ver);\n \n@@ -2152,8 +2153,8 @@ static int ice_probe(struct pci_dev *pdev,\n \t\tgoto err_init_pf_unroll;\n \t}\n \n-\tpf->vsi = devm_kcalloc(&pdev->dev, pf->num_alloc_vsi,\n-\t\t\t sizeof(*pf->vsi), GFP_KERNEL);\n+\tpf->vsi = devm_kcalloc(dev, pf->num_alloc_vsi, sizeof(*pf->vsi),\n+\t\t\t GFP_KERNEL);\n \tif (!pf->vsi) {\n \t\terr = -ENOMEM;\n \t\tgoto err_init_pf_unroll;\n@@ -2161,8 +2162,7 @@ static int ice_probe(struct pci_dev *pdev,\n \n \terr = ice_init_interrupt_scheme(pf);\n \tif (err) {\n-\t\tdev_err(&pdev->dev,\n-\t\t\t\"ice_init_interrupt_scheme failed: %d\\n\", err);\n+\t\tdev_err(dev, \"ice_init_interrupt_scheme failed: %d\\n\", err);\n \t\terr = -EIO;\n \t\tgoto err_init_interrupt_unroll;\n \t}\n@@ -2178,15 +2178,13 @@ static int ice_probe(struct pci_dev *pdev,\n \tif (test_bit(ICE_FLAG_MSIX_ENA, pf->flags)) {\n \t\terr = ice_req_irq_msix_misc(pf);\n \t\tif (err) {\n-\t\t\tdev_err(&pdev->dev,\n-\t\t\t\t\"setup of misc vector failed: %d\\n\", err);\n+\t\t\tdev_err(dev, \"setup of misc vector failed: %d\\n\", err);\n \t\t\tgoto err_init_interrupt_unroll;\n \t\t}\n \t}\n \n \t/* create switch struct for the switch element created by FW on boot */\n-\tpf->first_sw = devm_kzalloc(&pdev->dev, sizeof(*pf->first_sw),\n-\t\t\t\t GFP_KERNEL);\n+\tpf->first_sw = devm_kzalloc(dev, sizeof(*pf->first_sw), GFP_KERNEL);\n \tif (!pf->first_sw) {\n \t\terr = -ENOMEM;\n \t\tgoto err_msix_misc_unroll;\n@@ -2204,8 +2202,7 @@ static int ice_probe(struct pci_dev *pdev,\n \n \terr = ice_setup_pf_sw(pf);\n \tif (err) {\n-\t\tdev_err(&pdev->dev,\n-\t\t\t\"probe failed due to setup pf switch:%d\\n\", err);\n+\t\tdev_err(dev, \"probe failed due to setup pf switch:%d\\n\", err);\n \t\tgoto err_alloc_sw_unroll;\n \t}\n \n@@ -2227,7 +2224,7 @@ static int ice_probe(struct pci_dev *pdev,\n \tice_free_irq_msix_misc(pf);\n err_init_interrupt_unroll:\n \tice_clear_interrupt_scheme(pf);\n-\tdevm_kfree(&pdev->dev, pf->vsi);\n+\tdevm_kfree(dev, pf->vsi);\n err_init_pf_unroll:\n \tice_deinit_pf(pf);\n \tice_deinit_hw(hw);\n", "prefixes": [ "S12", "03/14" ] }