Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1037798/?format=api
{ "id": 1037798, "url": "http://patchwork.ozlabs.org/api/patches/1037798/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190206230826.24970-3-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190206230826.24970-3-alice.michael@intel.com>", "list_archive_url": null, "date": "2019-02-06T23:08:17", "name": "[next,S2-V2,03/12] i40e: don't allow changes to HW vlan stripping on active port vlans", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "160705064e1a53f6214656acb39316da9f73d2ad", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190206230826.24970-3-alice.michael@intel.com/mbox/", "series": [ { "id": 90473, "url": "http://patchwork.ozlabs.org/api/series/90473/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=90473", "date": "2019-02-06T23:08:19", "name": "[next,S2-V2,01/12] i40e: Queues are reserved despite \"Invalid argument\" error.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/90473/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1037798/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1037798/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 43vxww6kLYz9s4Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 7 Feb 2019 10:09:52 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7D18985D95;\n\tWed, 6 Feb 2019 23:09:51 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id u57-FNMTsKiJ; Wed, 6 Feb 2019 23:09:41 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id F136586B8E;\n\tWed, 6 Feb 2019 23:09:31 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7C2651BF95C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 6 Feb 2019 23:09:18 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 782B8863BE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 6 Feb 2019 23:09:18 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id kUW73DE+Cq7h for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 6 Feb 2019 23:09:17 +0000 (UTC)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 5D390861B2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 6 Feb 2019 23:09:17 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t06 Feb 2019 15:09:17 -0800", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby fmsmga002.fm.intel.com with ESMTP; 06 Feb 2019 15:09:16 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,342,1544515200\"; d=\"scan'208\";a=\"141300908\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Wed, 6 Feb 2019 15:08:17 -0800", "Message-Id": "<20190206230826.24970-3-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20190206230826.24970-1-alice.michael@intel.com>", "References": "<20190206230826.24970-1-alice.michael@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S2-V2 03/12] i40e: don't allow\n\tchanges to HW vlan stripping on active port vlans", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Nicholas Nunley <nicholas.d.nunley@intel.com>\n\nModifying the vlan stripping options when a port vlan is configured\nwill break traffic for the VSI, and conceptually doesn't make sense,\nso don't allow this.\n\nSigned-off-by: Nicholas Nunley <nicholas.d.nunley@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex d975e25107c1..3b6768980d8c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -2654,6 +2654,10 @@ void i40e_vlan_stripping_enable(struct i40e_vsi *vsi)\n \tstruct i40e_vsi_context ctxt;\n \ti40e_status ret;\n \n+\t/* Don't modify stripping options if a port vlan is active */\n+\tif (vsi->info.pvid)\n+\t\treturn;\n+\n \tif ((vsi->info.valid_sections &\n \t cpu_to_le16(I40E_AQ_VSI_PROP_VLAN_VALID)) &&\n \t ((vsi->info.port_vlan_flags & I40E_AQ_VSI_PVLAN_MODE_MASK) == 0))\n@@ -2684,6 +2688,10 @@ void i40e_vlan_stripping_disable(struct i40e_vsi *vsi)\n \tstruct i40e_vsi_context ctxt;\n \ti40e_status ret;\n \n+\t/* Don't modify stripping options if a port vlan is active */\n+\tif (vsi->info.pvid)\n+\t\treturn;\n+\n \tif ((vsi->info.valid_sections &\n \t cpu_to_le16(I40E_AQ_VSI_PROP_VLAN_VALID)) &&\n \t ((vsi->info.port_vlan_flags & I40E_AQ_VSI_PVLAN_EMOD_MASK) ==\n", "prefixes": [ "next", "S2-V2", "03/12" ] }