Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1037787/?format=api
{ "id": 1037787, "url": "http://patchwork.ozlabs.org/api/patches/1037787/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190206230826.24970-5-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190206230826.24970-5-alice.michael@intel.com>", "list_archive_url": null, "date": "2019-02-06T23:08:19", "name": "[next,S2-V2,05/12] i40e: Fix for 10G ports LED not blinking", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d1265acde4f2b57b880d0de5a58fb557cc8e5cd4", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190206230826.24970-5-alice.michael@intel.com/mbox/", "series": [ { "id": 90473, "url": "http://patchwork.ozlabs.org/api/series/90473/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=90473", "date": "2019-02-06T23:08:19", "name": "[next,S2-V2,01/12] i40e: Queues are reserved despite \"Invalid argument\" error.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/90473/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1037787/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1037787/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 43vxwc4CYMz9sLw\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 7 Feb 2019 10:09:36 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id BA12186D78;\n\tWed, 6 Feb 2019 23:09:34 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id eLUv42dHN0uG; Wed, 6 Feb 2019 23:09:33 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id BD17E863BE;\n\tWed, 6 Feb 2019 23:09:32 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 5554C1BF958\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 6 Feb 2019 23:09:18 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 50EBD8636A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 6 Feb 2019 23:09:18 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id O4t24uB9deln for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 6 Feb 2019 23:09:17 +0000 (UTC)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id D3AA6863BE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 6 Feb 2019 23:09:17 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t06 Feb 2019 15:09:17 -0800", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby fmsmga002.fm.intel.com with ESMTP; 06 Feb 2019 15:09:17 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,342,1544515200\"; d=\"scan'208\";a=\"141300915\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Wed, 6 Feb 2019 15:08:19 -0800", "Message-Id": "<20190206230826.24970-5-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20190206230826.24970-1-alice.michael@intel.com>", "References": "<20190206230826.24970-1-alice.michael@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S2-V2 05/12] i40e: Fix for 10G ports\n\tLED not blinking", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Piotr Marczak <piotr.marczak@intel.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Piotr Marczak <piotr.marczak@intel.com>\n\nOn some hardware LEDs would not blink after command 'ethtool -p {eth-port}'\nin certain circumstances. Now, function does not care about the activity\nof the LED (though still preserves its state) but forcibly executes\nidentification blinking and then restores the LED state.\n\nSigned-off-by: Piotr Marczak <piotr.marczak@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_common.c | 33 -------------------\n 1 file changed, 33 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c\nindex 486a406789b8..dd6b3b3ac5c6 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c\n@@ -1466,7 +1466,6 @@ static u32 i40e_led_is_mine(struct i40e_hw *hw, int idx)\n **/\n u32 i40e_led_get(struct i40e_hw *hw)\n {\n-\tu32 current_mode = 0;\n \tu32 mode = 0;\n \tint i;\n \n@@ -1479,21 +1478,6 @@ u32 i40e_led_get(struct i40e_hw *hw)\n \t\tif (!gpio_val)\n \t\t\tcontinue;\n \n-\t\t/* ignore gpio LED src mode entries related to the activity\n-\t\t * LEDs\n-\t\t */\n-\t\tcurrent_mode = ((gpio_val & I40E_GLGEN_GPIO_CTL_LED_MODE_MASK)\n-\t\t\t\t>> I40E_GLGEN_GPIO_CTL_LED_MODE_SHIFT);\n-\t\tswitch (current_mode) {\n-\t\tcase I40E_COMBINED_ACTIVITY:\n-\t\tcase I40E_FILTER_ACTIVITY:\n-\t\tcase I40E_MAC_ACTIVITY:\n-\t\tcase I40E_LINK_ACTIVITY:\n-\t\t\tcontinue;\n-\t\tdefault:\n-\t\t\tbreak;\n-\t\t}\n-\n \t\tmode = (gpio_val & I40E_GLGEN_GPIO_CTL_LED_MODE_MASK) >>\n \t\t\tI40E_GLGEN_GPIO_CTL_LED_MODE_SHIFT;\n \t\tbreak;\n@@ -1513,7 +1497,6 @@ u32 i40e_led_get(struct i40e_hw *hw)\n **/\n void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink)\n {\n-\tu32 current_mode = 0;\n \tint i;\n \n \tif (mode & 0xfffffff0)\n@@ -1527,22 +1510,6 @@ void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink)\n \n \t\tif (!gpio_val)\n \t\t\tcontinue;\n-\n-\t\t/* ignore gpio LED src mode entries related to the activity\n-\t\t * LEDs\n-\t\t */\n-\t\tcurrent_mode = ((gpio_val & I40E_GLGEN_GPIO_CTL_LED_MODE_MASK)\n-\t\t\t\t>> I40E_GLGEN_GPIO_CTL_LED_MODE_SHIFT);\n-\t\tswitch (current_mode) {\n-\t\tcase I40E_COMBINED_ACTIVITY:\n-\t\tcase I40E_FILTER_ACTIVITY:\n-\t\tcase I40E_MAC_ACTIVITY:\n-\t\tcase I40E_LINK_ACTIVITY:\n-\t\t\tcontinue;\n-\t\tdefault:\n-\t\t\tbreak;\n-\t\t}\n-\n \t\tgpio_val &= ~I40E_GLGEN_GPIO_CTL_LED_MODE_MASK;\n \t\t/* this & is a bit of paranoia, but serves as a range check */\n \t\tgpio_val |= ((mode << I40E_GLGEN_GPIO_CTL_LED_MODE_SHIFT) &\n", "prefixes": [ "next", "S2-V2", "05/12" ] }