Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1034,
    "url": "http://patchwork.ozlabs.org/api/patches/1034/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20080923.013446.239958956.davem@davemloft.net/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20080923.013446.239958956.davem@davemloft.net>",
    "list_archive_url": null,
    "date": "2008-09-23T08:34:46",
    "name": ": ppp_generic: Use skb_peek() in ppp_receive_mp_frame().",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "dcdfe06d3ee55e6bbba126dbbef414e7b87e3ae3",
    "submitter": {
        "id": 15,
        "url": "http://patchwork.ozlabs.org/api/people/15/?format=api",
        "name": "David Miller",
        "email": "davem@davemloft.net"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20080923.013446.239958956.davem@davemloft.net/mbox/",
    "series": [],
    "comments": "http://patchwork.ozlabs.org/api/patches/1034/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/1034/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 6CC0CDDDF5\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 23 Sep 2008 18:35:10 +1000 (EST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752924AbYIWIe7 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 23 Sep 2008 04:34:59 -0400",
            "(majordomo@vger.kernel.org) by vger.kernel.org id S1752918AbYIWIe6\n\t(ORCPT <rfc822; netdev-outgoing>); Tue, 23 Sep 2008 04:34:58 -0400",
            "from 74-93-104-97-Washington.hfc.comcastbusiness.net\n\t([74.93.104.97]:55362\n\t\"EHLO sunset.davemloft.net\" rhost-flags-OK-FAIL-OK-OK)\n\tby vger.kernel.org with ESMTP id S1752522AbYIWIe6 (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 23 Sep 2008 04:34:58 -0400",
            "from localhost (localhost [127.0.0.1])\n\tby sunset.davemloft.net (Postfix) with ESMTP id 99353C8C181\n\tfor <netdev@vger.kernel.org>; Tue, 23 Sep 2008 01:34:46 -0700 (PDT)"
        ],
        "Date": "Tue, 23 Sep 2008 01:34:46 -0700 (PDT)",
        "Message-Id": "<20080923.013446.239958956.davem@davemloft.net>",
        "To": "netdev@vger.kernel.org",
        "Subject": "[PATCH]: ppp_generic: Use skb_peek() in ppp_receive_mp_frame().",
        "From": "David Miller <davem@davemloft.net>",
        "X-Mailer": "Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI)",
        "Mime-Version": "1.0",
        "Content-Type": "Text/Plain; charset=us-ascii",
        "Content-Transfer-Encoding": "7bit",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "I'm going to try and take baby steps with these conversions\nin PPP.\n\nppp_generic: Use skb_peek() in ppp_receive_mp_frame().\n\nSigned-off-by: David S. Miller <davem@davemloft.net>\n---\n drivers/net/ppp_generic.c |    8 +++++---\n 1 files changed, 5 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/drivers/net/ppp_generic.c b/drivers/net/ppp_generic.c\nindex 98e0495..5d4d215 100644\n--- a/drivers/net/ppp_generic.c\n+++ b/drivers/net/ppp_generic.c\n@@ -1833,9 +1833,11 @@ ppp_receive_mp_frame(struct ppp *ppp, struct sk_buff *skb, struct channel *pch)\n \n \t/* If the queue is getting long, don't wait any longer for packets\n \t   before the start of the queue. */\n-\tif (skb_queue_len(&ppp->mrq) >= PPP_MP_MAX_QLEN\n-\t    && seq_before(ppp->minseq, ppp->mrq.next->sequence))\n-\t\tppp->minseq = ppp->mrq.next->sequence;\n+\tif (skb_queue_len(&ppp->mrq) >= PPP_MP_MAX_QLEN) {\n+\t\tstruct sk_buff *skb = skb_peek(&ppp->mrq);\n+\t\tif (seq_before(ppp->minseq, skb->sequence))\n+\t\t\tppp->minseq = skb->sequence;\n+\t}\n \n \t/* Pull completed packets off the queue and receive them. */\n \twhile ((skb = ppp_mp_reconstruct(ppp)))\n",
    "prefixes": []
}